)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"666c161dc948f6453591bc8a5bd5473b6d03902a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Francesco Di Nucci \u003cd1nuc0m@protonmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-21 09:06:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat: project can select floating IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Include in form \"Project/Network/Floating IPs/Allocate IP to Project\""},{"line_number":10,"context_line":"the code from form \"Admin/Network/Floating IPs/Allocate IP to Project\""},{"line_number":11,"context_line":"that manages specific floating IP selection. The API call was the same,"},{"line_number":12,"context_line":"only parameters were different."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I004e8ffebc464a9e1ef6858885a13fb2b1e8050e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9b51bfb5_205e8f76","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":31},"updated":"2024-06-25 07:38:41.000000000","message":"Commit message could be improved like below:\n\nAdd optional floating IP address field under Project Dashboard\n\nThis patch added \"Floating Ip Address(optional)` field which allow users to optionally specify a floating IP address while Allocating Floating IP from Floating Panel under Project Dashboard.","commit_id":"7dcf0dc23f57cd1dc6771c1c1129172464e362f1"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"e0c7d9c2645cd85f646ccc3c91940271c879be69","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Francesco Di Nucci \u003cd1nuc0m@protonmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-21 09:06:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat: project can select floating IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Include in form \"Project/Network/Floating IPs/Allocate IP to Project\""},{"line_number":10,"context_line":"the code from form \"Admin/Network/Floating IPs/Allocate IP to Project\""},{"line_number":11,"context_line":"that manages specific floating IP selection. The API call was the same,"},{"line_number":12,"context_line":"only parameters were different."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I004e8ffebc464a9e1ef6858885a13fb2b1e8050e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2c27c240_8b692789","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"3d40e4cf_12a41fe0","updated":"2024-06-26 09:20:09.000000000","message":"Thanks, done","commit_id":"7dcf0dc23f57cd1dc6771c1c1129172464e362f1"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"022b4476d0ca3e0169d97683684d2abb26d818ee","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Francesco Di Nucci \u003cd1nuc0m@protonmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-21 09:06:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat: project can select floating IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Include in form \"Project/Network/Floating IPs/Allocate IP to Project\""},{"line_number":10,"context_line":"the code from form \"Admin/Network/Floating IPs/Allocate IP to Project\""},{"line_number":11,"context_line":"that manages specific floating IP selection. The API call was the same,"},{"line_number":12,"context_line":"only parameters were different."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I004e8ffebc464a9e1ef6858885a13fb2b1e8050e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3d40e4cf_12a41fe0","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"4beaa0c1_9e5ea85f","updated":"2024-06-25 13:19:37.000000000","message":"Yes please update the commit message so that if someone is looking at this code in the future, it will be easy to understand why this change was done.","commit_id":"7dcf0dc23f57cd1dc6771c1c1129172464e362f1"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"19307320777aae3a04d280f13ff6c4cbf9bba558","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Francesco Di Nucci \u003cd1nuc0m@protonmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-21 09:06:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat: project can select floating IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Include in form \"Project/Network/Floating IPs/Allocate IP to Project\""},{"line_number":10,"context_line":"the code from form \"Admin/Network/Floating IPs/Allocate IP to Project\""},{"line_number":11,"context_line":"that manages specific floating IP selection. The API call was the same,"},{"line_number":12,"context_line":"only parameters were different."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I004e8ffebc464a9e1ef6858885a13fb2b1e8050e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4beaa0c1_9e5ea85f","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"9b51bfb5_205e8f76","updated":"2024-06-25 12:53:04.000000000","message":"I don\u0027t know, I\u0027m not actively \"adding\" code, as I just mirrored a pre-existing function, should I edit the commit nonetheless?","commit_id":"7dcf0dc23f57cd1dc6771c1c1129172464e362f1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"666c161dc948f6453591bc8a5bd5473b6d03902a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb06cf35_265386c1","updated":"2024-06-25 07:38:41.000000000","message":"Thanks, LGTM.","commit_id":"7dcf0dc23f57cd1dc6771c1c1129172464e362f1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"4d4bdf1c5b654cfc93b3fed0ad756bc99189758f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3fed3b75_0e251bc4","updated":"2024-07-10 17:02:12.000000000","message":"recheck, jobs are fixed","commit_id":"a70ba5525bc26a6dc85169b5e49795d215f2d9c9"}],"openstack_dashboard/dashboards/project/floating_ips/forms.py":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"666c161dc948f6453591bc8a5bd5473b6d03902a","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FloatingIpAllocate(forms.SelfHandlingForm):"},{"line_number":31,"context_line":"    pool \u003d forms.ThemableChoiceField(label\u003d_(\"Pool\"))"},{"line_number":32,"context_line":"    floating_ip_address \u003d forms.IPField("},{"line_number":33,"context_line":"        label\u003d_(\"Floating IP Address (optional)\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"762a9e7f_88a8fdb0","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":48},"updated":"2024-06-25 07:38:41.000000000","message":"In future, we can inherit this class in ``dashboards/admin/floating_ips/forms.py`` to remove duplicate code.","commit_id":"7dcf0dc23f57cd1dc6771c1c1129172464e362f1"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"e0c7d9c2645cd85f646ccc3c91940271c879be69","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FloatingIpAllocate(forms.SelfHandlingForm):"},{"line_number":31,"context_line":"    pool \u003d forms.ThemableChoiceField(label\u003d_(\"Pool\"))"},{"line_number":32,"context_line":"    floating_ip_address \u003d forms.IPField("},{"line_number":33,"context_line":"        label\u003d_(\"Floating IP Address (optional)\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"d9575e54_11d4260b","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":48},"in_reply_to":"4508da69_64307464","updated":"2024-06-26 09:20:09.000000000","message":"Thanks, I\u0027ll have a look at it for a future patch","commit_id":"7dcf0dc23f57cd1dc6771c1c1129172464e362f1"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"19307320777aae3a04d280f13ff6c4cbf9bba558","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FloatingIpAllocate(forms.SelfHandlingForm):"},{"line_number":31,"context_line":"    pool \u003d forms.ThemableChoiceField(label\u003d_(\"Pool\"))"},{"line_number":32,"context_line":"    floating_ip_address \u003d forms.IPField("},{"line_number":33,"context_line":"        label\u003d_(\"Floating IP Address (optional)\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"c08b5bba_d42f0029","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":48},"in_reply_to":"762a9e7f_88a8fdb0","updated":"2024-06-25 12:53:04.000000000","message":"The two API calls are slightly different, as one allows to select the tenant, how should this be done?","commit_id":"7dcf0dc23f57cd1dc6771c1c1129172464e362f1"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"022b4476d0ca3e0169d97683684d2abb26d818ee","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FloatingIpAllocate(forms.SelfHandlingForm):"},{"line_number":31,"context_line":"    pool \u003d forms.ThemableChoiceField(label\u003d_(\"Pool\"))"},{"line_number":32,"context_line":"    floating_ip_address \u003d forms.IPField("},{"line_number":33,"context_line":"        label\u003d_(\"Floating IP Address (optional)\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"4508da69_64307464","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":48},"in_reply_to":"c08b5bba_d42f0029","updated":"2024-06-25 13:19:37.000000000","message":"yes, correct. You don\u0027t have to make that change here. You can do that in a separate patch if interested. You can find the same thing was done for other forms like [1].\n\n[1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/routers/forms.py#L22","commit_id":"7dcf0dc23f57cd1dc6771c1c1129172464e362f1"}]}