)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b7dd6f40e9c35149626df76ecde669923f8ca892","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a3593907_24ac1a1f","updated":"2024-07-18 08:36:20.000000000","message":"recheck\nintegration test failures are not related (volume download test and floating IP associate)","commit_id":"90a3427a25bdbf37ad6db664764059d0d48c08bc"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"7d32e8136ea6bf9886a6cf5e3016a40d7173a674","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d4e661f7_98b97653","updated":"2024-08-08 11:24:43.000000000","message":"LGTM, thank you!","commit_id":"8c68132a8edf0ce7ad2bfec6e21fb21cbf149934"}],"openstack_dashboard/test/unit/api/test_neutron.py":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"8787e1aecae29c25ec56fcbddbc539818794ac92","unresolved":true,"context_lines":[{"line_number":1330,"context_line":"        neutron_client.trunks.assert_called_once_with()"},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"    @mock.patch.object(api.neutron, \u0027networkclient\u0027)"},{"line_number":1333,"context_line":"    def test_trunk_show(self, mock_neutronclient):"},{"line_number":1334,"context_line":"        trunk \u003d self.api_tp_trunks_sdk[0]"},{"line_number":1335,"context_line":"        trunk_id \u003d self.api_tp_trunks_sdk[0][\u0027id\u0027]"},{"line_number":1336,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b7abf5b9_5bff466b","line":1333,"updated":"2024-08-01 14:29:18.000000000","message":"Since it\u0027s moving from using neutronclient to networkclient, should not be mock_neutronclient renamed to mock_networkclient, neutron_client to network_client, etc.? Is the current naming confusing just for me?","commit_id":"90a3427a25bdbf37ad6db664764059d0d48c08bc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8f16b23f140cf1189c6911654e8afb3669305d4a","unresolved":false,"context_lines":[{"line_number":1330,"context_line":"        neutron_client.trunks.assert_called_once_with()"},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"    @mock.patch.object(api.neutron, \u0027networkclient\u0027)"},{"line_number":1333,"context_line":"    def test_trunk_show(self, mock_neutronclient):"},{"line_number":1334,"context_line":"        trunk \u003d self.api_tp_trunks_sdk[0]"},{"line_number":1335,"context_line":"        trunk_id \u003d self.api_tp_trunks_sdk[0][\u0027id\u0027]"},{"line_number":1336,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"18c56610_e977bfb1","line":1333,"in_reply_to":"b7abf5b9_5bff466b","updated":"2024-08-05 15:29:58.000000000","message":"sure, It was on my nice-to-be-list, thanks","commit_id":"90a3427a25bdbf37ad6db664764059d0d48c08bc"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"d74809ada204900b1317eaf078e060a903a72c5f","unresolved":true,"context_lines":[{"line_number":1409,"context_line":"                                           old_trunk, new_trunk)"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"        self.assertIsInstance(ret_val, api.neutron.Trunk)"},{"line_number":1412,"context_line":"        self.assertEqual(api.neutron.Trunk(trunk_data).id, ret_val.id)"},{"line_number":1413,"context_line":"        self.assertEqual(ret_val.name, new_trunk[\u0027name\u0027])"},{"line_number":1414,"context_line":"        network_client.update_trunk.assert_called_once_with("},{"line_number":1415,"context_line":"            trunk_id, **{\u0027name\u0027: \u0027foo\u0027})"}],"source_content_type":"text/x-python","patch_set":4,"id":"8ae66bd7_0dfe2e90","line":1412,"range":{"start_line":1412,"start_character":8,"end_line":1412,"end_character":70},"updated":"2024-08-07 10:50:10.000000000","message":"I know it is not current change but do we really need here:\n“api.neutron.Trunk(trunk_data).id”\nsimple\n\"trunk_id\"\nwhich we have defined from trunk_data above should work the same and it is more clear.","commit_id":"05247eb7158c2e4d98fca63e266237e500c17cf9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a6ff4ea665e315df36328862a5ca3bb0fce9c804","unresolved":true,"context_lines":[{"line_number":1409,"context_line":"                                           old_trunk, new_trunk)"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"        self.assertIsInstance(ret_val, api.neutron.Trunk)"},{"line_number":1412,"context_line":"        self.assertEqual(api.neutron.Trunk(trunk_data).id, ret_val.id)"},{"line_number":1413,"context_line":"        self.assertEqual(ret_val.name, new_trunk[\u0027name\u0027])"},{"line_number":1414,"context_line":"        network_client.update_trunk.assert_called_once_with("},{"line_number":1415,"context_line":"            trunk_id, **{\u0027name\u0027: \u0027foo\u0027})"}],"source_content_type":"text/x-python","patch_set":4,"id":"c4a1dfb0_98b51ff5","line":1412,"range":{"start_line":1412,"start_character":8,"end_line":1412,"end_character":70},"in_reply_to":"8ae66bd7_0dfe2e90","updated":"2024-08-07 11:31:47.000000000","message":"thanks, I think it is safe to change this in this change, and simplify the code.","commit_id":"05247eb7158c2e4d98fca63e266237e500c17cf9"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"2d6638c7fb6d50d9f2d523b225f82c50aa4d3503","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"                                           old_trunk, new_trunk)"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"        self.assertIsInstance(ret_val, api.neutron.Trunk)"},{"line_number":1412,"context_line":"        self.assertEqual(api.neutron.Trunk(trunk_data).id, ret_val.id)"},{"line_number":1413,"context_line":"        self.assertEqual(ret_val.name, new_trunk[\u0027name\u0027])"},{"line_number":1414,"context_line":"        network_client.update_trunk.assert_called_once_with("},{"line_number":1415,"context_line":"            trunk_id, **{\u0027name\u0027: \u0027foo\u0027})"}],"source_content_type":"text/x-python","patch_set":4,"id":"118610ee_a7485def","line":1412,"range":{"start_line":1412,"start_character":8,"end_line":1412,"end_character":70},"in_reply_to":"c4a1dfb0_98b51ff5","updated":"2024-08-08 15:29:34.000000000","message":"Done","commit_id":"05247eb7158c2e4d98fca63e266237e500c17cf9"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"d74809ada204900b1317eaf078e060a903a72c5f","unresolved":true,"context_lines":[{"line_number":1442,"context_line":"                                           old_trunk, new_trunk)"},{"line_number":1443,"context_line":""},{"line_number":1444,"context_line":"        self.assertIsInstance(ret_val, api.neutron.Trunk)"},{"line_number":1445,"context_line":"        self.assertEqual(api.neutron.Trunk(trunk_data).id, ret_val.id)"},{"line_number":1446,"context_line":"        self.assertEqual(ret_val.sub_ports, new_trunk[\u0027sub_ports\u0027])"},{"line_number":1447,"context_line":"        network_client.add_trunk_subports.assert_called_once_with("},{"line_number":1448,"context_line":"            trunk_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a28acda_7b1bb963","line":1445,"range":{"start_line":1445,"start_character":8,"end_line":1445,"end_character":70},"updated":"2024-08-07 10:50:10.000000000","message":"ditto","commit_id":"05247eb7158c2e4d98fca63e266237e500c17cf9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a6ff4ea665e315df36328862a5ca3bb0fce9c804","unresolved":false,"context_lines":[{"line_number":1442,"context_line":"                                           old_trunk, new_trunk)"},{"line_number":1443,"context_line":""},{"line_number":1444,"context_line":"        self.assertIsInstance(ret_val, api.neutron.Trunk)"},{"line_number":1445,"context_line":"        self.assertEqual(api.neutron.Trunk(trunk_data).id, ret_val.id)"},{"line_number":1446,"context_line":"        self.assertEqual(ret_val.sub_ports, new_trunk[\u0027sub_ports\u0027])"},{"line_number":1447,"context_line":"        network_client.add_trunk_subports.assert_called_once_with("},{"line_number":1448,"context_line":"            trunk_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"eaaecc8f_54064fce","line":1445,"range":{"start_line":1445,"start_character":8,"end_line":1445,"end_character":70},"in_reply_to":"5a28acda_7b1bb963","updated":"2024-08-07 11:31:47.000000000","message":"Done","commit_id":"05247eb7158c2e4d98fca63e266237e500c17cf9"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"d74809ada204900b1317eaf078e060a903a72c5f","unresolved":true,"context_lines":[{"line_number":1478,"context_line":"                                           old_trunk, new_trunk)"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"        self.assertIsInstance(ret_val, api.neutron.Trunk)"},{"line_number":1481,"context_line":"        self.assertEqual(api.neutron.Trunk(trunk_data).id, ret_val.id)"},{"line_number":1482,"context_line":"        self.assertEqual(ret_val.sub_ports, new_trunk[\u0027sub_ports\u0027])"},{"line_number":1483,"context_line":"        network_client.delete_trunk_subports.assert_called_once_with("},{"line_number":1484,"context_line":"            trunk_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"79fb54e2_9a52742c","line":1481,"range":{"start_line":1481,"start_character":8,"end_line":1481,"end_character":70},"updated":"2024-08-07 10:50:10.000000000","message":"ditto","commit_id":"05247eb7158c2e4d98fca63e266237e500c17cf9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a6ff4ea665e315df36328862a5ca3bb0fce9c804","unresolved":false,"context_lines":[{"line_number":1478,"context_line":"                                           old_trunk, new_trunk)"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"        self.assertIsInstance(ret_val, api.neutron.Trunk)"},{"line_number":1481,"context_line":"        self.assertEqual(api.neutron.Trunk(trunk_data).id, ret_val.id)"},{"line_number":1482,"context_line":"        self.assertEqual(ret_val.sub_ports, new_trunk[\u0027sub_ports\u0027])"},{"line_number":1483,"context_line":"        network_client.delete_trunk_subports.assert_called_once_with("},{"line_number":1484,"context_line":"            trunk_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"b9bbf304_959d9948","line":1481,"range":{"start_line":1481,"start_character":8,"end_line":1481,"end_character":70},"in_reply_to":"79fb54e2_9a52742c","updated":"2024-08-07 11:31:47.000000000","message":"Done","commit_id":"05247eb7158c2e4d98fca63e266237e500c17cf9"}]}
