)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"385e5860ddc1b77a4d6def1adc1281bf2907f4f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e46fa5c_4fd3f321","updated":"2024-08-30 16:25:41.000000000","message":"I think this looks Ok.","commit_id":"e4a827253bd716d0ffe7b39709693f4a9f28510b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ef0316923ef6499d3b5ba49ec5f69bae66a2ed60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d554d2e1_7bff9566","updated":"2024-08-28 13:28:46.000000000","message":"recheck\nintegration-pytest failures with keypairs test is not related","commit_id":"e4a827253bd716d0ffe7b39709693f4a9f28510b"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"9d21996ff5278656037cb2467b3983ad2d5a5b4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"921130fa_e1550d65","updated":"2024-09-03 12:51:27.000000000","message":"LGTM, thank you!","commit_id":"d6ffcdd149fb2969909c8263828654810aedb6ab"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"5f465a99775c7373754b83b789b9ac3338623b78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce2cd267_062246f0","updated":"2024-09-04 07:26:26.000000000","message":"recheck, Looks like the Volume in the test test_create_instance_from_volume_demo stayed for a much longer time in status uploading/reserved (than usually) that caused that the volumes could not be properly removed and those left over caused Fail in test_volumes_pagination_demo.\nI will keep an eye out to see if it happens again","commit_id":"d6ffcdd149fb2969909c8263828654810aedb6ab"}],"horizon/forms/fields.py":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"02fd82eb6b748781c0db99cc671a5e0e31f2483e","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        try:"},{"line_number":91,"context_line":"            if self.mask:"},{"line_number":92,"context_line":"                try:"},{"line_number":93,"context_line":"                    self.ip \u003d netaddr.IPNetwork(value.strip())"},{"line_number":94,"context_line":"                except netaddr.AddrFormatError:"},{"line_number":95,"context_line":"                    self.ip \u003d netaddr.IPNetwork("},{"line_number":96,"context_line":"                        netaddr.cidr_abbrev_to_verbose(value))"}],"source_content_type":"text/x-python","patch_set":1,"id":"55394877_2426c55d","line":93,"range":{"start_line":93,"start_character":53,"end_line":93,"end_character":61},"updated":"2024-09-03 10:15:58.000000000","message":"Why is there a .strip() for value on line 93 and there is not .strip() for value on line 96?\nIf we expect any white spaces in value, then .strip() should be also on the line 96 otherwise it will return AddrFormatError if there is any white space at the beginning of value.\nIf we do not expect any white spaces in value at all then I do not see a reason to use .strip() on line 93.","commit_id":"e4a827253bd716d0ffe7b39709693f4a9f28510b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bac08009ac058b901b4d2fe929149795ee34d826","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        try:"},{"line_number":91,"context_line":"            if self.mask:"},{"line_number":92,"context_line":"                try:"},{"line_number":93,"context_line":"                    self.ip \u003d netaddr.IPNetwork(value.strip())"},{"line_number":94,"context_line":"                except netaddr.AddrFormatError:"},{"line_number":95,"context_line":"                    self.ip \u003d netaddr.IPNetwork("},{"line_number":96,"context_line":"                        netaddr.cidr_abbrev_to_verbose(value))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bcb80b0f_c7469ac5","line":93,"range":{"start_line":93,"start_character":53,"end_line":93,"end_character":61},"in_reply_to":"55394877_2426c55d","updated":"2024-09-03 12:19:02.000000000","message":"you are right, thanks","commit_id":"e4a827253bd716d0ffe7b39709693f4a9f28510b"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"9d21996ff5278656037cb2467b3983ad2d5a5b4d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        try:"},{"line_number":91,"context_line":"            if self.mask:"},{"line_number":92,"context_line":"                try:"},{"line_number":93,"context_line":"                    self.ip \u003d netaddr.IPNetwork(value.strip())"},{"line_number":94,"context_line":"                except netaddr.AddrFormatError:"},{"line_number":95,"context_line":"                    self.ip \u003d netaddr.IPNetwork("},{"line_number":96,"context_line":"                        netaddr.cidr_abbrev_to_verbose(value))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3981519f_c8d1abf5","line":93,"range":{"start_line":93,"start_character":53,"end_line":93,"end_character":61},"in_reply_to":"bcb80b0f_c7469ac5","updated":"2024-09-03 12:51:27.000000000","message":"Done","commit_id":"e4a827253bd716d0ffe7b39709693f4a9f28510b"}]}