)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"bc39d8325d66d2c859c9db25dc9abfac67d79ee4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"338ecdf5_f9792053","updated":"2024-10-18 10:25:19.000000000","message":"recheck","commit_id":"66f61889b69775446b28e3efa127b06830885abb"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"69b804430d05b3bd83f60764bfdb5ec2f8bec66a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ac067cba_1d0815f3","updated":"2024-10-21 11:38:37.000000000","message":"recheck, random volume failure","commit_id":"66f61889b69775446b28e3efa127b06830885abb"}],"openstack_dashboard/test/selenium/integration/conftest.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"af98cb07cf213edd4381e6aeba6082c42849f8d9","unresolved":true,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    count \u003d request.param[0]"},{"line_number":208,"context_line":"    auto_ip_param \u003d request.param[1]"},{"line_number":209,"context_line":"    if auto_ip_param is False:"},{"line_number":210,"context_line":"        ip_pool_param \u003d None"},{"line_number":211,"context_line":"    else:"},{"line_number":212,"context_line":"        ip_pool_param \u003d config.network.external_network"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd1154fe_e4c26197","line":209,"updated":"2024-10-16 15:27:03.000000000","message":"Usually if we want to check if something is False, we do:\n\nif not auto_ip_param:\n\nIf you want to have an optional value, it\u0027s better to use None instead.","commit_id":"455ed2faafe0963b22e681c7b78133169471871e"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"f3b29df88240f8fcae781379161adb9e51defcfc","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    count \u003d request.param[0]"},{"line_number":208,"context_line":"    auto_ip_param \u003d request.param[1]"},{"line_number":209,"context_line":"    if auto_ip_param is False:"},{"line_number":210,"context_line":"        ip_pool_param \u003d None"},{"line_number":211,"context_line":"    else:"},{"line_number":212,"context_line":"        ip_pool_param \u003d config.network.external_network"}],"source_content_type":"text/x-python","patch_set":1,"id":"29d48fc6_ed8bd4dc","line":209,"in_reply_to":"cd1154fe_e4c26197","updated":"2024-10-16 20:41:07.000000000","message":"Done","commit_id":"455ed2faafe0963b22e681c7b78133169471871e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c6d9153f71e0939b23aea2be9ec9ae43d1385a58","unresolved":true,"context_lines":[{"line_number":209,"context_line":"    if auto_ip_param:"},{"line_number":210,"context_line":"        ip_pool_param \u003d config.network.external_network"},{"line_number":211,"context_line":"    else:"},{"line_number":212,"context_line":"        ip_pool_param \u003d None"},{"line_number":213,"context_line":"    instance \u003d openstack_demo.create_server("},{"line_number":214,"context_line":"        instance_name,"},{"line_number":215,"context_line":"        image\u003dconfig.image.images_list[0],"}],"source_content_type":"text/x-python","patch_set":2,"id":"2eb8cc83_bbef1ea7","line":212,"updated":"2024-10-17 13:02:46.000000000","message":"nitty nit: You could do it in one line:\n\n    ip_pool_param \u003d config.network.external_network if auto_ip_param else None","commit_id":"66f61889b69775446b28e3efa127b06830885abb"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"1f6ac438d33cc8c5f517942d5597049e35bbe396","unresolved":true,"context_lines":[{"line_number":209,"context_line":"    if auto_ip_param:"},{"line_number":210,"context_line":"        ip_pool_param \u003d config.network.external_network"},{"line_number":211,"context_line":"    else:"},{"line_number":212,"context_line":"        ip_pool_param \u003d None"},{"line_number":213,"context_line":"    instance \u003d openstack_demo.create_server("},{"line_number":214,"context_line":"        instance_name,"},{"line_number":215,"context_line":"        image\u003dconfig.image.images_list[0],"}],"source_content_type":"text/x-python","patch_set":2,"id":"40671954_ddb29d66","line":212,"in_reply_to":"2eb8cc83_bbef1ea7","updated":"2024-10-17 13:09:21.000000000","message":"Hi, thank you, I would prefer to let is as it is as it is much better readable (at least from my point of view). If you don\u0027t have a fundamental problem with it.","commit_id":"66f61889b69775446b28e3efa127b06830885abb"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"f35d3cb0907a190adc2bc1cc892a8a5886995945","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    if auto_ip_param:"},{"line_number":210,"context_line":"        ip_pool_param \u003d config.network.external_network"},{"line_number":211,"context_line":"    else:"},{"line_number":212,"context_line":"        ip_pool_param \u003d None"},{"line_number":213,"context_line":"    instance \u003d openstack_demo.create_server("},{"line_number":214,"context_line":"        instance_name,"},{"line_number":215,"context_line":"        image\u003dconfig.image.images_list[0],"}],"source_content_type":"text/x-python","patch_set":2,"id":"bd0834b8_f54b3a54","line":212,"in_reply_to":"40671954_ddb29d66","updated":"2024-10-21 07:37:46.000000000","message":"Done","commit_id":"66f61889b69775446b28e3efa127b06830885abb"}]}