)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"5a2a2de7244af10b3c40586d540bfb2d18475f55","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Removing Uptime for instances in error state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instances in error state should not have an Uptime since"},{"line_number":10,"context_line":"it might confuse the users"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5e340523976ef2f68ecb8fc33ff91a607a812869"},{"line_number":13,"context_line":"Closes-Bug: #1308189"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_8c687389","line":10,"updated":"2014-06-27 13:04:17.000000000","message":"Please finished sentences with dot","commit_id":"ab415aee0bd84ca022ecab78150c35f47dcc74ba"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"4d472a95acf457d339f814dca2bdd670c8a08546","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Removing Uptime for instances in error state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instances in error state should not have an Uptime since"},{"line_number":10,"context_line":"it might confuse the users"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5e340523976ef2f68ecb8fc33ff91a607a812869"},{"line_number":13,"context_line":"Closes-Bug: #1308189"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baada198_aae9341c","line":10,"in_reply_to":"1ae5cdf2_8c687389","updated":"2014-07-01 14:20:37.000000000","message":"Done","commit_id":"ab415aee0bd84ca022ecab78150c35f47dcc74ba"}],"horizon/utils/filters.py":[{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"2444697ebe3a90994ade2b0916154c8356bb313a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        return default"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"@register.filter"},{"line_number":73,"context_line":"def timesince_sortable(dt):"},{"line_number":74,"context_line":"    delta \u003d timezone.now() - dt"},{"line_number":75,"context_line":"    # timedelta.total_seconds() not supported on python \u003c 2.7"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_1c975c3c","line":72,"updated":"2014-05-16 15:04:04.000000000","message":"Is it necessary to define a new filter for this? Couldn\u0027t you simply use the timesince_or_never() filter defined above, and specify your desired default (\"-\")?","commit_id":"c32c6b8d241a66f71fba75c92888e581f0742440"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"e1b1b6f859146ea11764b061d18445dc90848c5a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        return default"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"@register.filter"},{"line_number":73,"context_line":"def timesince_sortable(dt):"},{"line_number":74,"context_line":"    delta \u003d timezone.now() - dt"},{"line_number":75,"context_line":"    # timedelta.total_seconds() not supported on python \u003c 2.7"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_65331ff6","line":72,"in_reply_to":"7adec928_1c975c3c","updated":"2014-05-19 15:29:48.000000000","message":"Defining a new filter was the only way I found to make it work. I was not able to use the existing since_or_never filter with a custom default value. If I wanted to use the existing filter I\u0027d had to include the following in the column filters attribute\n\nfilters\u003d(filters.parse_isotime, filters.timesince_or_never(created, default\u003d\"-\")),\n\nAs far as I know, that would not work since when the table is rendered, the filters are executed and filters.timesince_or_never(created, default\u003d\"-\") would not be a function but a string","commit_id":"c32c6b8d241a66f71fba75c92888e581f0742440"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9c4db47a03430708f0ad7e26197c2e445593da43","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"@register.filter"},{"line_number":58,"context_line":"def timesince_or_empty(dt, default\u003dNone):"},{"line_number":59,"context_line":"    \"\"\"Call the Django ``timesince`` filter, but return the string"},{"line_number":60,"context_line":"    *default* if *dt* is not a valid ``date`` or ``datetime`` object."},{"line_number":61,"context_line":"    When *default* is None, \"-\" is returned."}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_1fc175e4","line":58,"updated":"2014-05-22 05:29:16.000000000","message":"It is almost identical between timesince_or_never and timesince_or_empty with the exception of default value, maybe a helper function would be better.","commit_id":"02437a6f413a18b3171857a31aa63bfe5279591e"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"7b4065367fc2f04fce60550834007b504e99873b","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"@register.filter"},{"line_number":58,"context_line":"def timesince_or_empty(dt, default\u003dNone):"},{"line_number":59,"context_line":"    \"\"\"Call the Django ``timesince`` filter, but return the string"},{"line_number":60,"context_line":"    *default* if *dt* is not a valid ``date`` or ``datetime`` object."},{"line_number":61,"context_line":"    When *default* is None, \"-\" is returned."}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_9cb8282c","line":58,"in_reply_to":"7adec928_1fc175e4","updated":"2014-05-22 12:59:49.000000000","message":"I don\u0027t think it worth to move the common code to a helper. We are talking about 4 lines of code. I think keeping them separate is more clear and easy to read","commit_id":"02437a6f413a18b3171857a31aa63bfe5279591e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9c4db47a03430708f0ad7e26197c2e445593da43","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    When *default* is None, \"-\" is returned."},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    if default is None:"},{"line_number":64,"context_line":"        default \u003d _(\"-\")"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    if isinstance(dt, datetime.date):"},{"line_number":67,"context_line":"        return timesince(dt)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_df72ad48","line":64,"updated":"2014-05-22 05:29:16.000000000","message":"\"-\" doesn\u0027t need to be translated.","commit_id":"02437a6f413a18b3171857a31aa63bfe5279591e"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"7b4065367fc2f04fce60550834007b504e99873b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    When *default* is None, \"-\" is returned."},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    if default is None:"},{"line_number":64,"context_line":"        default \u003d _(\"-\")"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    if isinstance(dt, datetime.date):"},{"line_number":67,"context_line":"        return timesince(dt)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_bcb5e432","line":64,"in_reply_to":"7adec928_df72ad48","updated":"2014-05-22 12:59:49.000000000","message":"Done","commit_id":"02437a6f413a18b3171857a31aa63bfe5279591e"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"5a2a2de7244af10b3c40586d540bfb2d18475f55","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    When *default* is None, \"-\" is returned."},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    if default is None:"},{"line_number":64,"context_line":"        default \u003d \"-\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    if isinstance(dt, datetime.date):"},{"line_number":67,"context_line":"        return timesince(dt)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_acb52f1a","line":64,"updated":"2014-06-27 13:04:17.000000000","message":"this is unneded, or set default\u003d\u0027-\u0027 in the method signature or do it in line 70 as en inline if.","commit_id":"ab415aee0bd84ca022ecab78150c35f47dcc74ba"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"4d472a95acf457d339f814dca2bdd670c8a08546","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    When *default* is None, \"-\" is returned."},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    if default is None:"},{"line_number":64,"context_line":"        default \u003d \"-\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    if isinstance(dt, datetime.date):"},{"line_number":67,"context_line":"        return timesince(dt)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_ca874860","line":64,"in_reply_to":"1ae5cdf2_acb52f1a","updated":"2014-07-01 14:20:37.000000000","message":"The idea is that you can call this method with the default value you want but if you didn\u0027t provide a default value, then \"-\" will be returned. Your suggestion will not allow such option","commit_id":"ab415aee0bd84ca022ecab78150c35f47dcc74ba"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"56fbc3e0600cc116e34a104b1ac6eea1c0c61316","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    When *default* is None, \"-\" is returned."},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    if default is None:"},{"line_number":64,"context_line":"        default \u003d \"-\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    if isinstance(dt, datetime.date):"},{"line_number":67,"context_line":"        return timesince(dt)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_cad82856","line":64,"in_reply_to":"baada198_ca874860","updated":"2014-07-01 14:24:04.000000000","message":"Why not?\n\n\tdef timesince_or_empty(dt, default\u003d\u0027-\u0027):","commit_id":"ab415aee0bd84ca022ecab78150c35f47dcc74ba"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"4d802d7507ed92b9b222a731ddff970e3ac29b8c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    When *default* is None, \"-\" is returned."},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    if default is None:"},{"line_number":64,"context_line":"        default \u003d \"-\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    if isinstance(dt, datetime.date):"},{"line_number":67,"context_line":"        return timesince(dt)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_a5ffa500","line":64,"in_reply_to":"baada198_cad82856","updated":"2014-07-01 15:04:50.000000000","message":"Consistency with timesince_or_never","commit_id":"ab415aee0bd84ca022ecab78150c35f47dcc74ba"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"c44ca6e87c3ad3f5c7c0190f48fee810fe1b217f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    if default is None:"},{"line_number":64,"context_line":"        default \u003d \"-\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    if isinstance(dt, datetime.date):"},{"line_number":67,"context_line":"        return timesince(dt)"},{"line_number":68,"context_line":"    else:"},{"line_number":69,"context_line":"        return default"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_30e827b4","line":66,"updated":"2014-07-01 19:10:29.000000000","message":"Does it make sense to hook this function into timesince_sortable instead using timesince directly?","commit_id":"675b29b05fb785901ca1ddb5156ea68f1bfc4201"}],"horizon/utils/functions.py":[{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"2444697ebe3a90994ade2b0916154c8356bb313a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      re.split(r\u0027(\\d+)\u0027, getattr(x, attr, x))]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def getInstanceUpTime(instance):"},{"line_number":78,"context_line":"    if instance.status !\u003d \u0027ERROR\u0027:"},{"line_number":79,"context_line":"        return instance.created"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_7ce940e5","line":77,"updated":"2014-05-16 15:04:04.000000000","message":"Please use lowercase words separated by underscores for function names, as specified by PEP8 (http://legacy.python.org/dev/peps/pep-0008/#function-names).\n\nAlso I think the name itself is a bit misleading - you are not getting the uptime here, you\u0027re getting the creation time.","commit_id":"c32c6b8d241a66f71fba75c92888e581f0742440"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"e1b1b6f859146ea11764b061d18445dc90848c5a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      re.split(r\u0027(\\d+)\u0027, getattr(x, attr, x))]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def getInstanceUpTime(instance):"},{"line_number":78,"context_line":"    if instance.status !\u003d \u0027ERROR\u0027:"},{"line_number":79,"context_line":"        return instance.created"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_e5080f2a","line":77,"in_reply_to":"7adec928_7ce940e5","updated":"2014-05-19 15:29:48.000000000","message":"Done. Renamed to get_available_instance_created_time","commit_id":"c32c6b8d241a66f71fba75c92888e581f0742440"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"3e14e982cda229af10e94b5a0e4e3fc43a72adbd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      re.split(r\u0027(\\d+)\u0027, getattr(x, attr, x))]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def get_available_instance_created_time(instance):"},{"line_number":78,"context_line":"    if instance.status !\u003d \u0027ERROR\u0027:"},{"line_number":79,"context_line":"        return instance.created"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_44761e07","line":77,"updated":"2014-05-19 18:56:15.000000000","message":"I\u0027d argue that this belongs more in an api library - openstack_dashboard/api/nova.py - within the Server class definition.","commit_id":"7db3cc9f10474a00e8018a0172db98280ed91b27"}],"openstack_dashboard/api/nova.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9c4db47a03430708f0ad7e26197c2e445593da43","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        return getattr(self, \u0027OS-EXT-AZ:availability_zone\u0027, \"\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def get_available_instance_created_time(instance):"},{"line_number":119,"context_line":"        if instance.status !\u003d \u0027ERROR\u0027:"},{"line_number":120,"context_line":"            return instance.created"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_7f53596c","line":118,"updated":"2014-05-22 05:29:16.000000000","message":"You can change the function like image_name() as below:\ndef created_time(self):\n    ...\n\nso you can just use \u0027create_time\u0027 as Column attribute like:\n created \u003d tables.Column(\u0027created_time\u0027, ...) \nwhich will call the function above.","commit_id":"02437a6f413a18b3171857a31aa63bfe5279591e"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"7b4065367fc2f04fce60550834007b504e99873b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        return getattr(self, \u0027OS-EXT-AZ:availability_zone\u0027, \"\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def get_available_instance_created_time(instance):"},{"line_number":119,"context_line":"        if instance.status !\u003d \u0027ERROR\u0027:"},{"line_number":120,"context_line":"            return instance.created"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_3c81d44a","line":118,"in_reply_to":"7adec928_7f53596c","updated":"2014-05-22 12:59:49.000000000","message":"Done","commit_id":"02437a6f413a18b3171857a31aa63bfe5279591e"}],"openstack_dashboard/dashboards/admin/instances/tables.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"7f77e32e65ebf5e49cbaaae2bb21b8ebc621fd38","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return instances"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def getInstanceUpTime(instance):"},{"line_number":109,"context_line":"    if instance.status !\u003d \u0027ERROR\u0027:"},{"line_number":110,"context_line":"        return instance.created"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_ffb47083","line":108,"updated":"2014-05-15 18:58:33.000000000","message":"this is the same code as here: openstack_dashboard/dashboards/project/instances/tables.py\n\nwould you mind not to copy it, but to reference it or move it to a single location else?","commit_id":"5fa52a57544729df10e3e380606e051998388f6c"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"3b65e732f2a4a16729cf0b5470d051519c683c5e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return instances"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def getInstanceUpTime(instance):"},{"line_number":109,"context_line":"    if instance.status !\u003d \u0027ERROR\u0027:"},{"line_number":110,"context_line":"        return instance.created"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_3c9d035a","line":108,"in_reply_to":"7adec928_ffb47083","updated":"2014-05-15 20:40:47.000000000","message":"Done. Moved it to functions in horizon.utils","commit_id":"5fa52a57544729df10e3e380606e051998388f6c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9c4db47a03430708f0ad7e26197c2e445593da43","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    created \u003d tables.Column(api.nova.Server."},{"line_number":158,"context_line":"                            get_available_instance_created_time,"},{"line_number":159,"context_line":"                            verbose_name\u003d_(\"Uptime\"),"},{"line_number":160,"context_line":"                            empty_value\u003d\"-\","},{"line_number":161,"context_line":"                            filters\u003d(filters.parse_isotime,"},{"line_number":162,"context_line":"                                     filters.timesince_or_empty),"},{"line_number":163,"context_line":"                            attrs\u003d{\u0027data-type\u0027: \u0027timesince\u0027})"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_5fb05df4","line":160,"updated":"2014-05-22 05:29:16.000000000","message":"seems empty_value is unneeded, filter below  deal with it.","commit_id":"02437a6f413a18b3171857a31aa63bfe5279591e"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"7b4065367fc2f04fce60550834007b504e99873b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    created \u003d tables.Column(api.nova.Server."},{"line_number":158,"context_line":"                            get_available_instance_created_time,"},{"line_number":159,"context_line":"                            verbose_name\u003d_(\"Uptime\"),"},{"line_number":160,"context_line":"                            empty_value\u003d\"-\","},{"line_number":161,"context_line":"                            filters\u003d(filters.parse_isotime,"},{"line_number":162,"context_line":"                                     filters.timesince_or_empty),"},{"line_number":163,"context_line":"                            attrs\u003d{\u0027data-type\u0027: \u0027timesince\u0027})"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_5c95c086","line":160,"in_reply_to":"7adec928_5fb05df4","updated":"2014-05-22 12:59:49.000000000","message":"Done","commit_id":"02437a6f413a18b3171857a31aa63bfe5279591e"}]}
