)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cbd990a86e6f682dbd21faad9e7802749dbafe9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8bf76296_198eb244","updated":"2024-12-13 08:25:28.000000000","message":"recheck failures might have been unrelated and fixed by now?","commit_id":"f363ed6ea296ad462e2404814e4c97535341f960"}],"openstack_auth/tests/unit/test_auth.py":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"5720c3659a159224fa95ed6c23a28d99ee9fce03","unresolved":true,"context_lines":[{"line_number":1437,"context_line":"        mock_get_access.assert_called_once_with(IsA(session.Session))"},{"line_number":1438,"context_line":"        mock_get_access_token.assert_called_with(IsA(session.Session))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def test_switch_system_scope_with_next(self, next\u003dNone):"},{"line_number":1441,"context_line":"        self.test_switch_region(next\u003d\u0027/next_url\u0027)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""},{"line_number":1444,"context_line":"class OpenStackAuthTestsPublicURL(OpenStackAuthTests):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b8265800_ff1a9857","line":1441,"range":{"start_line":1440,"start_character":0,"end_line":1441,"end_character":49},"updated":"2024-12-03 13:15:02.000000000","message":"This test is the same (functionality) as the test on the line 1382, just the name of the test is different.\nI guess here should be: self.test_switch_system_scope(next\u003d\u0027/next_url\u0027) ?","commit_id":"34a5293058595b0d76f239d833ac5dd88cde133e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"24c1331d17d79c9e48d080b50278dbe4b0c22ede","unresolved":false,"context_lines":[{"line_number":1437,"context_line":"        mock_get_access.assert_called_once_with(IsA(session.Session))"},{"line_number":1438,"context_line":"        mock_get_access_token.assert_called_with(IsA(session.Session))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def test_switch_system_scope_with_next(self, next\u003dNone):"},{"line_number":1441,"context_line":"        self.test_switch_region(next\u003d\u0027/next_url\u0027)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""},{"line_number":1444,"context_line":"class OpenStackAuthTestsPublicURL(OpenStackAuthTests):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4fd41931_2d4c7aa2","line":1441,"range":{"start_line":1440,"start_character":0,"end_line":1441,"end_character":49},"in_reply_to":"b8265800_ff1a9857","updated":"2024-12-03 15:42:00.000000000","message":"Done","commit_id":"34a5293058595b0d76f239d833ac5dd88cde133e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"188b35a7804a4778bd5440aa20a4ad74bf2aa737","unresolved":true,"context_lines":[{"line_number":1437,"context_line":"        mock_get_access.assert_called_once_with(IsA(session.Session))"},{"line_number":1438,"context_line":"        mock_get_access_token.assert_called_with(IsA(session.Session))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def test_switch_system_scope_with_next(self, next\u003dNone):"},{"line_number":1441,"context_line":"        self.test_switch_system_scope(next\u003d\u0027/next_url\u0027)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6d4537ed_80757d7c","line":1440,"updated":"2024-12-09 09:49:16.000000000","message":"I think this `next\u003dNone` is not necessary here. It doesn\u0027t seem to be used.","commit_id":"f363ed6ea296ad462e2404814e4c97535341f960"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"0da337c14cfad943f78f9f0322cf0c5499d64ad1","unresolved":false,"context_lines":[{"line_number":1437,"context_line":"        mock_get_access.assert_called_once_with(IsA(session.Session))"},{"line_number":1438,"context_line":"        mock_get_access_token.assert_called_with(IsA(session.Session))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def test_switch_system_scope_with_next(self, next\u003dNone):"},{"line_number":1441,"context_line":"        self.test_switch_system_scope(next\u003d\u0027/next_url\u0027)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cb6137b4_1efc4daf","line":1440,"in_reply_to":"0ef0684f_b5a53cc4","updated":"2024-12-18 08:10:33.000000000","message":"I\u0027m sorry, I meant no offense, thank you for your work on this.","commit_id":"f363ed6ea296ad462e2404814e4c97535341f960"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7df0fb7f12d0f34dacfe70804e99ad891f68fc2d","unresolved":true,"context_lines":[{"line_number":1437,"context_line":"        mock_get_access.assert_called_once_with(IsA(session.Session))"},{"line_number":1438,"context_line":"        mock_get_access_token.assert_called_with(IsA(session.Session))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def test_switch_system_scope_with_next(self, next\u003dNone):"},{"line_number":1441,"context_line":"        self.test_switch_system_scope(next\u003d\u0027/next_url\u0027)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7c35b542_406a3cb4","line":1440,"in_reply_to":"6d4537ed_80757d7c","updated":"2024-12-16 16:01:33.000000000","message":"I think it is. I just copied this from `test_switch_region_with_next` above.","commit_id":"f363ed6ea296ad462e2404814e4c97535341f960"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"33467a705ac6d3c8107295472f7cd0a3f0b9b94b","unresolved":true,"context_lines":[{"line_number":1437,"context_line":"        mock_get_access.assert_called_once_with(IsA(session.Session))"},{"line_number":1438,"context_line":"        mock_get_access_token.assert_called_with(IsA(session.Session))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def test_switch_system_scope_with_next(self, next\u003dNone):"},{"line_number":1441,"context_line":"        self.test_switch_system_scope(next\u003d\u0027/next_url\u0027)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f63879f5_0a8468e6","line":1440,"in_reply_to":"7c35b542_406a3cb4","updated":"2024-12-16 17:06:18.000000000","message":"yeah, it\u0027s not needed there either, please don\u0027t copy things mindlessly","commit_id":"f363ed6ea296ad462e2404814e4c97535341f960"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b51cd81c6282a30c7f7587e308da08572c307022","unresolved":false,"context_lines":[{"line_number":1437,"context_line":"        mock_get_access.assert_called_once_with(IsA(session.Session))"},{"line_number":1438,"context_line":"        mock_get_access_token.assert_called_with(IsA(session.Session))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def test_switch_system_scope_with_next(self, next\u003dNone):"},{"line_number":1441,"context_line":"        self.test_switch_system_scope(next\u003d\u0027/next_url\u0027)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"97552d6f_6168c7d2","line":1440,"in_reply_to":"cb6137b4_1efc4daf","updated":"2024-12-18 13:42:37.000000000","message":"It\u0027s all good 👌","commit_id":"f363ed6ea296ad462e2404814e4c97535341f960"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1be5b8c2f3733c4b0f16285b2c8f7d70d0855e10","unresolved":false,"context_lines":[{"line_number":1437,"context_line":"        mock_get_access.assert_called_once_with(IsA(session.Session))"},{"line_number":1438,"context_line":"        mock_get_access_token.assert_called_with(IsA(session.Session))"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def test_switch_system_scope_with_next(self, next\u003dNone):"},{"line_number":1441,"context_line":"        self.test_switch_system_scope(next\u003d\u0027/next_url\u0027)"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0ef0684f_b5a53cc4","line":1440,"in_reply_to":"f63879f5_0a8468e6","updated":"2024-12-17 21:56:10.000000000","message":"Done. Also, maybe don\u0027t use \"mindlessly\": I\u0027m being plenty mindful and, IMO, have already gone above and beyond here by not only reporting the issue but also proposing a fix with a very substantial commit message explaining the problem *and* the addition of missing test coverage. A mindless person would simply have let the keystoneauth bump merge - there\u0027s nothing wrong there - leaving the Horizon gate in a broken state.","commit_id":"f363ed6ea296ad462e2404814e4c97535341f960"}]}