)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"4b9855355ff84f9d2f2955dc35d679cf841dc79d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c869b82a_28862880","updated":"2024-11-30 03:11:08.000000000","message":"recheck","commit_id":"f5b141f392cd25727dff9668c0fee06556cfce84"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"785d3c82999d9a1a243fcac3f149892086db6c7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f7b1917f_58e4b1e9","updated":"2024-12-06 00:40:06.000000000","message":"recheck","commit_id":"f5b141f392cd25727dff9668c0fee06556cfce84"}],"openstack_dashboard/test/integration_tests/config.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"33ef26c5f4cfb6914765e528d1f5d865632ce9aa","unresolved":true,"context_lines":[{"line_number":226,"context_line":"                         \u0027Compute\u0027, \u0027Compute\u0027, \u0027Compute\u0027, \u0027Compute\u0027, \u0027Compute\u0027,"},{"line_number":227,"context_line":"                         \u0027Volume\u0027, \u0027Volume\u0027, \u0027Volume\u0027, \u0027Volume\u0027, \u0027Network\u0027,"},{"line_number":228,"context_line":"                         \u0027Network\u0027, \u0027Network\u0027, \u0027Network\u0027, \u0027Network\u0027, \u0027Admin\u0027,"},{"line_number":229,"context_line":"                         \u0027Admin\u0027, \u0027Admin\u0027, None, None, None, None, None],"},{"line_number":230,"context_line":"                help\u003d\u0027Secondary buttons for left browse panel\u0027),"},{"line_number":231,"context_line":"    cfg.StrOpt(\u0027b_l_p_sec_line_xpath\u0027,"},{"line_number":232,"context_line":"               default\u003d\u0027.//*[@id\u003d\"sidebar-accordion-{main_panel}\"]\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a21facf0_d108652d","line":229,"updated":"2024-12-18 12:30:43.000000000","message":"Do you want to replace the None here with \"None\" too?","commit_id":"f5f073a3385ee33060c547013a6b6b2ef6c6d7c3"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"23b7c02bce32e1b9139e7fd068d9dd14635f02ff","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                         \u0027Compute\u0027, \u0027Compute\u0027, \u0027Compute\u0027, \u0027Compute\u0027, \u0027Compute\u0027,"},{"line_number":227,"context_line":"                         \u0027Volume\u0027, \u0027Volume\u0027, \u0027Volume\u0027, \u0027Volume\u0027, \u0027Network\u0027,"},{"line_number":228,"context_line":"                         \u0027Network\u0027, \u0027Network\u0027, \u0027Network\u0027, \u0027Network\u0027, \u0027Admin\u0027,"},{"line_number":229,"context_line":"                         \u0027Admin\u0027, \u0027Admin\u0027, None, None, None, None, None],"},{"line_number":230,"context_line":"                help\u003d\u0027Secondary buttons for left browse panel\u0027),"},{"line_number":231,"context_line":"    cfg.StrOpt(\u0027b_l_p_sec_line_xpath\u0027,"},{"line_number":232,"context_line":"               default\u003d\u0027.//*[@id\u003d\"sidebar-accordion-{main_panel}\"]\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ed7dbfd6_87e2b952","line":229,"in_reply_to":"a21facf0_d108652d","updated":"2024-12-18 20:37:33.000000000","message":"Done","commit_id":"f5f073a3385ee33060c547013a6b6b2ef6c6d7c3"}],"openstack_dashboard/test/selenium/ui/test_browse.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"1d0c48c2a45f97452c2db794a0ac775c4191a3ad","unresolved":true,"context_lines":[{"line_number":151,"context_line":"            f\".//a[normalize-space()\u003d\u0027{main_panel.capitalize()}\u0027]\").click()"},{"line_number":152,"context_line":"        if sec_panel !\u003d \u0027None\u0027:"},{"line_number":153,"context_line":"            sec_line_req_button \u003d config.theme.b_l_p_sec_line_req_btn.replace("},{"line_number":154,"context_line":"                \"main_panel\", main_panel)"},{"line_number":155,"context_line":"            sec_line_req_button \u003d sec_line_req_button.replace("},{"line_number":156,"context_line":"                \"sec_panel\", sec_panel)"},{"line_number":157,"context_line":"            # Second scroll click"}],"source_content_type":"text/x-python","patch_set":4,"id":"147c365a_7234fe8a","line":154,"updated":"2024-12-16 12:22:56.000000000","message":"How about making this replace(\"{main_panel}\", main_panel) and updating the values accordingly, to make it obvious that those are template variables, and also to avoid accidentally replacing too much?","commit_id":"06f554a8a2e40215ba6e436918ad722f1efaea48"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"23b7c02bce32e1b9139e7fd068d9dd14635f02ff","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            f\".//a[normalize-space()\u003d\u0027{main_panel.capitalize()}\u0027]\").click()"},{"line_number":152,"context_line":"        if sec_panel !\u003d \u0027None\u0027:"},{"line_number":153,"context_line":"            sec_line_req_button \u003d config.theme.b_l_p_sec_line_req_btn.replace("},{"line_number":154,"context_line":"                \"main_panel\", main_panel)"},{"line_number":155,"context_line":"            sec_line_req_button \u003d sec_line_req_button.replace("},{"line_number":156,"context_line":"                \"sec_panel\", sec_panel)"},{"line_number":157,"context_line":"            # Second scroll click"}],"source_content_type":"text/x-python","patch_set":4,"id":"037c6f60_fadcfdd2","line":154,"in_reply_to":"147c365a_7234fe8a","updated":"2024-12-18 20:37:33.000000000","message":"Done","commit_id":"06f554a8a2e40215ba6e436918ad722f1efaea48"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"85d716defe5f1cd3d78508830fb7ac7ee0a2bb24","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        # First scroll click"},{"line_number":150,"context_line":"        driver.find_element_by_xpath("},{"line_number":151,"context_line":"            f\".//a[normalize-space()\u003d\u0027{main_panel.capitalize()}\u0027]\").click()"},{"line_number":152,"context_line":"        if sec_panel !\u003d \u0027None\u0027:"},{"line_number":153,"context_line":"            sec_line_req_button \u003d config.theme.b_l_p_sec_line_req_btn.format("},{"line_number":154,"context_line":"                main_panel\u003dmain_panel, sec_panel\u003dsec_panel)"},{"line_number":155,"context_line":"            # Second scroll click"}],"source_content_type":"text/x-python","patch_set":6,"id":"d670b8ff_2849d1f0","line":152,"updated":"2024-12-18 12:28:16.000000000","message":"Now that you are using strings in here, I wonder if an empty string \"\" would make more sense for \"no panel\" than \"None\"?","commit_id":"f5f073a3385ee33060c547013a6b6b2ef6c6d7c3"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"23b7c02bce32e1b9139e7fd068d9dd14635f02ff","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        # First scroll click"},{"line_number":150,"context_line":"        driver.find_element_by_xpath("},{"line_number":151,"context_line":"            f\".//a[normalize-space()\u003d\u0027{main_panel.capitalize()}\u0027]\").click()"},{"line_number":152,"context_line":"        if sec_panel !\u003d \u0027None\u0027:"},{"line_number":153,"context_line":"            sec_line_req_button \u003d config.theme.b_l_p_sec_line_req_btn.format("},{"line_number":154,"context_line":"                main_panel\u003dmain_panel, sec_panel\u003dsec_panel)"},{"line_number":155,"context_line":"            # Second scroll click"}],"source_content_type":"text/x-python","patch_set":6,"id":"c329b546_009f846d","line":152,"in_reply_to":"d670b8ff_2849d1f0","updated":"2024-12-18 20:37:33.000000000","message":"I prefer to use \"None\". It looks more clear to me on the first sight and it is not so easy to overlook it in horizon.conf as empty string \"\".","commit_id":"f5f073a3385ee33060c547013a6b6b2ef6c6d7c3"}]}