)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"512a803f71e79a1c839dd85e9bc7f64f2ad3747b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9027a864_e58928ef","updated":"2024-12-17 15:16:26.000000000","message":"Thanks.\n\nNice work, by the way :-)","commit_id":"123873cbdb49c116d4c6def607ab124abdc416de"}],"tox.ini":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"08074fdced5bacef6e5cdcfdd957953b6624bced","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"},{"line_number":35,"context_line":"allowlist_externals \u003d reno"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[testenv:pep8]"},{"line_number":38,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"01b52934_7f1678fb","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":26},"updated":"2024-12-16 15:02:14.000000000","message":"This looks strange to me. The reno command is installed in to the target venv by doc/requirements, and allowlist_externals should not be needed for the command explicitly installed into the venv. I wonder if there is any failure log where I can check the problem ?","commit_id":"80a210dd433c82eb1ce3cb3599868ec21ad5a79f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"0b1886f2a929e2a03c2b43364b54f34fca91a62b","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"},{"line_number":35,"context_line":"allowlist_externals \u003d reno"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[testenv:pep8]"},{"line_number":38,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7a132538_370f35a2","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":26},"in_reply_to":"01b52934_7f1678fb","updated":"2024-12-17 10:49:15.000000000","message":"If I try to run the command that is provided in the documentation without this in tox.ini, I get:\n\n~/dev/horizon(master)\u003e tox -e venv -- reno --help\nvenv: install_deps\u003e python -I -m pip install \u0027hacking\u003c3.1.0,\u003e\u003d3.0.1\u0027 -r /home/rdopiera/dev/horizon/test-requirements.txt -r /home/rdopiera/dev/horizon/requirements.txt -c https://releases.openstack.org/constraints/upper/master\n.pkg: _optional_hooks\u003e python /usr/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__\n.pkg: get_requires_for_build_editable\u003e python /usr/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__\n.pkg: build_editable\u003e python /usr/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__\nvenv: install_package_deps\u003e python -I -m pip install \u0027Babel\u003e\u003d2.6.0\u0027 \u0027Django\u003c4.3,\u003e\u003d4.2\u0027 \u0027PyYAML\u003e\u003d6.0\u0027 \u0027XStatic-Angular-Bootstrap\u003e\u003d2.2.0.0\u0027 \u0027XStatic-Angular-FileUpload\u003e\u003d12.0.4.0\u0027 \u0027XStatic-Angular-Gettext\u003e\u003d2.3.8.0\u0027 \u0027XStatic-Angular-Schema-Form\u003e\u003d0.8.13.0\u0027 \u0027XStatic-Angular-lrdragndrop\u003e\u003d1.0.2.2\u0027 \u0027XStatic-Angular\u003e\u003d1.8.2.2\u0027 \u0027XStatic-Bootstrap-Datepicker\u003e\u003d1.3.1.0\u0027 \u0027XStatic-Bootstrap-SCSS\u003e\u003d3.3.7.1\u0027 \u0027XStatic-D3\u003e\u003d3.5.17.0\u0027 \u0027XStatic-Font-Awesome\u003e\u003d4.7.0.0\u0027 \u0027XStatic-Hogan\u003e\u003d2.0.0.2\u0027 \u0027XStatic-JQuery-Migrate\u003e\u003d3\u0027 \u0027XStatic-JQuery.TableSorter\u003e\u003d2.14.5.1\u0027 \u0027XStatic-JQuery.quicksearch\u003e\u003d2.0.3.2\u0027 \u0027XStatic-JSEncrypt\u003e\u003d2.3.1.1\u0027 \u0027XStatic-Jasmine\u003e\u003d2.4.1.1\u0027 \u0027XStatic-Rickshaw\u003e\u003d1.5.0.0\u0027 \u0027XStatic-Spin\u003e\u003d1.2.5.2\u0027 \u0027XStatic-bootswatch\u003e\u003d3.3.7.0\u0027 \u0027XStatic-jQuery\u003e\u003d3.5.1.1\u0027 \u0027XStatic-jquery-ui\u003e\u003d1.13.0.1\u0027 \u0027XStatic-mdi\u003e\u003d1.6.50.2\u0027 \u0027XStatic-objectpath\u003e\u003d1.2.1.0\u0027 \u0027XStatic-roboto-fontface\u003e\u003d0.5.0.0\u0027 \u0027XStatic-smart-table\u003e\u003d1.4.13.2\u0027 \u0027XStatic-term.js\u003e\u003d0.0.7.0\u0027 \u0027XStatic-tv4\u003e\u003d1.2.7.0\u0027 \u0027XStatic\u003e\u003d1.0.3\u0027 \u0027django-compressor\u003e\u003d4.4\u0027 \u0027django-debreach\u003e\u003d1.4.2\u0027 \u0027enmerkar\u003e\u003d0.7.1\u0027 \u0027futurist\u003e\u003d1.2.0\u0027 \u0027iso8601\u003e\u003d0.1.11\u0027 \u0027keystoneauth1\u003e\u003d4.3.1\u0027 \u0027libsass\u003e\u003d0.23.0\u0027 \u0027netaddr\u003e\u003d0.7.18\u0027 \u0027oslo.concurrency\u003e\u003d4.5.0\u0027 \u0027oslo.config\u003e\u003d8.8.0\u0027 \u0027oslo.i18n\u003e\u003d5.1.0\u0027 \u0027oslo.policy\u003e\u003d3.11.0\u0027 \u0027oslo.serialization\u003e\u003d4.3.0\u0027 \u0027oslo.upgradecheck\u003e\u003d1.5.0\u0027 \u0027oslo.utils\u003e\u003d7.0.0\u0027 \u0027osprofiler\u003e\u003d3.4.2\u0027 \u0027pbr\u003e\u003d5.5.0\u0027 \u0027python-cinderclient\u003e\u003d8.0.0\u0027 \u0027python-glanceclient\u003e\u003d2.8.0\u0027 \u0027python-keystoneclient\u003e\u003d3.22.0\u0027 \u0027python-neutronclient\u003e\u003d8.1.0\u0027 \u0027python-novaclient\u003e\u003d9.1.0\u0027 \u0027python-swiftclient\u003e\u003d3.2.0\u0027 \u0027requests\u003e\u003d2.25.1\u0027 \u0027semantic-version\u003e\u003d2.3.1\u0027 \u0027tzdata\u003e\u003d2022.4\u0027\nvenv: install_package\u003e python -I -m pip install --force-reinstall --no-deps /home/rdopiera/dev/horizon/.tox/.tmp/package/81/horizon-25.2.0.dev35-0.editable-py3-none-any.whl\nvenv: commands[0]\u003e reno --help\nvenv: failed with reno is not allowed, use allowlist_externals to allow it\n  venv: FAIL code 1 (26.99 seconds)\n  evaluation failed :( (27.07 seconds)","commit_id":"80a210dd433c82eb1ce3cb3599868ec21ad5a79f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7b1f1266bd8290a3d3337fdd8e42555b4dff8714","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"},{"line_number":35,"context_line":"allowlist_externals \u003d reno"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[testenv:pep8]"},{"line_number":38,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"aa2a96d3_ba25c5bc","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":26},"in_reply_to":"43624f9a_56c1a6bc","updated":"2024-12-17 14:08:44.000000000","message":"Or if you intend to use the target to generate the sample reno file I think the better approach is to create a dedicated tox target, which installs reno. Otherwise it does not make much sense to use the tox target because reno tool is loaded from system path.","commit_id":"80a210dd433c82eb1ce3cb3599868ec21ad5a79f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"b4d898ac896e834b76f527d3939eb4c9c5c4c8b1","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"},{"line_number":35,"context_line":"allowlist_externals \u003d reno"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[testenv:pep8]"},{"line_number":38,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"e1d8ab05_00b211d9","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":26},"in_reply_to":"6fd2a299_5350ff43","updated":"2024-12-17 14:54:15.000000000","message":"You are right, that sounds like a better solution. I removed the tox.ini change.","commit_id":"80a210dd433c82eb1ce3cb3599868ec21ad5a79f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dff14e3aac61d2a4b9e0e11631f0ea2fc6b9a2da","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"},{"line_number":35,"context_line":"allowlist_externals \u003d reno"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[testenv:pep8]"},{"line_number":38,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"89bffe81_6f53c3e0","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":26},"in_reply_to":"7a132538_370f35a2","updated":"2024-12-17 14:05:37.000000000","message":"Ah, ok. Thanks for the info. I now understand the issue.\n\nI think the better way to build release notes nowadays is using `tox -e reno`. I can fix the documentation if you can share its pointer. (and this target is actually used in CI to build release notes)","commit_id":"80a210dd433c82eb1ce3cb3599868ec21ad5a79f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f7198fbef246d2ba568447bed18a75699e133f5d","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"},{"line_number":35,"context_line":"allowlist_externals \u003d reno"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[testenv:pep8]"},{"line_number":38,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"43624f9a_56c1a6bc","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":26},"in_reply_to":"89bffe81_6f53c3e0","updated":"2024-12-17 14:06:36.000000000","message":"Correction: Use `tox -e releasenotes` instead of `tox -e reno`.","commit_id":"80a210dd433c82eb1ce3cb3599868ec21ad5a79f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"32cb8b042cdafc4603bf47823e2915efe1f041ae","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"},{"line_number":35,"context_line":"allowlist_externals \u003d reno"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[testenv:pep8]"},{"line_number":38,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"6fd2a299_5350ff43","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":26},"in_reply_to":"aa2a96d3_ba25c5bc","updated":"2024-12-17 14:13:09.000000000","message":"See https://review.opendev.org/c/openstack/horizon/+/937877","commit_id":"80a210dd433c82eb1ce3cb3599868ec21ad5a79f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4be43ea9775d2a48a0e84cfce1f018a99443a08e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[testenv:venv]"},{"line_number":34,"context_line":"commands \u003d {posargs}"},{"line_number":35,"context_line":"allowlist_externals \u003d reno"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[testenv:pep8]"},{"line_number":38,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"faff441b_c137daaa","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":26},"in_reply_to":"e1d8ab05_00b211d9","updated":"2024-12-17 15:16:35.000000000","message":"Done","commit_id":"80a210dd433c82eb1ce3cb3599868ec21ad5a79f"}]}