)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"f4445fb01aa60390e1a307cd6b2907f5f6d4278b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"058de2ed_dc2d73ed","updated":"2025-04-30 14:45:28.000000000","message":"LGTM, thank you!","commit_id":"b4ca0fd9c0891661b8f006e9955b95e84295fedb"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"b7b9aaeeed1226eddb2720a04ed3ce1dec81edfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"768d3532_ddbca5b2","in_reply_to":"058de2ed_dc2d73ed","updated":"2025-04-30 15:45:16.000000000","message":"@jjasek@redhat.com\nThanks for assistance.\nCould you please look one more time, there were problems with indentation:)","commit_id":"b4ca0fd9c0891661b8f006e9955b95e84295fedb"}],"openstack_dashboard/dashboards/project/security_groups/forms.py":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"f033bcc633442cc5fd1569391297c84f20d1948a","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    ip_protocol \u003d forms.IntegerField("},{"line_number":129,"context_line":"        label\u003d_(\u0027IP Protocol\u0027), required\u003dTrue,"},{"line_number":130,"context_line":"        help_text\u003d_(\"Enter an integer value between 0 and 255.\"),"},{"line_number":131,"context_line":"        validators\u003d[utils_validators.validate_ip_protocol],"},{"line_number":132,"context_line":"        widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":133,"context_line":"            \u0027class\u0027: \u0027switched\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"2758f1eb_c90a454c","line":130,"range":{"start_line":130,"start_character":8,"end_line":130,"end_character":64},"updated":"2025-04-30 10:36:35.000000000","message":"Hi @dcu995@gmail.com,\nI know it is not part of your current change, but it would be nice if you can check it.\nMaybe I am missing something but here is defined for IP Protocol:\nhelp_text\u003d_(\"Enter an integer value between 0 and 255.\")\nBut when I hover over the tooltip “?” for IP Protocol then I can see there:\nEnter an integer value between -1 and 255 (-1 means wild card). Which is defined in self.fields[‘ip_protocol’].help_text. (line 286)\n\nBased on the documentation, the [0-255] should be the correct one.\nCould you please check it or correct me if I am wrong?","commit_id":"a7b6df0ec639e2625abe592b351a6fe5ae7cf03d"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"f164bd20fe4670c92eae6a744e73f38bf095e0b8","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    ip_protocol \u003d forms.IntegerField("},{"line_number":129,"context_line":"        label\u003d_(\u0027IP Protocol\u0027), required\u003dTrue,"},{"line_number":130,"context_line":"        help_text\u003d_(\"Enter an integer value between 0 and 255.\"),"},{"line_number":131,"context_line":"        validators\u003d[utils_validators.validate_ip_protocol],"},{"line_number":132,"context_line":"        widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":133,"context_line":"            \u0027class\u0027: \u0027switched\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a649921_cda0c68a","line":130,"range":{"start_line":130,"start_character":8,"end_line":130,"end_character":64},"in_reply_to":"2758f1eb_c90a454c","updated":"2025-04-30 11:51:21.000000000","message":"@jjasek@redhat.com Hi, thanks for reply.\nIndeed, according to IANA (https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml) protocol numbers begin from 0. But in our case, as I correctly understand, -1 means any protocol, I\u0027m not sure that this is quite necessary, but if that filed can correctly process this value, I think we should leave as it is.","commit_id":"a7b6df0ec639e2625abe592b351a6fe5ae7cf03d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"b8d1c98f68ebfe5fba8341446b6d1dd4434633cb","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    ip_protocol \u003d forms.IntegerField("},{"line_number":129,"context_line":"        label\u003d_(\u0027IP Protocol\u0027), required\u003dTrue,"},{"line_number":130,"context_line":"        help_text\u003d_(\"Enter an integer value between 0 and 255.\"),"},{"line_number":131,"context_line":"        validators\u003d[utils_validators.validate_ip_protocol],"},{"line_number":132,"context_line":"        widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":133,"context_line":"            \u0027class\u0027: \u0027switched\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5861351d_e04594f7","line":130,"range":{"start_line":130,"start_character":8,"end_line":130,"end_character":64},"in_reply_to":"3a649921_cda0c68a","updated":"2025-04-30 12:42:38.000000000","message":"I was checking it also in API ref and there is not mentioned -1 at all:\nhttps://docs.openstack.org/api-ref/network/v2/index.html#security-group-rules-security-group-rules\nBut \"field can correctly process this value\" is definitely valid point.\nThen I am not very sure when/where should this help_text from line 130 appear?\nBecause in mine UI the help tooltip \"?\" for IP protocol is showing help_text from line 287.\n\nI do not want to bother you with that :D but during the review I noticed that there are two help_text for ip_protocol. So I am trying to understand why there are two different helps defined.\nBecause If I am right the _ _ init _ _ will rewrite the help_text (from line 130) every time so then the help_text on line 130 is useless.\n\nI am trying to find if there is some reason why it is implemented like that and why the help texts are different. But from my point of view lines 286-289 should be removed completely and line 130 should be then changed to:\n\"Enter an integer value between -1 and 255 (-1 means wild card).\"\n\nAm I missing something? I hope it make sense how I explained it.","commit_id":"a7b6df0ec639e2625abe592b351a6fe5ae7cf03d"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"7495228235cd460430d77acaf52a95127eca8270","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    ip_protocol \u003d forms.IntegerField("},{"line_number":129,"context_line":"        label\u003d_(\u0027IP Protocol\u0027), required\u003dTrue,"},{"line_number":130,"context_line":"        help_text\u003d_(\"Enter an integer value between 0 and 255.\"),"},{"line_number":131,"context_line":"        validators\u003d[utils_validators.validate_ip_protocol],"},{"line_number":132,"context_line":"        widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":133,"context_line":"            \u0027class\u0027: \u0027switched\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"a2df7fd5_b31171ba","line":130,"range":{"start_line":130,"start_character":8,"end_line":130,"end_character":64},"in_reply_to":"5861351d_e04594f7","updated":"2025-04-30 14:11:04.000000000","message":"@jjasek@redhat.com To be honest, I\u0027ve also couldn\u0027t find out where does this help text appear, after removing it nothing changes. So you\u0027re right it\u0027s better to completely remove it from code not to confuse people.","commit_id":"a7b6df0ec639e2625abe592b351a6fe5ae7cf03d"}]}