)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"be048d902248eec8afe429ef25d3e37446a39a10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0fbc237d_e3b009d6","updated":"2025-04-30 22:44:45.000000000","message":"@jjasek@redhat.com hello, we staring review this MR in:\n\nhttps://review.opendev.org/c/openstack/horizon/+/651700","commit_id":"3d0c750750970acd291f44eb8d427a930a52fa5a"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"06b8a2f8ed50f08d824c68e6caea002df55195cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"447d85b2_ad7ee885","updated":"2025-05-04 16:25:08.000000000","message":"recheck","commit_id":"3d0c750750970acd291f44eb8d427a930a52fa5a"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"c4fa8c4717ffe2f4f028efe8bfbe42e729e8eca5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"83271857_3399aa74","in_reply_to":"0fbc237d_e3b009d6","updated":"2025-05-05 12:14:14.000000000","message":"Hello @lazekteam@gmail.com, why do we not continue with the previous Patch where we started the review? If there is a reason for switching to a new patch, can we please describe in the previous one why is it and abandon it? To make clear which one is up to date and should be reviewed.","commit_id":"3d0c750750970acd291f44eb8d427a930a52fa5a"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"3b51680a35da43ded083637cd70231c2ec6d1571","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4b14b068_b3e849c7","in_reply_to":"83271857_3399aa74","updated":"2025-05-05 12:27:21.000000000","message":"@jjasek@redhat.com Hi! As I can see previous change has \"WIP\" status and from it\u0027s owner was no activity for couple of years, and I was not able to mark it as active.\nSo it would be good to make it whether abandoned or may be active (and I\u0027ll abandone the current one).","commit_id":"3d0c750750970acd291f44eb8d427a930a52fa5a"}],"releasenotes/notes/convert-to-lowercase.yaml":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"c7be2cedb1df1d467b440734e7ec6b2dde95bb47","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Flavor IDs are now automatically converted to lowercase"},{"line_number":4,"context_line":"    when creating a new flavor."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1c4114d1_8d4b3480","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":31},"updated":"2025-05-05 13:08:06.000000000","message":"This release note seems to be a little confusing for me.\nIf I understand it correctly then the Flavors IDs are not automatically converted to lowercase when creating a new flavor, but there is a checking between .lowercase existing flavors and .lowercase new flavor that should be created.\n\nBut when I open Flavors in UI or CLI then the IDs there still contains uppercase and also lowercase in IDs. So the IDs are not automatically converted to lowercase when creating I guess. Or am I missing something?","commit_id":"3d0c750750970acd291f44eb8d427a930a52fa5a"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"bc7c9e00eb95f4e3adaf0d4c88d7b6cfa6c10648","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Flavor IDs are now automatically converted to lowercase"},{"line_number":4,"context_line":"    when creating a new flavor."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"91c91243_d3617f51","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":31},"in_reply_to":"1c4114d1_8d4b3480","updated":"2025-05-05 17:12:11.000000000","message":"@jjasek@redhat.com Thank for reply, seems you are right. I\u0027ve wrongly supposed that this patch was working according to previous change code reviews. Don\u0027t you remember was it working earlier, or you\u0027ve just checked it now?","commit_id":"3d0c750750970acd291f44eb8d427a930a52fa5a"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"7d9be634102ac95cf68d22ac65c2a593cd8e3566","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Flavor IDs are now automatically converted to lowercase"},{"line_number":4,"context_line":"    when creating a new flavor."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d75a5958_b6008dfb","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":31},"in_reply_to":"91c91243_d3617f51","updated":"2025-05-06 07:22:48.000000000","message":"My problem is not with the fix itself. When you try to create Flavor with ID for example \"Flavor1\" and then with ID \"flavor1\" then you realize the fix seems to work well. At least from my point of view. (You are no longer able to send the form with existing ID, you get warning during form creating, not after sending).\n\nI have a problem with the release notes that says the patch is doing something very different from what it really does. Because the patch does not convert ID automatically to lowercase, this patch converts IDs to lowercase only during checking if there is already an existing Flavor with the same ID, because IDs are not case sensitive.\n\nI am not even sure if it is needed to have a release notes for bugfix like that. From my point it is not a feature, it is just a correctly implemented prevention from user send invalid data to server, on the correct level (filling the form).","commit_id":"3d0c750750970acd291f44eb8d427a930a52fa5a"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"12c79c87bd7ccf4c8387c9f2721ff43b9794b71f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Flavor IDs are now automatically converted to lowercase"},{"line_number":4,"context_line":"    when creating a new flavor."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7030594d_50497706","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":31},"in_reply_to":"d75a5958_b6008dfb","updated":"2025-05-06 08:31:47.000000000","message":"@jjasek@redhat.com Thanks for help, probably initally i\u0027ve misunderstood behaviour of this patch. I\u0027d agree that it\u0027s not worth of separate release note, so I\u0027ll leave it as it is.","commit_id":"3d0c750750970acd291f44eb8d427a930a52fa5a"}]}