)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a26c7ff090a3e45b570aee1ec061d46a4cce7454","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove spaces from notifications phrases "},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At the moment, these phrases get into Zanata, and in many translations there are simply no spaces, which spoils the readability of notifications, we need to fix this from the code side"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0ba713fb0e22989192e8af83930ea05a62b80551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"0eacc5f2_3833e166","line":9,"updated":"2025-06-04 08:45:08.000000000","message":"well yes and no.\ntechnially the translation were invlaid and it should have been caught in there\nreview.\n\nwe can fix this pretty trivilly in the code side btu we now need to also consider that some translation would have a space and also because we are changing the gettext key all existing translation will now break and need to be updated in Zanata\n\n-1 because if we do this then you should have a bug for this.\n\nalso please reflow this commit message to limit to 72-79 columns\nand adress the white space issue\n\nopenstack general expcations of howe git commit message should be\nwritten is docuemnted here\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages\n\nalso going forward openstack is adopting the DCO standard\nso in future you will need to add Signed-of-by\n\nyou can do this with \"git commit --amend -s\"\n\nthe -s will add the signed off by line for and you can then fix the commit wrapping manually.\n\nthis will be required starting july 1st.","commit_id":"5415fa7bf1509757c7361255324a3dbb78c4064d"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"9f3487f78910a0c9b4014e0eb40b80ebe6152a43","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove spaces from notifications phrases "},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At the moment, these phrases get into Zanata, and in many translations there are simply no spaces, which spoils the readability of notifications, we need to fix this from the code side"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0ba713fb0e22989192e8af83930ea05a62b80551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1fb59678_54617dc3","line":9,"in_reply_to":"0eacc5f2_3833e166","updated":"2025-06-04 08:51:12.000000000","message":"Thank you, this affected only for 6 phrase, this not urgent, considering that in half of the languages ​​I checked, this space is not present and the text is displayed as one continuous line.","commit_id":"5415fa7bf1509757c7361255324a3dbb78c4064d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0676819d9d08277d4a2793d4c008459479d1745b","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At the moment, these phrases get into Zanata, and in many translations there are simply no spaces, which spoils the readability of notifications, we need to fix this from the code side"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-authored-by: Sean Mooney \u003csmooney@redhat.com\u003e"},{"line_number":12,"context_line":"Change-Id: I0ba713fb0e22989192e8af83930ea05a62b80551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"922f3108_9baaa6af","line":11,"updated":"2025-06-04 08:46:09.000000000","message":"it should not have my co-authored-by either.\n\nthat shoudl only be added by me if i modified your patch.","commit_id":"44890cee2e825531331bbcc85ec60521548d5310"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"9f3487f78910a0c9b4014e0eb40b80ebe6152a43","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At the moment, these phrases get into Zanata, and in many translations there are simply no spaces, which spoils the readability of notifications, we need to fix this from the code side"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-authored-by: Sean Mooney \u003csmooney@redhat.com\u003e"},{"line_number":12,"context_line":"Change-Id: I0ba713fb0e22989192e8af83930ea05a62b80551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"b532b750_190ab740","line":11,"in_reply_to":"43409401_20f6c21e","updated":"2025-06-04 08:51:12.000000000","message":"Done","commit_id":"44890cee2e825531331bbcc85ec60521548d5310"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"94963d798fff2e45f91d12f303cf4a681ee2015e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At the moment, these phrases get into Zanata, and in many translations there are simply no spaces, which spoils the readability of notifications, we need to fix this from the code side"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-authored-by: Sean Mooney \u003csmooney@redhat.com\u003e"},{"line_number":12,"context_line":"Change-Id: I0ba713fb0e22989192e8af83930ea05a62b80551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"43409401_20f6c21e","line":11,"in_reply_to":"922f3108_9baaa6af","updated":"2025-06-04 08:47:34.000000000","message":"to be clear you do not add co-authored-by if you make changes requested by a reviewer\n\nthat is only ever added by that author if they modify your commit themselves.\n\nand only if its a non trivial change.","commit_id":"44890cee2e825531331bbcc85ec60521548d5310"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5acc563080bbc1b44f7d0e53522aa7cc93921db2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c03abca6_fb621f28","updated":"2025-06-01 15:43:41.000000000","message":"IMO this breaks the install guide since you nowhere say how to install the service with TLS enabled, just changing the referenced URLs will not magically perform that task","commit_id":"59e79bdc255f5a32f91b3e247eb81b7b3c37ffb6"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"41c6dcd1ec30f693daf05c43192ff4bc3802238a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"636d0b14_efdd38cb","updated":"2025-06-04 07:31:27.000000000","message":"@dcu995@gmail.com please check this.","commit_id":"5415fa7bf1509757c7361255324a3dbb78c4064d"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"b449f44917a6820ce7879b20d1e8f08b038e3310","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ceb08589_cf382a0c","in_reply_to":"636d0b14_efdd38cb","updated":"2025-06-04 10:50:48.000000000","message":"@dcu995@gmail.com thank you.","commit_id":"5415fa7bf1509757c7361255324a3dbb78c4064d"}],"horizon/static/horizon/js/horizon.messages.js":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"22980a1c1d733de5945b6e647321f0e017fed6e3","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    safe \u003d true;"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  var type_display \u003d {"},{"line_number":26,"context_line":"    \u0027danger\u0027: gettext(\"Danger:\") + \" \","},{"line_number":27,"context_line":"    \u0027warning\u0027: gettext(\"Warning:\") + \" \","},{"line_number":28,"context_line":"    \u0027info\u0027: gettext(\"Notice:\") + \" \","},{"line_number":29,"context_line":"    \u0027success\u0027: gettext(\"Success:\") + \" \","},{"line_number":30,"context_line":"    \u0027error\u0027: gettext(\"Error:\") + \" \""},{"line_number":31,"context_line":"  }[type];"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  // the \"error\" type needs to be rewritten as \"danger\" for correct styling"},{"line_number":34,"context_line":"  if (type \u003d\u003d\u003d \u0027error\u0027) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"3da587e2_9851632b","line":31,"range":{"start_line":25,"start_character":0,"end_line":31,"end_character":10},"updated":"2025-06-04 08:35:34.000000000","message":"i guess the intent is to allow the prefix to be translatable without the possiblity that the space is remvoed by acident\n\nif that is the case i might consider something like this instead\n\n```suggestion\n  var type_display \u003d {\n    \u0027danger\u0027: f\u0027{gettext(\"Danger:\").trim()} \u0027,\n    \u0027warning\u0027: f\u0027{gettext(\"Warning:\").trim()} \u0027,\n    \u0027info\u0027: f\u0027{gettext(\"Notice:\").trim()} \u0027,\n    \u0027success\u0027: f\u0027{gettext(\"Success:\").trim()} \u0027,\n    \u0027error\u0027: f\u0027{gettext(\"Error:\").trim()} \u0027\n  }[type];\n```","commit_id":"5415fa7bf1509757c7361255324a3dbb78c4064d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e81a8cee5c188694467c2337953eb25ce5676d1","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    safe \u003d true;"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  var type_display \u003d {"},{"line_number":26,"context_line":"    \u0027danger\u0027: gettext(\"Danger:\") + \" \","},{"line_number":27,"context_line":"    \u0027warning\u0027: gettext(\"Warning:\") + \" \","},{"line_number":28,"context_line":"    \u0027info\u0027: gettext(\"Notice:\") + \" \","},{"line_number":29,"context_line":"    \u0027success\u0027: gettext(\"Success:\") + \" \","},{"line_number":30,"context_line":"    \u0027error\u0027: gettext(\"Error:\") + \" \""},{"line_number":31,"context_line":"  }[type];"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  // the \"error\" type needs to be rewritten as \"danger\" for correct styling"},{"line_number":34,"context_line":"  if (type \u003d\u003d\u003d \u0027error\u0027) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"d36ca965_10b01c2d","line":31,"range":{"start_line":25,"start_character":0,"end_line":31,"end_character":10},"in_reply_to":"3da587e2_9851632b","updated":"2025-06-04 08:38:28.000000000","message":"oh... this is javascript right\n\nthey have a verion of f strign sbut i dotn recall the syntax of hand its \ncalled templeate strings i think\n\ninstead i would trim like this\n\n```suggestion\n  var type_display \u003d {\n    \u0027danger\u0027: gettext(\"Danger:\").trim() + \" \",\n    \u0027warning\u0027: gettext(\"Warning:\").trim() + \" \",\n    \u0027info\u0027: gettext(\"Notice:\").trim() + \" \",\n    \u0027success\u0027: gettext(\"Success:\").trim() + \" \",\n    \u0027error\u0027: gettext(\"Error:\").trim() + \" \"\n  }[type];\n```","commit_id":"5415fa7bf1509757c7361255324a3dbb78c4064d"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"432f2d803ae1a3d3b39d66409e24ba0208a212dd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    safe \u003d true;"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  var type_display \u003d {"},{"line_number":26,"context_line":"    \u0027danger\u0027: gettext(\"Danger:\") + \" \","},{"line_number":27,"context_line":"    \u0027warning\u0027: gettext(\"Warning:\") + \" \","},{"line_number":28,"context_line":"    \u0027info\u0027: gettext(\"Notice:\") + \" \","},{"line_number":29,"context_line":"    \u0027success\u0027: gettext(\"Success:\") + \" \","},{"line_number":30,"context_line":"    \u0027error\u0027: gettext(\"Error:\") + \" \""},{"line_number":31,"context_line":"  }[type];"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  // the \"error\" type needs to be rewritten as \"danger\" for correct styling"},{"line_number":34,"context_line":"  if (type \u003d\u003d\u003d \u0027error\u0027) {"}],"source_content_type":"text/javascript","patch_set":10,"id":"a1a8166e_44a9c0f2","line":31,"range":{"start_line":25,"start_character":0,"end_line":31,"end_character":10},"in_reply_to":"d36ca965_10b01c2d","updated":"2025-06-04 08:43:00.000000000","message":"Done, thank you Sean.","commit_id":"5415fa7bf1509757c7361255324a3dbb78c4064d"}]}