)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"6f2f7616215445c2e61209e85be4cad2a7123cfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"abcfef36_6a572cc8","updated":"2025-09-28 09:36:34.000000000","message":"Hi Radomir,\n\nNot sure what you are suggesting. Could you explain more what your suggestion is?","commit_id":"84d7790c9e0a0ee767747c4c60e47c8d0045a4f8"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"6e638ae425e602b2dd4f5b627ac088074c043ecd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"013f3c92_cdd3884b","updated":"2025-07-10 10:52:14.000000000","message":"I don\u0027t think our code needs to detect and handle errors caused by deleting part of that code. There is openstack_dashboard/local/enabled/__init__.py in the source tree, and unless someone intentionally deletes it from Horizon\u0027s source code, that import should always succeed. We can\u0027t realistically defend from people deleting parts of horizon code.","commit_id":"84d7790c9e0a0ee767747c4c60e47c8d0045a4f8"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"34b68c6d4cc9fa2083e00a19181c642663bb8cb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e01c8bba_71b8f162","updated":"2025-07-10 10:57:20.000000000","message":"If you are deleting parts of Horizon code, that is really a self-inflicted problem, and we can do nothing to defend from it. In unmodified Horizon source code openstack_dashboard/local/enabled/__init__.py always exists and that import always succeeds.","commit_id":"84d7790c9e0a0ee767747c4c60e47c8d0045a4f8"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"8d6f19d2400faf63ff796c842e9a98c48f8784e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d022e3d0_e4d47af1","in_reply_to":"abcfef36_6a572cc8","updated":"2025-10-06 09:43:41.000000000","message":"My suggestion is that you shouldn\u0027t be deleting files from Horizon\u0027s code base in the first place. The presence of `openstack_dashboard/local/enabled/__init__.py` file is sufficient to avoid the error you are having. Simply don\u0027t delete that file, and everything will be fine.","commit_id":"84d7790c9e0a0ee767747c4c60e47c8d0045a4f8"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"34b68c6d4cc9fa2083e00a19181c642663bb8cb2","unresolved":true,"context_lines":[{"line_number":360,"context_line":"        HORIZON_CONFIG,"},{"line_number":361,"context_line":"        INSTALLED_APPS,"},{"line_number":362,"context_line":"    )"},{"line_number":363,"context_line":"except NameError:"},{"line_number":364,"context_line":"    settings_utils.update_dashboards("},{"line_number":365,"context_line":"        ["},{"line_number":366,"context_line":"            enabled,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ec9acbfa_6026cf8c","line":363,"updated":"2025-07-10 10:57:20.000000000","message":"Instead of catching NameError here, which could really come from many different problems, not just missing local_enabled, how about handling the case in the import exception handling?","commit_id":"84d7790c9e0a0ee767747c4c60e47c8d0045a4f8"}]}