)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"3bb573efbd0ed21ab077d170cb1e793508c2c5ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ee5476f_d196086d","updated":"2025-12-02 13:31:48.000000000","message":"@openstack@dopieralski.pl, yes, it was a draft when I was waiting for fixes from the Security team. Now I asked them about a few missing information and I am planning to continue with this patch soon.","commit_id":"87a64505786b829abd2d854f57bf06ea84baf9f0"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"047a21215a0cc769f3faaa172863a9b83c575370","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6db9cb62_f20fad72","updated":"2025-12-02 13:00:24.000000000","message":"is this still relevant?","commit_id":"87a64505786b829abd2d854f57bf06ea84baf9f0"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"8f6dbde50a7a67c706c53ff7860d2242d0866911","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a565bccb_71c95ff6","updated":"2025-10-15 17:48:25.000000000","message":"recheck, race condition of downloading keypair and popup message?","commit_id":"87a64505786b829abd2d854f57bf06ea84baf9f0"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"f1284b2ad3b9fd30406f8133ea5501fb2d973657","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"97bbcc78_acb0dd80","updated":"2026-01-09 08:58:37.000000000","message":"recheck, random RETRY_LIMIT","commit_id":"2c6d74ed70ca505e1f8a9925f669f1aba6a6b97b"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"93da874a5b6ecdf844b9fd1712f10407979ba707","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7e797645_fae56eda","updated":"2026-01-09 09:42:32.000000000","message":"recheck, random RETRY_LIMIT?","commit_id":"2c6d74ed70ca505e1f8a9925f669f1aba6a6b97b"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"e3b979a924901d2d5fc6e750cd8977940e3afddc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"19a834be_5a8b1200","updated":"2026-01-09 10:34:47.000000000","message":"recheck, random failure in stable test, it seems the CI is not in best condition.","commit_id":"2c6d74ed70ca505e1f8a9925f669f1aba6a6b97b"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"9660af72afe22a02c7775b5721196295a8d37cf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"847678d9_63116ecc","updated":"2026-01-15 14:59:38.000000000","message":"Everything should be fine, ready for reviews.","commit_id":"e52e88891c5629465fd26c0a0a71db493738af81"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"5a753ef34a5e83ef865353a195acc6da98161f71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7877e545_970aa93c","updated":"2026-01-15 12:29:23.000000000","message":"Verifying few more things, should be ready for final review soon.","commit_id":"e52e88891c5629465fd26c0a0a71db493738af81"}],"openstack_dashboard/test/selenium/conftest.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"a28112a80e47a25f72780718642e69aeac90e2bd","unresolved":true,"context_lines":[{"line_number":219,"context_line":"        keycloak_pass_field.send_keys(password)"},{"line_number":220,"context_line":"        kc_login_button \u003d self.driver.find_element_by_id(\u0027kc-login\u0027)"},{"line_number":221,"context_line":"        kc_login_button.click()"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"@pytest.fixture(scope\u003d\u0027session\u0027)"},{"line_number":225,"context_line":"def login(driver, config):"}],"source_content_type":"text/x-python","patch_set":7,"id":"4600a978_3625140c","line":222,"updated":"2026-01-13 10:30:49.000000000","message":"I think it would be better to make all those login functions idempotent -- that is, save in the session the current user and login method, and only perform the actual logout and login when that changes. This way multiple tests that use the same user and login method don\u0027t need to re-login every time.","commit_id":"4d012b6a32a242128f9a7bde2033e58ca2a27a88"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"6ce4a4d2a8824f72f802ef31ee844e54b99dfbdc","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        keycloak_pass_field.send_keys(password)"},{"line_number":220,"context_line":"        kc_login_button \u003d self.driver.find_element_by_id(\u0027kc-login\u0027)"},{"line_number":221,"context_line":"        kc_login_button.click()"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"@pytest.fixture(scope\u003d\u0027session\u0027)"},{"line_number":225,"context_line":"def login(driver, config):"}],"source_content_type":"text/x-python","patch_set":7,"id":"759de080_c29b4b78","line":222,"in_reply_to":"4600a978_3625140c","updated":"2026-01-13 23:07:11.000000000","message":"Done","commit_id":"4d012b6a32a242128f9a7bde2033e58ca2a27a88"}],"openstack_dashboard/test/selenium/integration/conftest.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"a28112a80e47a25f72780718642e69aeac90e2bd","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    \"\"\"Expose the credentials dict for test assertions.\"\"\""},{"line_number":95,"context_line":"    return multi_realm_session.idps_oidc_credentials"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"def change_page_size(driver, config, page_size):"},{"line_number":99,"context_line":"    url \u003d \u0027/\u0027.join(("},{"line_number":100,"context_line":"        config.dashboard.dashboard_url,"}],"source_content_type":"text/x-python","patch_set":7,"id":"746f9358_cfe67e3a","line":97,"updated":"2026-01-13 10:30:49.000000000","message":"I\u0027m not sure what the purpose of those fixtures is?","commit_id":"4d012b6a32a242128f9a7bde2033e58ca2a27a88"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"6ce4a4d2a8824f72f802ef31ee844e54b99dfbdc","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    \"\"\"Expose the credentials dict for test assertions.\"\"\""},{"line_number":95,"context_line":"    return multi_realm_session.idps_oidc_credentials"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"def change_page_size(driver, config, page_size):"},{"line_number":99,"context_line":"    url \u003d \u0027/\u0027.join(("},{"line_number":100,"context_line":"        config.dashboard.dashboard_url,"}],"source_content_type":"text/x-python","patch_set":7,"id":"b8e0e245_4af47964","line":97,"in_reply_to":"746f9358_cfe67e3a","updated":"2026-01-13 23:07:11.000000000","message":"Done","commit_id":"4d012b6a32a242128f9a7bde2033e58ca2a27a88"}],"openstack_dashboard/test/selenium/integration/test_federation_login.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"a28112a80e47a25f72780718642e69aeac90e2bd","unresolved":true,"context_lines":[{"line_number":93,"context_line":"reset login (to login using different user under the same IdP)."},{"line_number":94,"context_line":"The tests can not run independently because since one user is logged in"},{"line_number":95,"context_line":"using full_auth, there is no possibility use full_auth steps again"},{"line_number":96,"context_line":"and we need to keep order of the tests and their dependencies\"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def test_multi_realm_IdP1_login_full_flow("}],"source_content_type":"text/x-python","patch_set":7,"id":"f30d574b_f82870ae","line":96,"updated":"2026-01-13 10:30:49.000000000","message":"the docstring should go at the top of function or class, use regular comments with \"#\" for any non-docstring comments","commit_id":"4d012b6a32a242128f9a7bde2033e58ca2a27a88"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"6ce4a4d2a8824f72f802ef31ee844e54b99dfbdc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"reset login (to login using different user under the same IdP)."},{"line_number":94,"context_line":"The tests can not run independently because since one user is logged in"},{"line_number":95,"context_line":"using full_auth, there is no possibility use full_auth steps again"},{"line_number":96,"context_line":"and we need to keep order of the tests and their dependencies\"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def test_multi_realm_IdP1_login_full_flow("}],"source_content_type":"text/x-python","patch_set":7,"id":"c49d628a_f2c9fab2","line":96,"in_reply_to":"f30d574b_f82870ae","updated":"2026-01-13 23:07:11.000000000","message":"Done","commit_id":"4d012b6a32a242128f9a7bde2033e58ca2a27a88"}]}
