)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"2e0d8eef841991ecf47f66e2d5ec66c8761bf758","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6d167e58_2cbad8ca","updated":"2025-11-20 11:58:20.000000000","message":"LGTM, trivial.","commit_id":"9863f8bd5fa7feeb73b0945db89bb278331f99a4"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"45c8b52e080bbd07fce56381c2b95628910078c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9740df6_55b7484e","updated":"2025-11-25 20:39:45.000000000","message":"Ok, let me summarize what we have so far (tested on both on Firefox and Chrome):\n- With or without \"margin-top: -1px;\" I see inconsistent thickness of borders;\n- Having both \"margin-top: -1px;\" and \"border-bottom: 1px solid #ddd;\" gives 2px thick borders and keeps the border between the row and the details;\n- Having just \"border-bottom: 1px solid #ddd;\" and without \"margin-top: -1px;\" I have the same effect: 2px thick borders and keeps the border between the row and the details;\n- Having \"border-top: 1px;\" with or without \"margin-top: -1px;\" gives 1px border between rows and no border between the row and the details when the chevron is open.\n\nWhat would we like to proceed with? Do we have any other places we could tweak the details row border? Shall we just leave it without a border since the background color is different anyway and it helps to separate the details from the different row?","commit_id":"9863f8bd5fa7feeb73b0945db89bb278331f99a4"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"15533d157b77d80a20f5ef22e8e8df32db9f7e07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dcb307a1_e6d301d9","updated":"2025-11-25 16:38:58.000000000","message":"This removes the lines in firefox when the extra info is expanded.","commit_id":"9863f8bd5fa7feeb73b0945db89bb278331f99a4"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"e885049cc0dcf8562c7eb0cb20519dce10d8379e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7ff0992_7b5c8cc3","in_reply_to":"dcb307a1_e6d301d9","updated":"2025-11-25 17:05:51.000000000","message":"@openstack@dopieralski.pl hello, hmm, in Safari all fine... I recheck in another browsers...","commit_id":"9863f8bd5fa7feeb73b0945db89bb278331f99a4"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"b429f3bacf59a155ec93ee2a0f1b107c41554e43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8aa5671b_73437740","updated":"2025-11-26 18:19:01.000000000","message":"Please add screenshot from Chrome, Firefox..","commit_id":"08991c1417b994f956af85bbc1bc3c7d4d4a9af8"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"121165cfb5b79c2eaa9454bb22c72b556f1354b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"77758dc1_1ac532ab","updated":"2025-12-02 16:42:38.000000000","message":"recheck","commit_id":"c425d6b243833bd9ac4247c84c50ecc459ac2643"}],"openstack_dashboard/dashboards/project/templates/key_pairs/_keypairs_table.html":[{"author":{"_account_id":32432,"name":"Owen McGonagle","email":"omcgonag@redhat.com","username":"omcgonag"},"change_message_id":"8536e2fdec0feaa55c1256a760adc98f0214b27b","unresolved":true,"context_lines":[{"line_number":52,"context_line":"  padding: 0;"},{"line_number":53,"context_line":"  overflow: hidden;"},{"line_number":54,"context_line":"  margin-top: -1px; /* Get rid of the double horizontal line when collapsed */"},{"line_number":55,"context_line":"  border-top: 1px;"},{"line_number":56,"context_line":"  border-bottom: 1px;"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""}],"source_content_type":"text/html","patch_set":1,"id":"22491fff_5e897886","line":55,"updated":"2025-11-21 01:52:00.000000000","message":"I have read and seen other places in the code where\n\u0027style\u0027 and \u0027color\u0027 values are included\n\nif not specified, I believe the default to ?\n\nHere is one recommendation to use:\n\nborder-top: 1px solid #ddd;\nborder-bottom: 1px solid #ddd;\n\nwhere #ddd is a light gray color","commit_id":"9863f8bd5fa7feeb73b0945db89bb278331f99a4"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"3fb599af2f7ab67ebdfdd545986259068fb571af","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  padding: 0;"},{"line_number":53,"context_line":"  overflow: hidden;"},{"line_number":54,"context_line":"  margin-top: -1px; /* Get rid of the double horizontal line when collapsed */"},{"line_number":55,"context_line":"  border-top: 1px;"},{"line_number":56,"context_line":"  border-bottom: 1px;"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""}],"source_content_type":"text/html","patch_set":1,"id":"1110c6fb_fc612ac0","line":55,"in_reply_to":"0a0023f1_85cc4648","updated":"2025-11-25 16:34:39.000000000","message":"The td already has borders from this rule:\n\n.table\u003ethead\u003etr\u003eth, .table\u003ethead\u003etr\u003etd, .table\u003etbody\u003etr\u003eth, .table\u003etbody\u003etr\u003etd, .table\u003etfoot\u003etr\u003eth, .table\u003etfoot\u003etr\u003etd {\n    padding: 8px;\n    line-height: 1.42857;\n    vertical-align: top;\n    border-top: 1px solid #ddd;\n}\n\nare you sure this is making any difference? Is this because you are removing the color and style?","commit_id":"9863f8bd5fa7feeb73b0945db89bb278331f99a4"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"45c8b52e080bbd07fce56381c2b95628910078c0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  padding: 0;"},{"line_number":53,"context_line":"  overflow: hidden;"},{"line_number":54,"context_line":"  margin-top: -1px; /* Get rid of the double horizontal line when collapsed */"},{"line_number":55,"context_line":"  border-top: 1px;"},{"line_number":56,"context_line":"  border-bottom: 1px;"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""}],"source_content_type":"text/html","patch_set":1,"id":"748deba4_dfdf5e4d","line":55,"in_reply_to":"1110c6fb_fc612ac0","updated":"2025-11-25 20:39:45.000000000","message":"Yes, without style it behaves differently.","commit_id":"9863f8bd5fa7feeb73b0945db89bb278331f99a4"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"c29a594a42ba75b87990a7a69da6a60abe82215e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  padding: 0;"},{"line_number":53,"context_line":"  overflow: hidden;"},{"line_number":54,"context_line":"  margin-top: -1px; /* Get rid of the double horizontal line when collapsed */"},{"line_number":55,"context_line":"  border-top: 1px;"},{"line_number":56,"context_line":"  border-bottom: 1px;"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""}],"source_content_type":"text/html","patch_set":1,"id":"0a0023f1_85cc4648","line":55,"in_reply_to":"22491fff_5e897886","updated":"2025-11-24 21:25:01.000000000","message":"Hey, thanks for your review! I tried your suggestion, and it makes borders twice thicker on my env. I would stick to my solution which gives us 1px border, same as what we have in AngularJS version.","commit_id":"9863f8bd5fa7feeb73b0945db89bb278331f99a4"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"ff35d90e2f08d5a52b4c782eaa4bdd6ad879c3fd","unresolved":true,"context_lines":[{"line_number":51,"context_line":".table\u003etbody\u003etr.keypair-detail-row\u003etd {"},{"line_number":52,"context_line":"  padding: 0;"},{"line_number":53,"context_line":"  overflow: hidden;"},{"line_number":54,"context_line":"  border-top: none; /* Get rid of the double horizontal line when collapsed */"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"/* Add margin inner content when expanded */"}],"source_content_type":"text/html","patch_set":2,"id":"76881cc1_e246845a","line":54,"updated":"2025-11-27 14:45:43.000000000","message":"this should be border-botttom, we want to keep border-top","commit_id":"08991c1417b994f956af85bbc1bc3c7d4d4a9af8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"db9ef6d83abec37790ceacd804c4a78f7e20c228","unresolved":false,"context_lines":[{"line_number":51,"context_line":".table\u003etbody\u003etr.keypair-detail-row\u003etd {"},{"line_number":52,"context_line":"  padding: 0;"},{"line_number":53,"context_line":"  overflow: hidden;"},{"line_number":54,"context_line":"  border-top: none; /* Get rid of the double horizontal line when collapsed */"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"/* Add margin inner content when expanded */"}],"source_content_type":"text/html","patch_set":2,"id":"99465e18_1112b85c","line":54,"in_reply_to":"76881cc1_e246845a","updated":"2025-11-27 17:40:06.000000000","message":"border-top is the one that is inconsistent, at least on both my envs. I just made it red for testing, and it was visible in 5 fields out of 10. border-top is visible _sometimes_, making the total border 2px thick. border-bottom is consistent and always visible. I don\u0027t know how to fix this. I suggest to remove it as a trade off.","commit_id":"08991c1417b994f956af85bbc1bc3c7d4d4a9af8"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"f9c9076fac11b6365a279c3b3591f4d476a461c5","unresolved":false,"context_lines":[{"line_number":51,"context_line":".table\u003etbody\u003etr.keypair-detail-row\u003etd {"},{"line_number":52,"context_line":"  padding: 0;"},{"line_number":53,"context_line":"  overflow: hidden;"},{"line_number":54,"context_line":"  border-top: none; /* Get rid of the double horizontal line when collapsed */"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"/* Add margin inner content when expanded */"}],"source_content_type":"text/html","patch_set":2,"id":"2b0ba36e_afab279f","line":54,"in_reply_to":"99465e18_1112b85c","updated":"2025-11-28 16:52:09.000000000","message":"It\u0027s a table, the borders are shared. One cell\u0027s top is thew other\u0027s bottom. The bottom border is the one that shows up on the empty tr below. Just try with border-bottom and see that it works. We tried it on the call.","commit_id":"08991c1417b994f956af85bbc1bc3c7d4d4a9af8"}]}