)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7c240d0acb9a4be91ad73130182e093828669319","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fb9696ba_5e500c9f","updated":"2026-03-20 08:36:59.000000000","message":"As I see the py310 job the 4 failing tests are failing due to the change itself, please change (if I understand well the py314 filure is not related)","commit_id":"ccc640fdf68af49c9d1b774c0143f1bb71d7c0a5"}],"openstack_dashboard/api/neutron.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7c240d0acb9a4be91ad73130182e093828669319","unresolved":true,"context_lines":[{"line_number":355,"context_line":"        else:"},{"line_number":356,"context_line":"            proto_port \u003d \u0027\u0027"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        return (_(\u0027ALLOW %(ether_type)s \u0027"},{"line_number":359,"context_line":"                  \u0027%(proto_port)s %(direction)s \u0027"},{"line_number":360,"context_line":"                  \u0027%(remote)s\u0027) %"},{"line_number":361,"context_line":"                {\u0027ether_type\u0027: self.ethertype,"},{"line_number":362,"context_line":"                 \u0027proto_port\u0027: proto_port,"},{"line_number":363,"context_line":"                 \u0027remote\u0027: remote,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3256e438_645879e4","line":360,"range":{"start_line":358,"start_character":0,"end_line":360,"end_character":33},"updated":"2026-03-20 08:36:59.000000000","message":"nit: useless change (perhaps was necessary for some new pep8 rule, so really nit)","commit_id":"ccc640fdf68af49c9d1b774c0143f1bb71d7c0a5"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"b41b5a1351b359ff4a78d3f5f2ae3f1761bf952d","unresolved":true,"context_lines":[{"line_number":740,"context_line":"            fip[\"instance_id\"] \u003d port.get(\"device_id\")"},{"line_number":741,"context_line":"            fip[\"instance_type\"] \u003d self._get_instance_type_from_device_owner("},{"line_number":742,"context_line":"                port.get(\"device_owner\"))"},{"line_number":743,"context_line":"        else:"},{"line_number":744,"context_line":"            try:"},{"line_number":745,"context_line":"                if not port:"},{"line_number":746,"context_line":"                    port \u003d port_get(self.request, fip[\u0027port_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"9e7ff4f5_d6d76409","line":743,"updated":"2026-03-23 13:01:45.000000000","message":"By the way, instead of putting the entire function in an else block, how about an early return instead?","commit_id":"ccc640fdf68af49c9d1b774c0143f1bb71d7c0a5"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"d343b326779c88b77956a54193e00c3a1553d2cd","unresolved":true,"context_lines":[{"line_number":740,"context_line":"            fip[\"instance_id\"] \u003d port.get(\"device_id\")"},{"line_number":741,"context_line":"            fip[\"instance_type\"] \u003d self._get_instance_type_from_device_owner("},{"line_number":742,"context_line":"                port.get(\"device_owner\"))"},{"line_number":743,"context_line":"        else:"},{"line_number":744,"context_line":"            try:"},{"line_number":745,"context_line":"                if not port:"},{"line_number":746,"context_line":"                    port \u003d port_get(self.request, fip[\u0027port_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"c2b43aeb_c06dcedd","line":743,"in_reply_to":"9e7ff4f5_d6d76409","updated":"2026-03-31 16:23:14.000000000","message":"will do, should also also fix the below \"line too long\"","commit_id":"ccc640fdf68af49c9d1b774c0143f1bb71d7c0a5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7c240d0acb9a4be91ad73130182e093828669319","unresolved":true,"context_lines":[{"line_number":745,"context_line":"                if not port:"},{"line_number":746,"context_line":"                    port \u003d port_get(self.request, fip[\u0027port_id\u0027])"},{"line_number":747,"context_line":"                fip[\u0027instance_id\u0027] \u003d port.device_id"},{"line_number":748,"context_line":"                fip[\u0027instance_type\u0027] \u003d self._get_instance_type_from_device_owner("},{"line_number":749,"context_line":"                    port.device_owner)"},{"line_number":750,"context_line":"            except sdk_exceptions.ResourceNotFound:"},{"line_number":751,"context_line":"                LOG.debug(\"Failed to get port %s details for floating IP %s\","}],"source_content_type":"text/x-python","patch_set":7,"id":"cdda4248_8769acd9","line":748,"in_reply_to":"34c88784_5aa2e9cb","updated":"2026-03-20 08:36:59.000000000","message":"\u003e pep8: E501 line too long (81 \u003e 80 characters)\n\nPlease fix.","commit_id":"ccc640fdf68af49c9d1b774c0143f1bb71d7c0a5"}]}
