)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4e982b10c10c684d713b6733ca8223452e049ff9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bcaaa92a_cd5864c5","updated":"2026-02-27 23:51:14.000000000","message":"I didn\u0027t see this previously, but I have an alternative, slightly more incremental approach [here](https://review.opendev.org/c/openstack/horizon/+/978265) that might be worth a look?","commit_id":"e4aa4c7b8754803d382207cf1e24495a948004d2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8595dce71f1d01200e13c2713277a3b738d5f8ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f0714473_31281d10","in_reply_to":"38ada48f_8a190d85","updated":"2026-03-02 10:05:46.000000000","message":"Okay. IMO you could rebase on top of https://review.opendev.org/c/openstack/horizon/+/978264/. You\u0027re missing a few steps like the removal of PhantomJS and I also think you\u0027d be better off separating out the replacement of the `find_element_by_*` calls, as I\u0027ve done [here](https://review.opendev.org/c/openstack/horizon/+/978262/1) (since that is compatible with both selenium 3.x and 4.x and it makes the functional changes much easier to review), however, you\u0027ve removed the entirety of `horizon.test.firefox_binary` here and other things which makes this patch more complete than [my attempt to do the same](https://review.opendev.org/c/openstack/horizon/+/978265/). My 2c","commit_id":"e4aa4c7b8754803d382207cf1e24495a948004d2"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"b32390e590b0eeca1d643b0a2fa73339760254ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"38ada48f_8a190d85","in_reply_to":"bcaaa92a_cd5864c5","updated":"2026-03-02 09:42:25.000000000","message":"Thank you for your effort, but I think we will continue with our approach for now, because it looks like it\u0027s close to finished. I think we can still use some of your patches.","commit_id":"e4aa4c7b8754803d382207cf1e24495a948004d2"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"e1a17c257c78bf90918d73d8e2f0c11d11519573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ed2ff13f_4de65199","in_reply_to":"f0714473_31281d10","updated":"2026-03-02 10:12:58.000000000","message":"That sounds like a good idea, I will try it. The truth is, we need to remove much more in there, but I would rather get that done piecemeal, especially since some plugin tests also depend on our test helpers.","commit_id":"e4aa4c7b8754803d382207cf1e24495a948004d2"}]}
