)]}'
{"openstack_dashboard/test/integration_tests/helpers.py":[{"author":{"_account_id":1795,"name":"Ravikumar Venkatesan","email":"ravikumar.venkatesan@hpe.com","username":"ravikumar-venkatesan"},"change_message_id":"bf9a45321a8fa385a5fd91540663906b4c5f64d2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        if os.environ.get(\u0027INTEGRATION_TESTS\u0027, False):"},{"line_number":27,"context_line":"            self.driver \u003d selenium.webdriver.Firefox()"},{"line_number":28,"context_line":"            self.conf \u003d config.get_config()"},{"line_number":29,"context_line":"            self.driver.implicitly_wait(self.conf.dashboard.page_timeout)"},{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            msg \u003d \"The INTEGRATION_TESTS env variable is not set.\""},{"line_number":32,"context_line":"            raise self.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_3b201cf8","line":29,"updated":"2014-07-22 19:09:19.000000000","message":"Need to rebase helpers.py as there are other checkins with updates like window maximize etc.","commit_id":"2c25f7be84c583ef994c72831ad52980cb194019"},{"author":{"_account_id":10185,"name":"Sunil Mamillapalli","email":"sunil_mamillapalli@persistent.co.in","username":"sunil-mamillapalli"},"change_message_id":"a0e9c2d59aca6c2cc2cb58ee1a8901c1053530b3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        if os.environ.get(\u0027INTEGRATION_TESTS\u0027, False):"},{"line_number":27,"context_line":"            self.driver \u003d selenium.webdriver.Firefox()"},{"line_number":28,"context_line":"            self.conf \u003d config.get_config()"},{"line_number":29,"context_line":"            self.driver.implicitly_wait(self.conf.dashboard.page_timeout)"},{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            msg \u003d \"The INTEGRATION_TESTS env variable is not set.\""},{"line_number":32,"context_line":"            raise self.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_ea20a9b3","line":29,"in_reply_to":"baada198_3b201cf8","updated":"2014-07-29 12:03:27.000000000","message":"Done","commit_id":"2c25f7be84c583ef994c72831ad52980cb194019"}],"openstack_dashboard/test/integration_tests/pages/accesssecuritypage.py":[{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"2af524ec86fdf2b61cf4a8e9cfb44bd229b5441a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __init__(self, driver, conf):"},{"line_number":25,"context_line":"        super(AccessSecurityPage, self).__init__(driver, conf)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @property"},{"line_number":28,"context_line":"    def secgroup_link(self):"},{"line_number":29,"context_line":"        return self.get_element(*self._secgroup_link_locator)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_d31efdbb","line":26,"updated":"2014-06-25 08:23:17.000000000","message":"self._page_title is not being assigned method is_the_current_page will not work","commit_id":"344586760b58c61a496e1134f390665b9ec829c4"},{"author":{"_account_id":10185,"name":"Sunil Mamillapalli","email":"sunil_mamillapalli@persistent.co.in","username":"sunil-mamillapalli"},"change_message_id":"1fce153064ce5df999a68e0b4107d4dc63890cb6","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __init__(self, driver, conf):"},{"line_number":25,"context_line":"        super(AccessSecurityPage, self).__init__(driver, conf)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @property"},{"line_number":28,"context_line":"    def secgroup_link(self):"},{"line_number":29,"context_line":"        return self.get_element(*self._secgroup_link_locator)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b3e9cfb9","line":26,"in_reply_to":"1ae5cdf2_d31efdbb","updated":"2014-07-22 12:08:40.000000000","message":"Done","commit_id":"344586760b58c61a496e1134f390665b9ec829c4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"88fbba4210b9aadfc3b66e98302b15e791088500","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @property"},{"line_number":33,"context_line":"    def secgroup_link(self):"},{"line_number":34,"context_line":"        return self.get_element(*self._secgroup_link_locator)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _click_on_secgroup_link(self):"},{"line_number":37,"context_line":"        self.secgroup_link.click()"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_26ee2aee","line":35,"updated":"2014-07-30 14:03:59.000000000","message":"it is not necessary to create this method, just call it directly","commit_id":"26edec511641d3f2f2fed2fc4e4471d7988f2e69"}],"openstack_dashboard/test/integration_tests/pages/basepage.py":[{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"88fbba4210b9aadfc3b66e98302b15e791088500","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        @property"},{"line_number":117,"context_line":"        def project_menu(self):"},{"line_number":118,"context_line":"            return self.get_element(*self._project_locator)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        def _click_on_project_menu(self):"},{"line_number":121,"context_line":"            self.project_menu.click()"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_e6ca726e","line":119,"updated":"2014-07-30 14:03:59.000000000","message":"Again no need to create _click method...","commit_id":"26edec511641d3f2f2fed2fc4e4471d7988f2e69"}],"openstack_dashboard/test/integration_tests/pages/projectpage.py":[{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"88fbba4210b9aadfc3b66e98302b15e791088500","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        self.topbar.user_dropdown_menu.click()"},{"line_number":25,"context_line":"        self.topbar.settings_link.click()"},{"line_number":26,"context_line":"        return settingspage.SettingsPage(self.driver, self.conf)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def go_to_accesssecurity_page(self):"},{"line_number":29,"context_line":"        _access_security_locator_flag \u003d self.is_element_visible("},{"line_number":30,"context_line":"            *self.navaccordion._project_access_security_locator)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_26d8ea1d","line":27,"updated":"2014-07-30 14:03:59.000000000","message":"Your test will fail for the admin user because of the navigation, you could consider using navigation module: https://review.openstack.org/#/c/110425/","commit_id":"26edec511641d3f2f2fed2fc4e4471d7988f2e69"}],"openstack_dashboard/test/integration_tests/pages/securitygrouppage.py":[{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"2af524ec86fdf2b61cf4a8e9cfb44bd229b5441a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        by.By.CSS_SELECTOR, \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u0027"},{"line_number":39,"context_line":"        \u0027\u003etd[class\u003d\"multi_select_column\"]\u003e\u0027"},{"line_number":40,"context_line":"        \u0027input[class\u003d\"table-row-multi-select\"]\u0027 % (secgroup_name))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, driver, conf):"},{"line_number":43,"context_line":"        super(SecurityGroupPage, self).__init__(driver, conf)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_53610d37","line":41,"updated":"2014-06-25 08:23:17.000000000","message":"self._page_title is not being assigned","commit_id":"344586760b58c61a496e1134f390665b9ec829c4"},{"author":{"_account_id":10185,"name":"Sunil Mamillapalli","email":"sunil_mamillapalli@persistent.co.in","username":"sunil-mamillapalli"},"change_message_id":"1fce153064ce5df999a68e0b4107d4dc63890cb6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        by.By.CSS_SELECTOR, \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u0027"},{"line_number":39,"context_line":"        \u0027\u003etd[class\u003d\"multi_select_column\"]\u003e\u0027"},{"line_number":40,"context_line":"        \u0027input[class\u003d\"table-row-multi-select\"]\u0027 % (secgroup_name))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, driver, conf):"},{"line_number":43,"context_line":"        super(SecurityGroupPage, self).__init__(driver, conf)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_53da331e","line":41,"in_reply_to":"1ae5cdf2_53610d37","updated":"2014-07-22 12:08:40.000000000","message":"Done","commit_id":"344586760b58c61a496e1134f390665b9ec829c4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"2af524ec86fdf2b61cf4a8e9cfb44bd229b5441a","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, driver, conf):"},{"line_number":43,"context_line":"        super(SecurityGroupPage, self).__init__(driver, conf)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"},{"line_number":46,"context_line":"    def secgroup_create(self):"},{"line_number":47,"context_line":"        return self.get_element(*self._secgroup_create_button_locator)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_b7015cb1","line":44,"updated":"2014-06-25 08:23:17.000000000","message":"I have implemented couple regions, i call one of them ComplexActionTableRegion - i think you can benefit from it, you can find them in this commit https://review.openstack.org/#/c/102227/ , would you mind incorporating them into your work or adding more functionality that suit your needs/inherit from already created? :o)","commit_id":"344586760b58c61a496e1134f390665b9ec829c4"},{"author":{"_account_id":1795,"name":"Ravikumar Venkatesan","email":"ravikumar.venkatesan@hpe.com","username":"ravikumar-venkatesan"},"change_message_id":"bf9a45321a8fa385a5fd91540663906b4c5f64d2","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            by.By.CSS_SELECTOR,"},{"line_number":83,"context_line":"            \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u0027 % (secgroup_name))"},{"line_number":84,"context_line":"        return _secgroup_create_check_locator"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def delete_secgroup(self, secgroup_name):"},{"line_number":87,"context_line":"        _secgroup_delete_check_locator \u003d ("},{"line_number":88,"context_line":"            by.By.CSS_SELECTOR, \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_9b47687a","line":85,"updated":"2014-07-22 19:09:19.000000000","message":"Create method for update_secgroup","commit_id":"2c25f7be84c583ef994c72831ad52980cb194019"},{"author":{"_account_id":10185,"name":"Sunil Mamillapalli","email":"sunil_mamillapalli@persistent.co.in","username":"sunil-mamillapalli"},"change_message_id":"a0e9c2d59aca6c2cc2cb58ee1a8901c1053530b3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            by.By.CSS_SELECTOR,"},{"line_number":83,"context_line":"            \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u0027 % (secgroup_name))"},{"line_number":84,"context_line":"        return _secgroup_create_check_locator"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def delete_secgroup(self, secgroup_name):"},{"line_number":87,"context_line":"        _secgroup_delete_check_locator \u003d ("},{"line_number":88,"context_line":"            by.By.CSS_SELECTOR, \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_0a1ebd74","line":85,"in_reply_to":"baada198_9b47687a","updated":"2014-07-29 12:03:27.000000000","message":"Done","commit_id":"2c25f7be84c583ef994c72831ad52980cb194019"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"88fbba4210b9aadfc3b66e98302b15e791088500","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from openstack_dashboard.test.integration_tests.pages import basepage"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SecurityGroupPage(basepage.BasePage):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _secgroup_create_button_locator \u003d (by.By.CSS_SELECTOR,"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_297efdaf","line":20,"updated":"2014-07-30 14:03:59.000000000","message":"I would encourage you to create one base page for the rest of the pages that are under access and security. So you do not need to repeat the self._page_title initialization and common locators, method ...","commit_id":"26edec511641d3f2f2fed2fc4e4471d7988f2e69"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"19446893b9c8f31f3e5335790e74ed9fb99948ab","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SecurityGroupPage(basepage.BasePage):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _secgroup_create_button_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":24,"context_line":"                                       \u0027#security_groups__action_create\u0027)"},{"line_number":25,"context_line":"    _secgroup_name_field_locator \u003d (by.By.CSS_SELECTOR, \u0027#id_name\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_01996279","line":22,"updated":"2014-08-12 12:32:12.000000000","message":"We need test \"cancel\" button for popup","commit_id":"26edec511641d3f2f2fed2fc4e4471d7988f2e69"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"88fbba4210b9aadfc3b66e98302b15e791088500","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    @property"},{"line_number":67,"context_line":"    def secgroup_edit(self):"},{"line_number":68,"context_line":"        return self.get_element(*self._secgroup_edit_button_locator)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _click_on_secgroup_create(self):"},{"line_number":71,"context_line":"        self.secgroup_create.click()"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_4fb6d126","line":69,"updated":"2014-07-30 14:03:59.000000000","message":"it is not necessary to define those _click methods if property exist","commit_id":"26edec511641d3f2f2fed2fc4e4471d7988f2e69"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"27f59f8ad93494f617c24d9e99c447a52050bfcd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from selenium.webdriver.common import by"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from openstack_dashboard.test.integration_tests.pages import basepage"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SecurityGroupPage(basepage.BasePage):"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_81df520c","line":19,"updated":"2014-09-04 07:27:43.000000000","message":"Note that there was a change in the table, I\u0027ve wrote few comments concerning it.","commit_id":"98a97c9d23697ef0bc417f940126bbbf31eda29e"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"27f59f8ad93494f617c24d9e99c447a52050bfcd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from openstack_dashboard.test.integration_tests.pages import basepage"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SecurityGroupPage(basepage.BasePage):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _secgroup_create_button_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":24,"context_line":"                                       \u0027#security_groups__action_create\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_19d8617a","line":21,"updated":"2014-09-04 07:27:43.000000000","message":"I agree with Tomas\u0027s comment from patch set #6, this should be a subpage of access and security page (as well as key pairs, floating ips and api access)","commit_id":"98a97c9d23697ef0bc417f940126bbbf31eda29e"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"27f59f8ad93494f617c24d9e99c447a52050bfcd","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SecurityGroupPage(basepage.BasePage):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _secgroup_create_button_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":24,"context_line":"                                       \u0027#security_groups__action_create\u0027)"},{"line_number":25,"context_line":"    _secgroup_name_field_locator \u003d (by.By.CSS_SELECTOR, \u0027#id_name\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_81b832c9","line":22,"updated":"2014-09-04 07:27:43.000000000","message":"there should also be a locator for the \"Manage Rules\" option","commit_id":"98a97c9d23697ef0bc417f940126bbbf31eda29e"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"27f59f8ad93494f617c24d9e99c447a52050bfcd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u0027"},{"line_number":37,"context_line":"        \u0027\u003etd[class\u003d\"multi_select_column\"]\u003e\u0027"},{"line_number":38,"context_line":"        \u0027input[class\u003d\"table-row-multi-select\"]\u0027)"},{"line_number":39,"context_line":"    _secgroup_more_dropdown_template_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":40,"context_line":"        \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u003e\u0027"},{"line_number":41,"context_line":"        \u0027td\u003ediv\u003ea[data-toggle\u003d\"dropdown\"]\u0027)"},{"line_number":42,"context_line":"    _secgroup_edit_button_template_locator \u003d (by.By.CSS_SELECTOR,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_c1979a38","line":39,"updated":"2014-09-04 07:27:43.000000000","message":"following the change in the table, instead of \"more\" there is just a dropdown-toggle","commit_id":"98a97c9d23697ef0bc417f940126bbbf31eda29e"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"4800c3b0afd06b26d5d2e3bdddb6f28d929552b6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u003e\u0027"},{"line_number":41,"context_line":"        \u0027td\u003ediv\u003ea[data-toggle\u003d\"dropdown\"]\u0027)"},{"line_number":42,"context_line":"    _secgroup_edit_button_template_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":43,"context_line":"        \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"] \u003etd\u003ediv\u003eul\u003eli\u003ea\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, driver, conf):"},{"line_number":46,"context_line":"        super(SecurityGroupPage, self).__init__(driver, conf)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_b3e2172d","line":43,"updated":"2014-09-03 08:09:44.000000000","message":"remove whitespace       \n\"%s\"] \u003etd\u003ediv\u003e   ----\u003e    \"%s\"]\u003etd\u003ediv\u003e\n    but is not critical :)","commit_id":"98a97c9d23697ef0bc417f940126bbbf31eda29e"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"27f59f8ad93494f617c24d9e99c447a52050bfcd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def secgroup_edit(self):"},{"line_number":79,"context_line":"        return self.get_element(*self.secgroup_edit_button_locator)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_secgroup_status(self, secgroup_name, secgroup_desc):"},{"line_number":82,"context_line":"        secgroup_locator \u003d (self._secgroup_template_locator[0],"},{"line_number":83,"context_line":"                            self._secgroup_template_locator[1] % secgroup_name)"},{"line_number":84,"context_line":"        if self.is_element_present(*secgroup_locator):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_014d223e","line":81,"updated":"2014-09-04 07:27:43.000000000","message":"IMO that\u0027s a bad choice of name for this method because:\n\na. there is no status column in the security groups table.\n\nb. you return a boolean value.\n\nI would suggest changing it to something like:\n\ndef is_secgroup_present(self, name):\n    return bool(self._get_secgroup_row(name, desc))","commit_id":"98a97c9d23697ef0bc417f940126bbbf31eda29e"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"27f59f8ad93494f617c24d9e99c447a52050bfcd","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def create_secgroup(self, secgroup_name, secgroup_desc):"},{"line_number":91,"context_line":"        self.secgroup_create.click()"},{"line_number":92,"context_line":"        self.secgroup_name_field.send_keys(secgroup_name)"},{"line_number":93,"context_line":"        self.secgroup_desc_field.send_keys(secgroup_desc)"},{"line_number":94,"context_line":"        self.secgroup_submit_button.click()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def update_secgroup(self, secgroup_name, secgroup_desc):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_817bd2f3","line":93,"updated":"2014-09-04 07:27:43.000000000","message":"please use \"fill_field_element\" from pageobject.py instead of \"send_keys\"","commit_id":"98a97c9d23697ef0bc417f940126bbbf31eda29e"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"27f59f8ad93494f617c24d9e99c447a52050bfcd","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.secgroup_desc_field.send_keys(secgroup_desc)"},{"line_number":94,"context_line":"        self.secgroup_submit_button.click()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def update_secgroup(self, secgroup_name, secgroup_desc):"},{"line_number":97,"context_line":"        self.secgroup_more_dropdown_locator \u003d ("},{"line_number":98,"context_line":"            self._secgroup_more_dropdown_template_locator[0],"},{"line_number":99,"context_line":"            self._secgroup_more_dropdown_template_locator[1] % secgroup_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_01d0c21d","line":96,"updated":"2014-09-04 07:27:43.000000000","message":"there was a change in the table and now the term is \"Edit Security Group\"","commit_id":"98a97c9d23697ef0bc417f940126bbbf31eda29e"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"4800c3b0afd06b26d5d2e3bdddb6f28d929552b6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    def update_secgroup(self, secgroup_name, secgroup_desc):"},{"line_number":97,"context_line":"        self.secgroup_more_dropdown_locator \u003d ("},{"line_number":98,"context_line":"            self._secgroup_more_dropdown_template_locator[0],"},{"line_number":99,"context_line":"            self._secgroup_more_dropdown_template_locator[1] % secgroup_name)"},{"line_number":100,"context_line":"        self.secgroup_more_dropdown_menu.click()"},{"line_number":101,"context_line":"        self.secgroup_edit_button_locator \u003d ("},{"line_number":102,"context_line":"            self._secgroup_edit_button_template_locator[0],"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_73c98f58","line":99,"updated":"2014-09-03 08:09:44.000000000","message":"self.secgroup_more_dropdown_locator \u003d (\n        self._secgroup_more_dropdown_template_locator[0],\n\tself._secgroup_more_dropdown_template_locator[1] % secgroup_name\n)\n\n\nand for code below....","commit_id":"98a97c9d23697ef0bc417f940126bbbf31eda29e"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"27f59f8ad93494f617c24d9e99c447a52050bfcd","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self._secgroup_edit_button_template_locator[1] % secgroup_name)"},{"line_number":104,"context_line":"        self.secgroup_edit.click()"},{"line_number":105,"context_line":"        self.secgroup_desc_field.clear()"},{"line_number":106,"context_line":"        self.secgroup_desc_field.send_keys(secgroup_desc)"},{"line_number":107,"context_line":"        self.secgroup_submit_button.click()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def delete_secgroup(self, secgroup_name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_016fe22b","line":106,"updated":"2014-09-04 07:27:43.000000000","message":"\"fill_field_element\" includes clearing the text in the field before sending the new one.","commit_id":"98a97c9d23697ef0bc417f940126bbbf31eda29e"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"005e1711e4df6442a21515581a00df245a66a3db","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    _secgroup_delete_cnf_button_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":32,"context_line":"                                           \u0027.btn.btn-primary\u0027)"},{"line_number":33,"context_line":"    _secgroup_template_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":34,"context_line":"        \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u0027)"},{"line_number":35,"context_line":"    _secgroup_delete_check_template_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":36,"context_line":"        \u0027#security_groups\u003etbody\u003etr[data-display\u003d\"%s\"]\u0027"},{"line_number":37,"context_line":"        \u0027\u003etd[class\u003d\"multi_select_column\"]\u003e\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_76291d89","line":34,"updated":"2014-11-18 08:22:44.000000000","message":"the gate didn\u0027t fail on it, but there\u0027s a pep 8 problem with the under-indentation of these lines (this locator and all the ones below)","commit_id":"9320cd8f8dbcb4f150daf74c6ed529f8f7c1a539"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"005e1711e4df6442a21515581a00df245a66a3db","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @property"},{"line_number":54,"context_line":"    def secgroup_create(self):"},{"line_number":55,"context_line":"        return self.get_element(*self._secgroup_create_button_locator)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @property"},{"line_number":58,"context_line":"    def secgroup_name_field(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_1b764206","line":55,"updated":"2014-11-18 08:22:44.000000000","message":"should be self._get_element(...)\ngoes for all uses of get_element() in this page","commit_id":"9320cd8f8dbcb4f150daf74c6ed529f8f7c1a539"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"005e1711e4df6442a21515581a00df245a66a3db","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    def is_secgroup_present(self, secgroup_name, secgroup_desc):"},{"line_number":90,"context_line":"        secgroup_locator \u003d (self._secgroup_template_locator[0],"},{"line_number":91,"context_line":"                            self._secgroup_template_locator[1] % secgroup_name)"},{"line_number":92,"context_line":"        if self.is_element_present(*secgroup_locator):"},{"line_number":93,"context_line":"            text_content \u003d self.get_element(*secgroup_locator).text.split()"},{"line_number":94,"context_line":"            if secgroup_desc in text_content:"},{"line_number":95,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_bb5c4e7e","line":92,"updated":"2014-11-18 08:22:44.000000000","message":"self._is_element_present()","commit_id":"9320cd8f8dbcb4f150daf74c6ed529f8f7c1a539"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"005e1711e4df6442a21515581a00df245a66a3db","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def create_secgroup(self, secgroup_name, secgroup_desc):"},{"line_number":99,"context_line":"        self.secgroup_create.click()"},{"line_number":100,"context_line":"        self.fill_field_element(secgroup_name, self.secgroup_name_field)"},{"line_number":101,"context_line":"        self.fill_field_element(secgroup_desc, self.secgroup_desc_field)"},{"line_number":102,"context_line":"        self.secgroup_submit_button.click()"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_3b485eb2","line":100,"updated":"2014-11-18 08:22:44.000000000","message":"self._fill_field_element()","commit_id":"9320cd8f8dbcb4f150daf74c6ed529f8f7c1a539"}],"openstack_dashboard/test/integration_tests/tests/test_securitygroup.py":[{"author":{"_account_id":1795,"name":"Ravikumar Venkatesan","email":"ravikumar.venkatesan@hpe.com","username":"ravikumar-venkatesan"},"change_message_id":"bf9a45321a8fa385a5fd91540663906b4c5f64d2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            self.SECGROUP_NAME, self.SECGROUP_DESC)"},{"line_number":30,"context_line":"        secgroup_status \u003d secgroup_page.is_element_present("},{"line_number":31,"context_line":"            *self.secgroup_check_locator)"},{"line_number":32,"context_line":"        self.assertTrue(secgroup_status)"},{"line_number":33,"context_line":"        self.secgroup_check_locator \u003d secgroup_page.delete_secgroup("},{"line_number":34,"context_line":"            self.SECGROUP_NAME)"},{"line_number":35,"context_line":"        secgroup_status \u003d secgroup_page.is_element_present("}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_dbe560a5","line":32,"updated":"2014-07-22 19:09:19.000000000","message":"Have update secgroup - with  description update and check secgroup is updated","commit_id":"2c25f7be84c583ef994c72831ad52980cb194019"},{"author":{"_account_id":10185,"name":"Sunil Mamillapalli","email":"sunil_mamillapalli@persistent.co.in","username":"sunil-mamillapalli"},"change_message_id":"a0e9c2d59aca6c2cc2cb58ee1a8901c1053530b3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            self.SECGROUP_NAME, self.SECGROUP_DESC)"},{"line_number":30,"context_line":"        secgroup_status \u003d secgroup_page.is_element_present("},{"line_number":31,"context_line":"            *self.secgroup_check_locator)"},{"line_number":32,"context_line":"        self.assertTrue(secgroup_status)"},{"line_number":33,"context_line":"        self.secgroup_check_locator \u003d secgroup_page.delete_secgroup("},{"line_number":34,"context_line":"            self.SECGROUP_NAME)"},{"line_number":35,"context_line":"        secgroup_status \u003d secgroup_page.is_element_present("}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_ca13e563","line":32,"in_reply_to":"baada198_dbe560a5","updated":"2014-07-29 12:03:27.000000000","message":"Done","commit_id":"2c25f7be84c583ef994c72831ad52980cb194019"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"88fbba4210b9aadfc3b66e98302b15e791088500","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        accesssecurity_page \u003d self.home_pg.go_to_accesssecurity_page()"},{"line_number":28,"context_line":"        secgroup_page \u003d accesssecurity_page.go_to_securitygroup_page()"},{"line_number":29,"context_line":"        self.secgroup_check_locator \u003d secgroup_page.create_secgroup("},{"line_number":30,"context_line":"            self.SECGROUP_NAME, self.SECGROUP_DESC)"},{"line_number":31,"context_line":"        secgroup_status \u003d secgroup_page.is_element_present("},{"line_number":32,"context_line":"            *self.secgroup_check_locator)"},{"line_number":33,"context_line":"        self.assertTrue(secgroup_status)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_46a5de9d","line":30,"updated":"2014-07-30 14:03:59.000000000","message":"web driver or locators should not be accessed via test code... create service in page object","commit_id":"26edec511641d3f2f2fed2fc4e4471d7988f2e69"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"88fbba4210b9aadfc3b66e98302b15e791088500","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            *self.secgroup_check_locator)"},{"line_number":33,"context_line":"        self.assertTrue(secgroup_status)"},{"line_number":34,"context_line":"        self.secgroup_check_locator \u003d secgroup_page.update_secgroup("},{"line_number":35,"context_line":"            self.SECGROUP_NAME, self.SECGROUP_NEW_DESC)"},{"line_number":36,"context_line":"        secgroup_status \u003d secgroup_page.is_element_present("},{"line_number":37,"context_line":"            *self.secgroup_check_locator)"},{"line_number":38,"context_line":"        self.assertTrue(secgroup_status)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_06c20635","line":35,"updated":"2014-07-30 14:03:59.000000000","message":"again...","commit_id":"26edec511641d3f2f2fed2fc4e4471d7988f2e69"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"0fcc53fd23b6f18832e62cfa39a41fc656897257","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class TestSecurityGroup(helpers.TestCase):"},{"line_number":21,"context_line":"    \"\"\"checks the user is able to create/edit/delete securitygroup.\"\"\""},{"line_number":22,"context_line":"    SECGROUP_NAME \u003d \u0027horizonsecgroup\u0027 + str(random.randint(0, 1000))"},{"line_number":23,"context_line":"    SECGROUP_DESC \u003d \u0027secgroupdesc\u0027 + str(random.randint(0, 1000))"},{"line_number":24,"context_line":"    SECGROUP_NEW_DESC \u003d \u0027secgroupupdateddesc\u0027 + str(random.randint(0, 1000))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa7fdbe_6a55761c","line":21,"updated":"2014-10-20 20:04:41.000000000","message":"Is it really necessary to use random here?  I don\u0027t think we\u0027re gaining anything by its use.","commit_id":"9320cd8f8dbcb4f150daf74c6ed529f8f7c1a539"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"b99b6632e96334d758d5b3ade64acca30e5bb830","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class TestSecurityGroup(helpers.TestCase):"},{"line_number":21,"context_line":"    \"\"\"checks the user is able to create/edit/delete securitygroup.\"\"\""},{"line_number":22,"context_line":"    SECGROUP_NAME \u003d \u0027horizonsecgroup\u0027 + str(random.randint(0, 1000))"},{"line_number":23,"context_line":"    SECGROUP_DESC \u003d \u0027secgroupdesc\u0027 + str(random.randint(0, 1000))"},{"line_number":24,"context_line":"    SECGROUP_NEW_DESC \u003d \u0027secgroupupdateddesc\u0027 + str(random.randint(0, 1000))"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_a66761e9","line":22,"updated":"2014-11-20 19:54:48.000000000","message":"I\u0027m bit confused about the use of random here.  If we are trying to prevent collisions in parallel test runs it seems like picking a bigger space would be helpful.","commit_id":"977aabb15c2776d4bf845c38335ee5685a14d159"},{"author":{"_account_id":10185,"name":"Sunil Mamillapalli","email":"sunil_mamillapalli@persistent.co.in","username":"sunil-mamillapalli"},"change_message_id":"032650d9128d831fc029113c8bf6df96e310afd2","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class TestSecurityGroup(helpers.TestCase):"},{"line_number":21,"context_line":"    \"\"\"checks the user is able to create/edit/delete securitygroup.\"\"\""},{"line_number":22,"context_line":"    SECGROUP_NAME \u003d \u0027horizonsecgroup\u0027 + str(random.randint(0, 1000))"},{"line_number":23,"context_line":"    SECGROUP_DESC \u003d \u0027secgroupdesc\u0027 + str(random.randint(0, 1000))"},{"line_number":24,"context_line":"    SECGROUP_NEW_DESC \u003d \u0027secgroupupdateddesc\u0027 + str(random.randint(0, 1000))"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_e0ca1a19","line":22,"in_reply_to":"5a890539_a66761e9","updated":"2014-11-21 10:21:44.000000000","message":"Done","commit_id":"977aabb15c2776d4bf845c38335ee5685a14d159"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"b99b6632e96334d758d5b3ade64acca30e5bb830","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class TestSecurityGroup(helpers.TestCase):"},{"line_number":21,"context_line":"    \"\"\"checks the user is able to create/edit/delete securitygroup.\"\"\""},{"line_number":22,"context_line":"    SECGROUP_NAME \u003d \u0027horizonsecgroup\u0027 + str(random.randint(0, 1000))"},{"line_number":23,"context_line":"    SECGROUP_DESC \u003d \u0027secgroupdesc\u0027 + str(random.randint(0, 1000))"},{"line_number":24,"context_line":"    SECGROUP_NEW_DESC \u003d \u0027secgroupupdateddesc\u0027 + str(random.randint(0, 1000))"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_secgroup(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_c61aad17","line":23,"updated":"2014-11-20 19:54:48.000000000","message":"I\u0027m even less certain of the use of random here.  What\u0027s up?","commit_id":"977aabb15c2776d4bf845c38335ee5685a14d159"},{"author":{"_account_id":10185,"name":"Sunil Mamillapalli","email":"sunil_mamillapalli@persistent.co.in","username":"sunil-mamillapalli"},"change_message_id":"032650d9128d831fc029113c8bf6df96e310afd2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class TestSecurityGroup(helpers.TestCase):"},{"line_number":21,"context_line":"    \"\"\"checks the user is able to create/edit/delete securitygroup.\"\"\""},{"line_number":22,"context_line":"    SECGROUP_NAME \u003d \u0027horizonsecgroup\u0027 + str(random.randint(0, 1000))"},{"line_number":23,"context_line":"    SECGROUP_DESC \u003d \u0027secgroupdesc\u0027 + str(random.randint(0, 1000))"},{"line_number":24,"context_line":"    SECGROUP_NEW_DESC \u003d \u0027secgroupupdateddesc\u0027 + str(random.randint(0, 1000))"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_secgroup(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_00d2c6d1","line":23,"in_reply_to":"5a890539_c61aad17","updated":"2014-11-21 10:21:44.000000000","message":"Done","commit_id":"977aabb15c2776d4bf845c38335ee5685a14d159"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"9c09552497677f5deec1212111c03e844953199a","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class TestSecurityGroup(helpers.TestCase):"},{"line_number":21,"context_line":"    \"\"\"checks the user is able to create/edit/delete securitygroup.\"\"\""},{"line_number":22,"context_line":"    SECGROUP_NAME \u003d \u0027horizon_secgroup\u0027 + str(random.randint(0, 100000))"},{"line_number":23,"context_line":"    SECGROUP_DESC \u003d \u0027secgroup_desc_for_\u0027 + SECGROUP_NAME"},{"line_number":24,"context_line":"    SECGROUP_NEW_DESC \u003d \u0027secgroup_updated_desc_for_\u0027 + SECGROUP_NAME"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_49c1fb7e","line":22,"updated":"2014-11-25 18:36:03.000000000","message":"now THAT is a random number!  Looks good, thanks!","commit_id":"db20e79988dd0ff3f49447b687780a98a40ae225"}]}
