)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"8f487c2c6a890dbb7c711e0921866862204aa101","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0203bbaf_059e1b18","updated":"2026-08-17 07:49:04.000000000","message":"This doesn\u0027t actually install the package yet. I built a wheel from this\ncommit and it contains no Python code at all -- only dist-info metadata:\n\n  openstacki18n-0.0.1.dev541.dist-info/{METADATA,WHEEL,pbr.json,top_level.txt}\n\nThe cause is that setup.cfg has no [files] packages entry. pbr falls back to\nthe distribution name as the package dir (pbr/hooks/files.py:115,\n`packages \u003d self.config.get(\u0027packages\u0027, self.name)`), and since the dist name\nis \"openstacki18n\" while the dir is \"os_i18n_client\", the isdir() check fails\nand packages ends up empty.\n\nAdding this to setup.cfg fixes it (verified -- smart_find_packages picks up\napi/, common/, tests/ and weblate/ automatically):\n\n  [files]\n  packages \u003d\n      os_i18n_client\n\nTwo reasons this is easy to miss: `import os_i18n_client` succeeds from the\nrepo root because cwd is on sys.path, and no gate job installs the package\n(pep8 uses skip_install \u003d true, and there is no unit test job).\n\nA few more things:\n\n- No console_scripts entry point, so `os-i18n-client` is not created on\n  install. The `if __name__ \u003d\u003d \"__main__\": pass` in shell.py is dead code\n  under the entry-point model -- could we add a main() stub plus\n  `os-i18n-client \u003d os_i18n_client.shell:main` so the skeleton is runnable?\n  \n- tests/__init__.py is added but there is no py3 testenv, no .stestr.conf, no\n  stestr/testtools in test-requirements.txt and no unit test job in\n  .zuul.yaml, so nothing under tests/ can ever run. Adding a unit test job\n  would also have caught the packaging issue above.\n  \n- Distribution story: the dist name stays \"openstacki18n\", so\n  `pip install os-i18n-client` will never work (not on PyPI), and this repo\n  has no release jobs. Is the plan to ship the client inside the i18n docs\n  repo, or to move it to its own deliverable? Worth settling now.\n\n- os_i18n_client/weblate/ overlaps with the existing tools/weblate/*.py\n  scripts. Could the commit message say whether those are being absorbed and\n  in what order? (Note wlc is still not declared in requirements.txt.)\n  \n- Nit: README.rst line 5 -- \"operationsin\" -\u003e \"operations in\"; the line is\n  87 chars. Also, a README inside the package dir ships as package data and\n  is not covered by doc8 (which only checks doc/source and glossary) --\n  doc/source/ might be a better home.","commit_id":"40542335a4791f97f2dcf65ad5a2e11a79a5bc49"}]}