)]}'
{"tools/zanata/zanata_users.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63806a3f9d20658bed2264d905ab78d24c0ca075","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import argparse"},{"line_number":17,"context_line":"from bs4 import BeautifulSoup as Soup"},{"line_number":18,"context_line":"from collections import OrderedDict"},{"line_number":19,"context_line":"import random"},{"line_number":20,"context_line":"import requests"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_b3bf09fb","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":37},"updated":"2017-01-11 12:50:24.000000000","message":"We use module-level import in OpenStack world.\n\n  import bs4\n\nand replace Soup with bs4.BeautifulSoup","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f7e77368f0a4753af9b1ac73fa9c71a5979bc36","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import argparse"},{"line_number":17,"context_line":"from bs4 import BeautifulSoup as Soup"},{"line_number":18,"context_line":"from collections import OrderedDict"},{"line_number":19,"context_line":"import random"},{"line_number":20,"context_line":"import requests"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_0e40d5a4","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":37},"in_reply_to":"7a3c09a3_069fe7b4","updated":"2017-01-16 03:46:43.000000000","message":"Currently i18n repo does not use requirements.txt. We have several number of scripts now, so I think it is time to introduce requirements.txt. I can take care of it later. In this patch you don\u0027t need to add requirements.txt and some comment in this file would be enough.","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"41be25c48c2b706488672be6f6ba6f79e6762501","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import argparse"},{"line_number":17,"context_line":"from bs4 import BeautifulSoup as Soup"},{"line_number":18,"context_line":"from collections import OrderedDict"},{"line_number":19,"context_line":"import random"},{"line_number":20,"context_line":"import requests"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_c6c07f2d","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":37},"in_reply_to":"ba5201f7_b3bf09fb","updated":"2017-01-15 08:09:49.000000000","message":"Done","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"2cdcb688f8abb83e06d2b24a97396961f3f1eb82","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import argparse"},{"line_number":17,"context_line":"from bs4 import BeautifulSoup as Soup"},{"line_number":18,"context_line":"from collections import OrderedDict"},{"line_number":19,"context_line":"import random"},{"line_number":20,"context_line":"import requests"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_069fe7b4","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":37},"in_reply_to":"ba5201f7_b3bf09fb","updated":"2017-01-15 07:10:48.000000000","message":"Thanks. Where should I put this requirements module? There are no requirements.txt in this repository.","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63806a3f9d20658bed2264d905ab78d24c0ca075","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from collections import OrderedDict"},{"line_number":19,"context_line":"import random"},{"line_number":20,"context_line":"import requests"},{"line_number":21,"context_line":"import yaml"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"base_url \u003d \"https://translate.openstack.org/%s\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_8070eddd","line":21,"updated":"2017-01-11 12:50:24.000000000","message":"Please follow the OpenStack hacking convention.\n\nhttp://docs.openstack.org/developer/hacking/#imports","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"2cdcb688f8abb83e06d2b24a97396961f3f1eb82","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from collections import OrderedDict"},{"line_number":19,"context_line":"import random"},{"line_number":20,"context_line":"import requests"},{"line_number":21,"context_line":"import yaml"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"base_url \u003d \"https://translate.openstack.org/%s\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_46a9efde","line":21,"in_reply_to":"ba5201f7_8070eddd","updated":"2017-01-15 07:10:48.000000000","message":"Thank you for your help.","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63806a3f9d20658bed2264d905ab78d24c0ca075","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            req \u003d requests.get(url\u003duri, headers\u003dheaders)"},{"line_number":42,"context_line":"            return req.text"},{"line_number":43,"context_line":"        except Exception as e:"},{"line_number":44,"context_line":"            print(\u0027exception happen\u0027, e)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def iter_language_members(self, uri):"},{"line_number":47,"context_line":"        data \u003d self.read_uri(base_url % uri)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_3350790a","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":40},"updated":"2017-01-11 12:50:24.000000000","message":"This means the logic continues even when an exception occurs.\nThis is not a good idea. It is better to stop the logic by raising an exception (or exit the script) here.","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"41be25c48c2b706488672be6f6ba6f79e6762501","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            req \u003d requests.get(url\u003duri, headers\u003dheaders)"},{"line_number":42,"context_line":"            return req.text"},{"line_number":43,"context_line":"        except Exception as e:"},{"line_number":44,"context_line":"            print(\u0027exception happen\u0027, e)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def iter_language_members(self, uri):"},{"line_number":47,"context_line":"        data \u003d self.read_uri(base_url % uri)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_e6dd7b15","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":40},"in_reply_to":"ba5201f7_3350790a","updated":"2017-01-15 08:09:49.000000000","message":"Done","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"2cdcb688f8abb83e06d2b24a97396961f3f1eb82","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            req \u003d requests.get(url\u003duri, headers\u003dheaders)"},{"line_number":42,"context_line":"            return req.text"},{"line_number":43,"context_line":"        except Exception as e:"},{"line_number":44,"context_line":"            print(\u0027exception happen\u0027, e)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def iter_language_members(self, uri):"},{"line_number":47,"context_line":"        data \u003d self.read_uri(base_url % uri)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_66b0ab44","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":40},"in_reply_to":"ba5201f7_3350790a","updated":"2017-01-15 07:10:48.000000000","message":"OK. I will fix this in next patch.","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63806a3f9d20658bed2264d905ab78d24c0ca075","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def get_languages(self):"},{"line_number":67,"context_line":"        data \u003d self.read_uri(base_url % \u0027language/list\u0027)"},{"line_number":68,"context_line":"        soup \u003d Soup(data, \u0027html.parser\u0027)"},{"line_number":69,"context_line":"        languages \u003d dict()"},{"line_number":70,"context_line":"        ul \u003d soup.find(\u0027ul\u0027, {\u0027class\u0027: \u0027list--stats\u0027}).findAll(\u0027li\u0027)"},{"line_number":71,"context_line":"        for li in ul:"},{"line_number":72,"context_line":"            lang_tag \u003d li.find(\u0027h3\u0027, {\u0027class\u0027: \u0027list__title\u0027}).text"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_530fbde0","line":69,"range":{"start_line":69,"start_character":20,"end_line":69,"end_character":26},"updated":"2017-01-11 12:50:24.000000000","message":"-\u003e {}","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"41be25c48c2b706488672be6f6ba6f79e6762501","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def get_languages(self):"},{"line_number":67,"context_line":"        data \u003d self.read_uri(base_url % \u0027language/list\u0027)"},{"line_number":68,"context_line":"        soup \u003d Soup(data, \u0027html.parser\u0027)"},{"line_number":69,"context_line":"        languages \u003d dict()"},{"line_number":70,"context_line":"        ul \u003d soup.find(\u0027ul\u0027, {\u0027class\u0027: \u0027list--stats\u0027}).findAll(\u0027li\u0027)"},{"line_number":71,"context_line":"        for li in ul:"},{"line_number":72,"context_line":"            lang_tag \u003d li.find(\u0027h3\u0027, {\u0027class\u0027: \u0027list__title\u0027}).text"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_06e1a7d0","line":69,"range":{"start_line":69,"start_character":20,"end_line":69,"end_character":26},"in_reply_to":"ba5201f7_530fbde0","updated":"2017-01-15 08:09:49.000000000","message":"Done","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"2cdcb688f8abb83e06d2b24a97396961f3f1eb82","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def get_languages(self):"},{"line_number":67,"context_line":"        data \u003d self.read_uri(base_url % \u0027language/list\u0027)"},{"line_number":68,"context_line":"        soup \u003d Soup(data, \u0027html.parser\u0027)"},{"line_number":69,"context_line":"        languages \u003d dict()"},{"line_number":70,"context_line":"        ul \u003d soup.find(\u0027ul\u0027, {\u0027class\u0027: \u0027list--stats\u0027}).findAll(\u0027li\u0027)"},{"line_number":71,"context_line":"        for li in ul:"},{"line_number":72,"context_line":"            lang_tag \u003d li.find(\u0027h3\u0027, {\u0027class\u0027: \u0027list__title\u0027}).text"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_86abd7d5","line":69,"range":{"start_line":69,"start_character":20,"end_line":69,"end_character":26},"in_reply_to":"ba5201f7_530fbde0","updated":"2017-01-15 07:10:48.000000000","message":"OK","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63806a3f9d20658bed2264d905ab78d24c0ca075","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                      default_flow_style\u003dFalse)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def change_role_name(role):"},{"line_number":104,"context_line":"    roles \u003d {"},{"line_number":105,"context_line":"        \u0027Translator\u0027: \u0027translators\u0027,"},{"line_number":106,"context_line":"        \u0027Reviewer\u0027: \u0027reviewers\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_d3e72d3e","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":20},"updated":"2017-01-11 12:50:24.000000000","message":"nit: my vote is \u0027convet_role_name\u0027","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"41be25c48c2b706488672be6f6ba6f79e6762501","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                      default_flow_style\u003dFalse)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def change_role_name(role):"},{"line_number":104,"context_line":"    roles \u003d {"},{"line_number":105,"context_line":"        \u0027Translator\u0027: \u0027translators\u0027,"},{"line_number":106,"context_line":"        \u0027Reviewer\u0027: \u0027reviewers\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_26e863b4","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":20},"in_reply_to":"ba5201f7_d3e72d3e","updated":"2017-01-15 08:09:49.000000000","message":"Done","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"2cdcb688f8abb83e06d2b24a97396961f3f1eb82","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                      default_flow_style\u003dFalse)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def change_role_name(role):"},{"line_number":104,"context_line":"    roles \u003d {"},{"line_number":105,"context_line":"        \u0027Translator\u0027: \u0027translators\u0027,"},{"line_number":106,"context_line":"        \u0027Reviewer\u0027: \u0027reviewers\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_a6ba9321","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":20},"in_reply_to":"ba5201f7_d3e72d3e","updated":"2017-01-15 07:10:48.000000000","message":"I agree with you. I will fix this in next patch.","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63806a3f9d20658bed2264d905ab78d24c0ca075","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                              \"Default: translation_team.yaml\"))"},{"line_number":140,"context_line":"    options \u003d parser.parse_args()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    output_file \u003d (options.output_file or \u0027translation_team.yaml\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    data \u003d collect_zanata_language_and_members()"},{"line_number":145,"context_line":"    save_to_yaml(data, output_file)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_60122964","line":142,"range":{"start_line":142,"start_character":4,"end_line":142,"end_character":66},"updated":"2017-01-11 12:50:24.000000000","message":"Instead of this, add the following to add_argument() above.\n\n  default\u003d\u0027translation_team.yaml\u0027","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"41be25c48c2b706488672be6f6ba6f79e6762501","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                              \"Default: translation_team.yaml\"))"},{"line_number":140,"context_line":"    options \u003d parser.parse_args()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    output_file \u003d (options.output_file or \u0027translation_team.yaml\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    data \u003d collect_zanata_language_and_members()"},{"line_number":145,"context_line":"    save_to_yaml(data, output_file)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_46ebafb0","line":142,"range":{"start_line":142,"start_character":4,"end_line":142,"end_character":66},"in_reply_to":"ba5201f7_60122964","updated":"2017-01-15 08:09:49.000000000","message":"Done","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"2cdcb688f8abb83e06d2b24a97396961f3f1eb82","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                              \"Default: translation_team.yaml\"))"},{"line_number":140,"context_line":"    options \u003d parser.parse_args()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    output_file \u003d (options.output_file or \u0027translation_team.yaml\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    data \u003d collect_zanata_language_and_members()"},{"line_number":145,"context_line":"    save_to_yaml(data, output_file)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_e682db51","line":142,"range":{"start_line":142,"start_character":4,"end_line":142,"end_character":66},"in_reply_to":"ba5201f7_60122964","updated":"2017-01-15 07:10:48.000000000","message":"OK.","commit_id":"f9f32683c63919838d2a6cc5abb679f87b8a9cdd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3cea11bf08e6e97e0f29c744775e8fb4f5bd8bda","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        headers \u003d {"},{"line_number":39,"context_line":"            \u0027User-Agent\u0027: random.choice(ZanataUtility.user_agents)"},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            req \u003d requests.get(url\u003duri, headers\u003dheaders)"},{"line_number":43,"context_line":"            return req.text"},{"line_number":44,"context_line":"        except Exception as e:"},{"line_number":45,"context_line":"            raise e"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def iter_language_members(self, uri):"},{"line_number":48,"context_line":"        data \u003d self.read_uri(base_url % uri)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_e89c615f","line":45,"range":{"start_line":41,"start_character":8,"end_line":45,"end_character":19},"updated":"2017-01-16 02:03:26.000000000","message":"If you just re-raise an exception here, there is no need to use try/except.","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"b8f7215d8f3ffb073df524ed3de950ebbc15a889","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        headers \u003d {"},{"line_number":39,"context_line":"            \u0027User-Agent\u0027: random.choice(ZanataUtility.user_agents)"},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            req \u003d requests.get(url\u003duri, headers\u003dheaders)"},{"line_number":43,"context_line":"            return req.text"},{"line_number":44,"context_line":"        except Exception as e:"},{"line_number":45,"context_line":"            raise e"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def iter_language_members(self, uri):"},{"line_number":48,"context_line":"        data \u003d self.read_uri(base_url % uri)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_f1ab5bd4","line":45,"range":{"start_line":41,"start_character":8,"end_line":45,"end_character":19},"in_reply_to":"7a3c09a3_e89c615f","updated":"2017-01-16 12:04:10.000000000","message":"Thanks. I remove try/except next patch","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"83dacab86d22597594be0aa0061985f23f7d19d5","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def collect_zanata_language_and_members():"},{"line_number":114,"context_line":"    zanata \u003d ZanataUtility()"},{"line_number":115,"context_line":"    languages \u003d zanata.get_languages()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    for language in languages.keys():"},{"line_number":118,"context_line":"        member_url \u003d languages[language][\u0027member_url\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_46872fd7","line":115,"range":{"start_line":114,"start_character":28,"end_line":115,"end_character":4},"updated":"2017-01-15 08:49:11.000000000","message":"It would be better to print \u0027Retrieving language list\u0027 between those two lines.","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"b8f7215d8f3ffb073df524ed3de950ebbc15a889","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def collect_zanata_language_and_members():"},{"line_number":114,"context_line":"    zanata \u003d ZanataUtility()"},{"line_number":115,"context_line":"    languages \u003d zanata.get_languages()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    for language in languages.keys():"},{"line_number":118,"context_line":"        member_url \u003d languages[language][\u0027member_url\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_71868b66","line":115,"range":{"start_line":114,"start_character":28,"end_line":115,"end_character":4},"in_reply_to":"7a3c09a3_46872fd7","updated":"2017-01-16 12:04:10.000000000","message":"OK","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3cea11bf08e6e97e0f29c744775e8fb4f5bd8bda","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    languages \u003d zanata.get_languages()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    for language in languages.keys():"},{"line_number":118,"context_line":"        member_url \u003d languages[language][\u0027member_url\u0027]"},{"line_number":119,"context_line":"        for role, user_id in zanata.iter_language_members(member_url):"},{"line_number":120,"context_line":"            role \u003d convert_role_name(role)"},{"line_number":121,"context_line":"            if role is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_48c5753a","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":54},"updated":"2017-01-16 02:03:26.000000000","message":"Consider using pop() method\n\n  member_url \u003d languages[language].pop(\u0027member_url\u0027)","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"b8f7215d8f3ffb073df524ed3de950ebbc15a889","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    languages \u003d zanata.get_languages()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    for language in languages.keys():"},{"line_number":118,"context_line":"        member_url \u003d languages[language][\u0027member_url\u0027]"},{"line_number":119,"context_line":"        for role, user_id in zanata.iter_language_members(member_url):"},{"line_number":120,"context_line":"            role \u003d convert_role_name(role)"},{"line_number":121,"context_line":"            if role is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_917db770","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":54},"in_reply_to":"7a3c09a3_48c5753a","updated":"2017-01-16 12:04:10.000000000","message":"That would be better. Thanks","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"83dacab86d22597594be0aa0061985f23f7d19d5","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    languages \u003d zanata.get_languages()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    for language in languages.keys():"},{"line_number":118,"context_line":"        member_url \u003d languages[language][\u0027member_url\u0027]"},{"line_number":119,"context_line":"        for role, user_id in zanata.iter_language_members(member_url):"},{"line_number":120,"context_line":"            role \u003d convert_role_name(role)"},{"line_number":121,"context_line":"            if role is None:"},{"line_number":122,"context_line":"                print(\u0027[Warn] Unknown role : %s\u0027 % role)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_a64ff3bb","line":119,"range":{"start_line":118,"start_character":54,"end_line":119,"end_character":8},"updated":"2017-01-15 08:49:11.000000000","message":"Would you also print such as \"\u0027Getting member list from language %s\u0027 % language\" ?","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"b8f7215d8f3ffb073df524ed3de950ebbc15a889","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    languages \u003d zanata.get_languages()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    for language in languages.keys():"},{"line_number":118,"context_line":"        member_url \u003d languages[language][\u0027member_url\u0027]"},{"line_number":119,"context_line":"        for role, user_id in zanata.iter_language_members(member_url):"},{"line_number":120,"context_line":"            role \u003d convert_role_name(role)"},{"line_number":121,"context_line":"            if role is None:"},{"line_number":122,"context_line":"                print(\u0027[Warn] Unknown role : %s\u0027 % role)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_1192a79e","line":119,"range":{"start_line":118,"start_character":54,"end_line":119,"end_character":8},"in_reply_to":"7a3c09a3_a64ff3bb","updated":"2017-01-16 12:04:10.000000000","message":"Ok","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3cea11bf08e6e97e0f29c744775e8fb4f5bd8bda","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            if role not in languages[language]:"},{"line_number":126,"context_line":"                languages[language][role] \u003d list()"},{"line_number":127,"context_line":"            languages[language][role].append(user_id)"},{"line_number":128,"context_line":"        del languages[language][\u0027member_url\u0027]"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    sorted_key \u003d sorted(languages, reverse\u003dTrue,"},{"line_number":131,"context_line":"                        key\u003dlambda k: len(languages[k][\u0027translators\u0027]))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_c8e7a5e2","line":128,"updated":"2017-01-16 02:03:26.000000000","message":"If you use pop() at L.118, this line can be removed.","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"b8f7215d8f3ffb073df524ed3de950ebbc15a889","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            if role not in languages[language]:"},{"line_number":126,"context_line":"                languages[language][role] \u003d list()"},{"line_number":127,"context_line":"            languages[language][role].append(user_id)"},{"line_number":128,"context_line":"        del languages[language][\u0027member_url\u0027]"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    sorted_key \u003d sorted(languages, reverse\u003dTrue,"},{"line_number":131,"context_line":"                        key\u003dlambda k: len(languages[k][\u0027translators\u0027]))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_71edab24","line":128,"in_reply_to":"7a3c09a3_c8e7a5e2","updated":"2017-01-16 12:04:10.000000000","message":"Thanks.","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"83dacab86d22597594be0aa0061985f23f7d19d5","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    output_file \u003d options.output_file"},{"line_number":145,"context_line":"    data \u003d collect_zanata_language_and_members()"},{"line_number":146,"context_line":"    save_to_yaml(data, output_file)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_e6c73b10","line":146,"range":{"start_line":146,"start_character":35,"end_line":146,"end_character":35},"updated":"2017-01-15 08:49:11.000000000","message":"Also, printing such as \u0027output is saved to filename: %s\u0027 % output_file would be nice :)","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"b8f7215d8f3ffb073df524ed3de950ebbc15a889","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    output_file \u003d options.output_file"},{"line_number":145,"context_line":"    data \u003d collect_zanata_language_and_members()"},{"line_number":146,"context_line":"    save_to_yaml(data, output_file)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_91f4d7f2","line":146,"range":{"start_line":146,"start_character":35,"end_line":146,"end_character":35},"in_reply_to":"7a3c09a3_e6c73b10","updated":"2017-01-16 12:04:10.000000000","message":"Ok","commit_id":"2e53de31cbe589e4a9398cb216d67e6b216b70f8"}]}
