)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"f6dee1ebb3d57d663cdbcac109e5aa71b372a2fb","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Akihiro Motoki \u003camotoki@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-11 18:54:56 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"generatepo.sh: Drop UUID filtering"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"(g)awk in Ubuntu 20.04 or later (perhaps gawk \u003e\u003d5.0) has more strict"},{"line_number":10,"context_line":"regexp check and the regexp passed to awk in generatepot.sh cannot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"43f10bf9_37287045","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":10},"updated":"2023-09-12 02:00:27.000000000","message":"minor nit: generatepot","commit_id":"26a161a979394afc0d92ee8a5b0593018c9e3fe7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c0facb546f8605c864fa64173bef44f4a1c059eb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Akihiro Motoki \u003camotoki@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-11 18:54:56 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"generatepo.sh: Drop UUID filtering"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"(g)awk in Ubuntu 20.04 or later (perhaps gawk \u003e\u003d5.0) has more strict"},{"line_number":10,"context_line":"regexp check and the regexp passed to awk in generatepot.sh cannot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d4b48c69_38f1cd54","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":10},"in_reply_to":"43f10bf9_37287045","updated":"2023-09-12 05:58:47.000000000","message":"Done","commit_id":"26a161a979394afc0d92ee8a5b0593018c9e3fe7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"f6dee1ebb3d57d663cdbcac109e5aa71b372a2fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e6f79ad_96d82eb3","updated":"2023-09-12 02:00:27.000000000","message":"Thank you while I need more investigation how UUID remove affects on other documentation like:\n\n- https://opendev.org/openstack/openstack-manuals/src/branch/master/tools/generatepot-rst.sh#L70\n- https://opendev.org/openstack/training-guides/src/branch/master/tox.ini#L35","commit_id":"26a161a979394afc0d92ee8a5b0593018c9e3fe7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c0facb546f8605c864fa64173bef44f4a1c059eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8b4b9e1f_6996e801","in_reply_to":"7e6f79ad_96d82eb3","updated":"2023-09-12 05:58:47.000000000","message":"\u003e Thank you while I need more investigation how UUID remove affects on other documentation like:\n\u003e \n\u003e - https://opendev.org/openstack/openstack-manuals/src/branch/master/tools/generatepot-rst.sh#L70\n\u003e - https://opendev.org/openstack/training-guides/src/branch/master/tox.ini#L35\n\nIan, the following is what I investigated for other doc repos.\nI believe we can drop the filtering logic from all repos safely.\n\nWhile they have similar logics, how POT generation for documents differs from repo to repo [1].\n\n* For openstack-manuals (+ api-site, security-doc), \"tox -e generatepot-rst\"\n  in openstack-manuals repo (or corresponding repos) is called from setup_manuals() [2],\n  and tools/generatepot-rst.sh has the same logic to remove UUIDs.\n* For project documents, extract_messages_doc() in common_translation_update.sh has the same logic to remove UUIDs [3].\n* For traininng-guides, \"tox -e generatepot-training\" in its repo is called similarly to the i18n repo [4].\n\nRegarding the history of this logic,\nit seems that removing UUIDs was originally introduced in openstack-manuals [5].\nThis filtering logic was copied to common_translation_update.sh extract_messages_doc() in project-config [6], i18n repo and so on.\nNote that [6] was moved to prepare-zanata-client role in openstack-zuul-jobs repo.\n\nLooking at the commit message of [5], UUID generation is disabled by default since sphinx 1.3 or later,\nbut our CI used an older version of Sphinx and we need to do it manually.\nThus, I believe the UUID filtering logic is no longer needed as it is disabled by default.\n\n[1] https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/prepare-zanata-client/files/upstream_translation_update.sh#L49\n[2] https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/prepare-zanata-client/files/common_translation_update.sh#L211\n[3] https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/prepare-zanata-client/files/common_translation_update.sh#L451\n[4] https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/prepare-zanata-client/files/common_translation_update.sh#L239\n[5] https://opendev.org/openstack/openstack-manuals/commit/993647f316fbe33a513baffb5cc4ad156355da8a\n[6] https://opendev.org/openstack/project-config/commit/de0fd555aacfe2ccaaf62bd4bfa54af25e1053d9","commit_id":"26a161a979394afc0d92ee8a5b0593018c9e3fe7"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"e6bbc17f721b2cc122c224606adde47e8936e1fb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d80b3895_2bf47255","in_reply_to":"8b4b9e1f_6996e801","updated":"2023-09-12 15:35:31.000000000","message":"Thank you for such very detailed explanation through your deep investigation! I am adding:\n\n- confirming detail on Sphinx changes with UUID through [7]\n- double-checking through simple code search like [8]\n\n\n\n[7] https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-gettext_uuid\n[8] https://opendev.org/openstack/-/code?q\u003dmsgcat\u0026t\u003d","commit_id":"26a161a979394afc0d92ee8a5b0593018c9e3fe7"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"e6bbc17f721b2cc122c224606adde47e8936e1fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0fd14ac7_96d6a281","updated":"2023-09-12 15:35:31.000000000","message":"@seongsoocho: maybe would you liaise to submit more patches on other affecting repositories by setting topic name as \"drop-uuid-filtering\" and mentioning https://bugs.launchpad.net/openstack-i18n/+bug/2035226 ?","commit_id":"1cc69e482cb0922a2770b477ca9e7e497036c315"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"83e1bf8de8581ea2fc4146c16711d606793baad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"51715ad6_e4713597","updated":"2023-10-26 16:40:55.000000000","message":"Can we merge this or do we need more reviewers?","commit_id":"1cc69e482cb0922a2770b477ca9e7e497036c315"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"af9cadf2e614ae18727667ba6390ae92bbdc0908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d906af70_8600ff18","updated":"2023-09-18 08:18:18.000000000","message":"I proposed the fix to the related repositories.\nThey uses a topic \"bug/2035226\", so I changed the topic here too.\nYou can find all related patches at https://review.opendev.org/q/topic:bug%252F2035226","commit_id":"1cc69e482cb0922a2770b477ca9e7e497036c315"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"813891da10421dbe8ad1fed436cb3323e707ef29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"549e3ddd_95dfe64e","updated":"2023-10-27 13:29:51.000000000","message":"Looks good. Thanks","commit_id":"1cc69e482cb0922a2770b477ca9e7e497036c315"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"63d979f129bdd8e5296b6a688902aa7f36a2522a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a623fc26_77dc899a","in_reply_to":"0fd14ac7_96d6a281","updated":"2023-09-16 03:20:42.000000000","message":"I will propose patches to fix it if you don\u0027t mind.","commit_id":"1cc69e482cb0922a2770b477ca9e7e497036c315"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cd67f3096a2d70c4fc81fbcba42d9358f517f3c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2b7ab1f9_4a53c52f","in_reply_to":"731bdf3f_5373b3ca","updated":"2023-09-20 00:27:28.000000000","message":"\u003e thanks, Akihiro\n\u003e \n\u003e I was needed time to analyze the history.\n\nNo problem. We have different time contraints/backgrounds/histories/experiences and so on, so we can collaborate 😊\n\nParticularly, I think this topic is one of most complicated things because the infra scripts were moved and copied many times..... While I was involved in the whole history of this topic, it is not easy to track it.","commit_id":"1cc69e482cb0922a2770b477ca9e7e497036c315"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"8eb5ba987545c521cd22752155438f4012823960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fce4d96c_4d9aa0e6","in_reply_to":"a623fc26_77dc899a","updated":"2023-09-22 16:18:24.000000000","message":"Thank you and sharing that all except this got +A so far","commit_id":"1cc69e482cb0922a2770b477ca9e7e497036c315"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"ea02ed5ed1d4a71af6d015d142bfc9b4f512707d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"731bdf3f_5373b3ca","in_reply_to":"d906af70_8600ff18","updated":"2023-09-19 23:08:20.000000000","message":"thanks, Akihiro\n\nI was needed time to analyze the history.","commit_id":"1cc69e482cb0922a2770b477ca9e7e497036c315"}],"tools/generatepot.sh":[{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"f6dee1ebb3d57d663cdbcac109e5aa71b372a2fb","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    fn\u003d$(basename $f .pot)"},{"line_number":46,"context_line":"    # If a pot file corresponds to a directory, we use the pot file as-is."},{"line_number":47,"context_line":"    if [ -d doc/source/$fn ]; then"},{"line_number":48,"context_line":"        # Remove UUIDs, those are not necessary and change too often"},{"line_number":49,"context_line":"        msgcat --use-first --sort-by-file $f \u003e doc/source/locale/doc-$fn.pot"},{"line_number":50,"context_line":"        rm $f"},{"line_number":51,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":1,"id":"e2c536df_4803e653","line":48,"range":{"start_line":48,"start_character":10,"end_line":48,"end_character":22},"updated":"2023-09-12 02:00:27.000000000","message":"\"Remove UUIDs\" comment part also might be treated","commit_id":"26a161a979394afc0d92ee8a5b0593018c9e3fe7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c0facb546f8605c864fa64173bef44f4a1c059eb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    fn\u003d$(basename $f .pot)"},{"line_number":46,"context_line":"    # If a pot file corresponds to a directory, we use the pot file as-is."},{"line_number":47,"context_line":"    if [ -d doc/source/$fn ]; then"},{"line_number":48,"context_line":"        # Remove UUIDs, those are not necessary and change too often"},{"line_number":49,"context_line":"        msgcat --use-first --sort-by-file $f \u003e doc/source/locale/doc-$fn.pot"},{"line_number":50,"context_line":"        rm $f"},{"line_number":51,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":1,"id":"aa757206_9a1ab81b","line":48,"range":{"start_line":48,"start_character":10,"end_line":48,"end_character":22},"in_reply_to":"e2c536df_4803e653","updated":"2023-09-12 05:58:47.000000000","message":"Done","commit_id":"26a161a979394afc0d92ee8a5b0593018c9e3fe7"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"f6dee1ebb3d57d663cdbcac109e5aa71b372a2fb","unresolved":true,"context_lines":[{"line_number":57,"context_line":"# \"git add ${DIRECTORY}/source/locale\" will only add a"},{"line_number":58,"context_line":"# single pot file for all top-level files."},{"line_number":59,"context_line":"if [ \"$has_other\" \u003d \"1\" ]; then"},{"line_number":60,"context_line":"    # Remove UUIDs, those are not necessary and change too often"},{"line_number":61,"context_line":"    msgcat --use-first --sort-by-file doc/build/gettext/*.pot \\"},{"line_number":62,"context_line":"        \u003e doc/source/locale/doc.pot"},{"line_number":63,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"c18e8d8f_20e9bf3a","line":60,"updated":"2023-09-12 02:00:27.000000000","message":"\"Remove UUIDs\" comment part also might be treated","commit_id":"26a161a979394afc0d92ee8a5b0593018c9e3fe7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c0facb546f8605c864fa64173bef44f4a1c059eb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# \"git add ${DIRECTORY}/source/locale\" will only add a"},{"line_number":58,"context_line":"# single pot file for all top-level files."},{"line_number":59,"context_line":"if [ \"$has_other\" \u003d \"1\" ]; then"},{"line_number":60,"context_line":"    # Remove UUIDs, those are not necessary and change too often"},{"line_number":61,"context_line":"    msgcat --use-first --sort-by-file doc/build/gettext/*.pot \\"},{"line_number":62,"context_line":"        \u003e doc/source/locale/doc.pot"},{"line_number":63,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"20ca3109_45cb7268","line":60,"in_reply_to":"c18e8d8f_20e9bf3a","updated":"2023-09-12 05:58:47.000000000","message":"Done","commit_id":"26a161a979394afc0d92ee8a5b0593018c9e3fe7"}]}