)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"7af01062e0a52cdf1bceb3ac77b3a6b109441208","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add weblate utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Weblate utils file for Zanata to Weblate migration."},{"line_number":10,"context_line":"Creating a new PR from https://review.opendev.org/c/openstack/i18n/+/893361/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #2034921"},{"line_number":13,"context_line":"Change-Id: Ie4cf861cc6ca59456c5d563d7673fbf54b3bb42f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"967126ea_9679c1f1","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":18},"updated":"2023-09-25 15:37:12.000000000","message":"In Gerrit, we are saying \"patch\", not PR.","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"7af01062e0a52cdf1bceb3ac77b3a6b109441208","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2023-09-23 20:34:46 +0900"},{"line_number":4,"context_line":"Commit:     n-y-kim \u003cnyn2265@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-23 20:34:46 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add weblate utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Weblate utils file for Zanata to Weblate migration."},{"line_number":10,"context_line":"Creating a new PR from https://review.opendev.org/c/openstack/i18n/+/893361/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #2034921"},{"line_number":13,"context_line":"Change-Id: Ie4cf861cc6ca59456c5d563d7673fbf54b3bb42f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"390b8dff_58bd57e0","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":76},"updated":"2023-09-25 15:37:12.000000000","message":"Let me draft a better commit message - would you see and reflect with your original purpose? Appreciate in advance.\n\n```\nAdd weblate_utils.py to work with Weblate REST API\n\nZanata tools need to be rewritten to work with Weblate as part of migration work.\nIniConfig class name is the same, and ZanataRestService class name is renamed as WeblateRestService class with the same functionality.\nProjectConfig class is not implemented since Weblate does not have project configuration file like zanata.xml.\n\n```","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be0d35c45584d363b0d5f24d9749889f1fe442f2","unresolved":true,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2023-09-23 20:34:46 +0900"},{"line_number":4,"context_line":"Commit:     n-y-kim \u003cnyn2265@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-23 20:34:46 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add weblate utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Weblate utils file for Zanata to Weblate migration."},{"line_number":10,"context_line":"Creating a new PR from https://review.opendev.org/c/openstack/i18n/+/893361/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #2034921"},{"line_number":13,"context_line":"Change-Id: Ie4cf861cc6ca59456c5d563d7673fbf54b3bb42f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fb88fa33_2cfdabf3","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":76},"in_reply_to":"390b8dff_58bd57e0","updated":"2023-09-28 03:59:44.000000000","message":"+1 to ian\u0027s suggestion.","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be0d35c45584d363b0d5f24d9749889f1fe442f2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add weblate utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Weblate utils file for Zanata to Weblate migration."},{"line_number":10,"context_line":"Creating a new PR from https://review.opendev.org/c/openstack/i18n/+/893361/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #2034921"},{"line_number":13,"context_line":"Change-Id: Ie4cf861cc6ca59456c5d563d7673fbf54b3bb42f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b219d691_80155421","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":18},"in_reply_to":"967126ea_9679c1f1","updated":"2023-09-28 03:59:44.000000000","message":"Precisely speaking, it is officially called as \u0027change\u0027 from POV of gerrit terms, but we usually use \u0027patch\u0027 as it is easier to understand 😊\n\nIMHO, L.10 is unnecessary. This change is to add the weblate version of ZanataUtils.py and the URL looks wrong.","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":36196,"name":"Nayeon Kim","display_name":"nayeonkim","email":"nyn2265@gmail.com","username":"nykim"},"change_message_id":"80870e6be1e0b76906be5488aa5a2945f9560427","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add weblate utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Weblate utils file for Zanata to Weblate migration."},{"line_number":10,"context_line":"Creating a new PR from https://review.opendev.org/c/openstack/i18n/+/893361/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #2034921"},{"line_number":13,"context_line":"Change-Id: Ie4cf861cc6ca59456c5d563d7673fbf54b3bb42f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9bbf76d2_48d83d43","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":18},"in_reply_to":"b219d691_80155421","updated":"2023-10-25 10:45:18.000000000","message":"Done","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":36196,"name":"Nayeon Kim","display_name":"nayeonkim","email":"nyn2265@gmail.com","username":"nykim"},"change_message_id":"80870e6be1e0b76906be5488aa5a2945f9560427","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2023-09-23 20:34:46 +0900"},{"line_number":4,"context_line":"Commit:     n-y-kim \u003cnyn2265@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-09-23 20:34:46 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add weblate utils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Weblate utils file for Zanata to Weblate migration."},{"line_number":10,"context_line":"Creating a new PR from https://review.opendev.org/c/openstack/i18n/+/893361/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #2034921"},{"line_number":13,"context_line":"Change-Id: Ie4cf861cc6ca59456c5d563d7673fbf54b3bb42f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"829259ce_89650b4d","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":76},"in_reply_to":"fb88fa33_2cfdabf3","updated":"2023-10-25 10:45:18.000000000","message":"Done","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"7af01062e0a52cdf1bceb3ac77b3a6b109441208","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Weblate utils file for Zanata to Weblate migration."},{"line_number":10,"context_line":"Creating a new PR from https://review.opendev.org/c/openstack/i18n/+/893361/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #2034921"},{"line_number":13,"context_line":"Change-Id: Ie4cf861cc6ca59456c5d563d7673fbf54b3bb42f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b10a279e_27ba7e5b","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":21},"updated":"2023-09-25 15:37:12.000000000","message":"If possible, would you leverage Launchpad - Blueprints ( https://blueprints.launchpad.net/openstack-i18n ) as a sub-item from one big blueprint \"renew-translation-platform\"? Your team can create a new smaller print to embrace the content of bug #2034921 and leverage like \"Implements: tool-weblate\".","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":36196,"name":"Nayeon Kim","display_name":"nayeonkim","email":"nyn2265@gmail.com","username":"nykim"},"change_message_id":"80870e6be1e0b76906be5488aa5a2945f9560427","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Weblate utils file for Zanata to Weblate migration."},{"line_number":10,"context_line":"Creating a new PR from https://review.opendev.org/c/openstack/i18n/+/893361/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #2034921"},{"line_number":13,"context_line":"Change-Id: Ie4cf861cc6ca59456c5d563d7673fbf54b3bb42f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d0867089_2b0109b7","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":21},"in_reply_to":"8b4cb805_2dc2e5b3","updated":"2023-10-25 10:45:18.000000000","message":"I\u0027m having hard time understanding your comments. Do you mean I should create another blue print item at the Lunchpad-Blueprints and connect the bug with this newly created item?","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be0d35c45584d363b0d5f24d9749889f1fe442f2","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Weblate utils file for Zanata to Weblate migration."},{"line_number":10,"context_line":"Creating a new PR from https://review.opendev.org/c/openstack/i18n/+/893361/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #2034921"},{"line_number":13,"context_line":"Change-Id: Ie4cf861cc6ca59456c5d563d7673fbf54b3bb42f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8b4cb805_2dc2e5b3","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":21},"in_reply_to":"b10a279e_27ba7e5b","updated":"2023-09-28 03:59:44.000000000","message":"agree with Ian\u0027s idea. This kind of effort fits into a blueprint.","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":36196,"name":"Nayeon Kim","display_name":"nayeonkim","email":"nyn2265@gmail.com","username":"nykim"},"change_message_id":"99ef8dc263908ba4416dfd3d8d57d8f8f3b55571","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Weblate utils file for Zanata to Weblate migration."},{"line_number":10,"context_line":"Creating a new PR from https://review.opendev.org/c/openstack/i18n/+/893361/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #2034921"},{"line_number":13,"context_line":"Change-Id: Ie4cf861cc6ca59456c5d563d7673fbf54b3bb42f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f79492ff_31c6a2be","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":21},"in_reply_to":"d0867089_2b0109b7","updated":"2023-10-25 14:11:11.000000000","message":"Solved during PTG meeting.","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be0d35c45584d363b0d5f24d9749889f1fe442f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcaf24b2_f04e14e3","updated":"2023-09-28 03:59:44.000000000","message":"Cmments mainly from POV of OpenStack python conding guideline.","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"7af01062e0a52cdf1bceb3ac77b3a6b109441208","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"20e0b7b5_66f64ba0","updated":"2023-09-25 15:37:12.000000000","message":"weblate_utils.py content looks great, while 1) commit message needs to be revised and 2) (once it is landed) other depending patches need to be rebased upon this patch.","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"2bee4570dcc626d2f887510626ed10547dc1d7d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ee2466ea_76c23a3c","updated":"2023-10-25 14:32:20.000000000","message":"Approving since all the previous review comments have been addressed. Please leverage a new patch for further improvement if needed. Thank you all!","commit_id":"9879499bff3e34e652880f4fb1f2da7e48909ce3"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"e6c9fa850e08a35c5cdc59bec2670b78a128b925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf56d7f4_5033a8f4","updated":"2023-10-25 14:13:13.000000000","message":"Thanks! We reviewed this patch in PTG. So Let\u0027s merge this first.","commit_id":"9879499bff3e34e652880f4fb1f2da7e48909ce3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5b5f74e46fa38dba6cc335b9bfbff5c33078d4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"55f7d4a6_fb2c94d5","updated":"2023-10-26 16:17:34.000000000","message":"This patch depends on another patch \"Add weblate Userinfo\" but this dependency shoul be reverted as the other one consumes weblate_utils. I will update it.","commit_id":"9879499bff3e34e652880f4fb1f2da7e48909ce3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"afbbe043fb844abfb0137a25172625f2ee6019ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ebb99ee3_a109c76d","updated":"2023-10-26 16:30:49.000000000","message":"My comment is nit and can be fixed as follow-up. Approving it.","commit_id":"d45968f182f7aee525d9117d33a108e902e48c39"}],"tools/weblate/weblate_utils.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be0d35c45584d363b0d5f24d9749889f1fe442f2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import requests"},{"line_number":15,"context_line":"from urllib.parse import urljoin"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import wlc"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc09833f_e8a5a816","line":14,"updated":"2023-09-28 03:59:44.000000000","message":"\u0027requests\u0027 is NOT part of python standard library, so this needs to be a separate import group (in the OpenStack coding guideline).\n\n    import json\n    from urllib import parse\n  \n    import requests\n  \n    import wlc\n    ...","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":36196,"name":"Nayeon Kim","display_name":"nayeonkim","email":"nyn2265@gmail.com","username":"nykim"},"change_message_id":"80870e6be1e0b76906be5488aa5a2945f9560427","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import requests"},{"line_number":15,"context_line":"from urllib.parse import urljoin"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import wlc"}],"source_content_type":"text/x-python","patch_set":1,"id":"1b241296_ac93d4f2","line":14,"in_reply_to":"cc09833f_e8a5a816","updated":"2023-10-25 10:45:18.000000000","message":"Done","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be0d35c45584d363b0d5f24d9749889f1fe442f2","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import requests"},{"line_number":15,"context_line":"from urllib.parse import urljoin"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import wlc"},{"line_number":18,"context_line":"import wlc.config as cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3f807ff_31e3acc3","line":15,"updated":"2023-09-28 03:59:44.000000000","message":"In the OpenStack conding guideline, we use module-level import rather than attribute-level import. Let\u0027s use\n\n    from urllib import parse","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":36196,"name":"Nayeon Kim","display_name":"nayeonkim","email":"nyn2265@gmail.com","username":"nykim"},"change_message_id":"80870e6be1e0b76906be5488aa5a2945f9560427","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":"import requests"},{"line_number":15,"context_line":"from urllib.parse import urljoin"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import wlc"},{"line_number":18,"context_line":"import wlc.config as cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"6635cb94_33490fbd","line":15,"in_reply_to":"f3f807ff_31e3acc3","updated":"2023-10-25 10:45:18.000000000","message":"Done","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be0d35c45584d363b0d5f24d9749889f1fe442f2","unresolved":true,"context_lines":[{"line_number":15,"context_line":"from urllib.parse import urljoin"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import wlc"},{"line_number":18,"context_line":"import wlc.config as cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class IniConfig(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9cc5b5f5_6da2569e","line":18,"updated":"2023-09-28 03:59:44.000000000","message":"Consider\n\n    from wlc import config as cfg\n\nThis is what we usually use.","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":36196,"name":"Nayeon Kim","display_name":"nayeonkim","email":"nyn2265@gmail.com","username":"nykim"},"change_message_id":"80870e6be1e0b76906be5488aa5a2945f9560427","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from urllib.parse import urljoin"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import wlc"},{"line_number":18,"context_line":"import wlc.config as cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class IniConfig(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"43680003_5037b0b9","line":18,"in_reply_to":"9cc5b5f5_6da2569e","updated":"2023-10-25 10:45:18.000000000","message":"Done","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be0d35c45584d363b0d5f24d9749889f1fe442f2","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    Read url and key from weblate.ini and make its values available."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Attributes:"},{"line_number":27,"context_line":"    inifile: The path to the ini file to load values from."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":"    def __init__(self, inifile):"}],"source_content_type":"text/x-python","patch_set":1,"id":"740bcf8c_0a45350a","line":27,"updated":"2023-09-28 03:59:44.000000000","message":"Please add \u0027url\u0027 and \u0027key\u0027 too.\nThese are referred from outside of this class.\n\nnit; self.inifile is not referred and there seems no need to make it public. Perhaps self._inifile would be enough.","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"2bee4570dcc626d2f887510626ed10547dc1d7d8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    Read url and key from weblate.ini and make its values available."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Attributes:"},{"line_number":27,"context_line":"    inifile: The path to the ini file to load values from."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":"    def __init__(self, inifile):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef686584_050f0eab","line":27,"in_reply_to":"35c9b16a_695a59fe","updated":"2023-10-25 14:32:20.000000000","message":"In addition, reflected @amotoki\u0027s comment on \"self._inifile\" during 2024.1 PTG","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":36196,"name":"Nayeon Kim","display_name":"nayeonkim","email":"nyn2265@gmail.com","username":"nykim"},"change_message_id":"80870e6be1e0b76906be5488aa5a2945f9560427","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    Read url and key from weblate.ini and make its values available."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    Attributes:"},{"line_number":27,"context_line":"    inifile: The path to the ini file to load values from."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":"    def __init__(self, inifile):"}],"source_content_type":"text/x-python","patch_set":1,"id":"35c9b16a_695a59fe","line":27,"in_reply_to":"740bcf8c_0a45350a","updated":"2023-10-25 10:45:18.000000000","message":"Done","commit_id":"7edc0c35b1bd93fe42520b40b27f02bc1ef7f661"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"298002f3fad84728b4755f0fbc2b51bfe2b5c2a6","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    Attributes:"},{"line_number":26,"context_line":"    url: The URL of the Weblate server."},{"line_number":27,"context_line":"    key: The API key to use for authentication."},{"line_number":28,"context_line":"    _inifile: The path to the ini file to load values from (not public)."},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, inifile):"}],"source_content_type":"text/x-python","patch_set":6,"id":"24f36b03_7aad8d67","line":28,"updated":"2023-10-26 16:29:27.000000000","message":"nit: In python convention, attributes documented here should be limited to public ones. Attributes starting with underscore are considered as private, so L.28 is unnecessary.\n\nIf this needs to be accessed from outside of this class, it should be renamed to a name starting with non-underscore, but looking at the code it looks unncessary.","commit_id":"d45968f182f7aee525d9117d33a108e902e48c39"}]}