)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"d46cf1a1c3e3ed6806545937480dfb49e91bd0c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e411bd60_f9f571b0","updated":"2026-03-24 21:11:41.000000000","message":"Before I can deep dive into this patch, @magimel.francois@gmail.com can you point out some of official OpenStack projects which have `pyproject.toml` so that I can test?","commit_id":"3860c1c53cae15446de41fee622d603f41680287"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"ccf212d9d635c2e34ad8f3c365d0aeb0b91118c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32ca30c4_9d5e0d0f","in_reply_to":"bd2ce577_c2953271","updated":"2026-04-05 14:16:53.000000000","message":"Hello.\nSome projects can use more complex options:\n- example with `hacking`: https://opendev.org/openstack/hacking/src/commit/d27907accd97d6ae5f2b41e5bd5fd7beda2c9ca8/pyproject.toml#L67-L68\n- doc: https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#finding-simple-packages","commit_id":"3860c1c53cae15446de41fee622d603f41680287"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"95042297baf8f4955209ea918daf215d08213919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd2ce577_c2953271","in_reply_to":"e411bd60_f9f571b0","updated":"2026-03-25 07:22:28.000000000","message":"Hello.\nYou can find this file with the section in `cloudkitty-dashboard`, for example: https://opendev.org/openstack/cloudkitty-dashboard/src/branch/master/pyproject.toml#L35-L38. And there is another example in the `pbr` doc: https://docs.openstack.org/pbr/latest/user/using.html#files.\nSome repos have also the `pyproject.toml` file, but with the `file` section in the `setup.cfg` file, like Horizon.","commit_id":"3860c1c53cae15446de41fee622d603f41680287"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"1da146b45ac9bb7fc3c3cc1666024374260d218f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d9b6795b_d607b82a","updated":"2026-04-24 15:44:06.000000000","message":"First, note that I gave +2 to express that this patch aligns with direction discussed [1].\n\n@fungi Thanks for the feedback regarding the stylistic changes.\n\n@FrancoisMagimel During PTG, when asked about changing single quotes to double quotes, you mentioned it was due to pep8 warnings. However, I just re-ran pep8 on the current code and \"no warnings are triggered\".\n\nCould you confirm if these changes were specifically needed, or applied by an auto-formatter/editor? Adding your rationale on the commit message would be helpful.\n\n[1]: https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/HVFN5RBSHRTM3B2UUKPAWKH6H6AT6CYR/","commit_id":"dfb71527c818b218b4254d1a97e811e26d30e59b"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"17d7f0ce9ccab8e1a7fdc00d80c3799b9e2fbcf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a05a6083_55cfa8a8","updated":"2026-04-23 23:52:51.000000000","message":"I agree with the direction and the patch itself looks good. Just it would be better if the patch also references a sample pyproject.toml file from an official OpenStack project.","commit_id":"dfb71527c818b218b4254d1a97e811e26d30e59b"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"e157f42bf8bdb26fd2c70e5696df254833ac81ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"873a34cd_1dabdd73","in_reply_to":"a05a6083_55cfa8a8","updated":"2026-04-24 07:41:42.000000000","message":"Thanks for the review. I didn\u0027t add a reference to a sample pyproject.toml file because I\u0027ve already added the useful section like the setup.cfg file, and there was no ref for setup.cfg.","commit_id":"dfb71527c818b218b4254d1a97e811e26d30e59b"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"de2155e20e622b2ce76638bdfe92a5b9f590b2d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a40e1834_13aaad60","in_reply_to":"d9b6795b_d607b82a","updated":"2026-04-24 18:13:05.000000000","message":"I ran Ruff (https://docs.astral.sh/ruff/) to check the file, and it made those little changes. I\u0027ve just removed them, as it is not the object of this change.","commit_id":"dfb71527c818b218b4254d1a97e811e26d30e59b"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"424fbb62f89489d7f8ed8337fbc00b276aeca3d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1975da0f_a5d2592a","updated":"2026-05-08 16:07:30.000000000","message":"@fungi@yuggoth.org Current version looks good to me, while I would like to double-check with you whether such changes excluded unrelated changes are fine or not.","commit_id":"e08c540799fcaaa1739fd39c6266fbf344ccc17a"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"920090bffdeccdf6487615c21b41d9ec05605102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1f475274_16317857","updated":"2026-05-08 16:10:33.000000000","message":"All, note that https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/983148/3/roles/prepare-zanata-client/files/get-modulename.py has been merged.","commit_id":"e08c540799fcaaa1739fd39c6266fbf344ccc17a"},{"author":{"_account_id":23279,"name":"Seongsoo Cho","display_name":"Seongsoo Cho","email":"ppiyakk2@printf.kr","username":"seongsoo.cho"},"change_message_id":"c3c3e8b790d30f6d3b6194622568f8c17c531793","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"508263c5_d2afe87a","updated":"2026-05-12 15:35:52.000000000","message":"Thanks for review and comment everyone. \nI reviewed the documentation. Since get-modulename.py is currently used in openstack-zuul-jobs and not yet in the i18n repo, I have no further comments.","commit_id":"e08c540799fcaaa1739fd39c6266fbf344ccc17a"}],"doc/source/project_setup.rst":[{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"17d7f0ce9ccab8e1a7fdc00d80c3799b9e2fbcf0","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"If you are using a ``setup.cfg`` file, you need to list your modules into the"},{"line_number":49,"context_line":"``packages`` entry of the ``files`` section:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. code-block:: ini"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"   [files]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"78c740b0_b75b08b2","line":50,"updated":"2026-04-23 23:52:51.000000000","message":"Let\u0027s link sample pyproject.toml and related context as note.","commit_id":"dfb71527c818b218b4254d1a97e811e26d30e59b"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"4a293724dbea0db9574ea68854de5ddf54eca3f5","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"If you are using a ``setup.cfg`` file, you need to list your modules into the"},{"line_number":49,"context_line":"``packages`` entry of the ``files`` section:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. code-block:: ini"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"   [files]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"b17390e2_2822bde3","line":50,"in_reply_to":"78c740b0_b75b08b2","updated":"2026-04-24 17:58:51.000000000","message":"Done","commit_id":"dfb71527c818b218b4254d1a97e811e26d30e59b"}]}
