)]}'
{"id":"openstack%2Finstack-undercloud~226907","triplet_id":"openstack%2Finstack-undercloud~master~Id008847376914752d7a30ce7bdd8c33a44bfb4fe","project":"openstack/instack-undercloud","branch":"master","topic":"bug/1494896","hashtags":[],"change_id":"Id008847376914752d7a30ce7bdd8c33a44bfb4fe","subject":"Put staticweb middleware after keystoneauth in proxy","status":"MERGED","created":"2015-09-23 18:04:57.000000000","updated":"2015-09-23 19:49:11.000000000","submitted":"2015-09-23 19:15:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d49533b01982b6f9b58477efe9688c578b07da1e","_number":226907,"virtual_id_number":226907,"owner":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2015-09-23 19:15:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"all":[{"value":2,"date":"2015-09-23 18:24:22.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":2,"date":"2015-09-23 18:21:39.000000000","_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":1,"date":"2015-09-23 18:07:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"all":[{"value":1,"date":"2015-09-23 18:24:22.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-23 18:07:07.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2015-09-23 18:21:39.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2015-09-23 18:24:22.000000000","updated_by":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"reviewer":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"state":"REVIEWER"},{"updated":"2015-09-23 19:15:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b9177291dab65d3ebdc6d7cd8aa6f76c01eeb937","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2015-09-23 18:04:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"08fd49c7f1fa06030923a7c022ec0e2b157c33bb","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-09-23 18:07:07.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"01b38d7092f240d8d95d7c5c80439ff87ead9b10","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-23 18:09:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-instack-undercloud-pep8 http://logs.openstack.org/07/226907/1/check/gate-instack-undercloud-pep8/3674ab0/ : SUCCESS in 49s\n- gate-instack-undercloud-docs http://docs-draft.openstack.org/07/226907/1/check/gate-instack-undercloud-docs/858601b//doc/build/html/ : SUCCESS in 58s\n- gate-instack-undercloud-python27 http://logs.openstack.org/07/226907/1/check/gate-instack-undercloud-python27/977cf98/ : SUCCESS in 56s","accounts_in_message":[],"_revision_number":1},{"id":"3512872fb2cd4cf51c6b8ef3ca79b8ff58f13984","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2015-09-23 18:21:39.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1dde18e5558144ef99f4f413d918e923ce76b3fe","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2015-09-23 18:24:22.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nmerging now that the security bug has been disclosed","accounts_in_message":[],"_revision_number":1},{"id":"080feda7313b00a8afc7f127ce432fc5f06514c0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-23 18:43:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5286159bbc75fc619c1b677cc848fc062564cea6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-23 19:15:05.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"eb43a5ef94d00c64e9ec78b9990beea0d0e570c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-23 19:15:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-instack-undercloud-docs http://docs-draft.openstack.org/07/226907/1/gate/gate-instack-undercloud-docs/c8b53d3//doc/build/html/ : SUCCESS in 56s\n- gate-instack-undercloud-pep8 http://logs.openstack.org/07/226907/1/gate/gate-instack-undercloud-pep8/679f5e0/ : SUCCESS in 47s\n- gate-instack-undercloud-python27 http://logs.openstack.org/07/226907/1/gate/gate-instack-undercloud-python27/2210d64/ : SUCCESS in 59s","accounts_in_message":[],"_revision_number":1},{"id":"f8fd9bf56a4b10365af77e9cee5b347c7a62c2c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-23 19:49:11.000000000","message":"Patch Set 1:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ironic-overcloud-f21puppet-ceph http://logs.openstack.org/07/226907/1/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-ceph/edb987e/ : SUCCESS in 1h 43m 56s (non-voting)\n- gate-tripleo-ironic-overcloud-f21puppet-ha http://logs.openstack.org/07/226907/1/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-ha/12e9a6a/ : SUCCESS in 1h 42m 03s (non-voting)\n- gate-tripleo-ironic-overcloud-f21puppet-nonha http://logs.openstack.org/07/226907/1/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-nonha/072895c/ : SUCCESS in 1h 31m 28s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"033f9d76b677eb2d01aa6c875365195019862aa0","revisions":{"033f9d76b677eb2d01aa6c875365195019862aa0":{"kind":"REWORK","_number":1,"created":"2015-09-23 18:04:57.000000000","uploader":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"ref":"refs/changes/07/226907/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/instack-undercloud","ref":"refs/changes/07/226907/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/instack-undercloud refs/changes/07/226907/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/instack-undercloud refs/changes/07/226907/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/instack-undercloud refs/changes/07/226907/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/instack-undercloud refs/changes/07/226907/1"}}},"commit":{"parents":[{"commit":"280968c7e424b751255d0b912edd4ede6901bd86","subject":"Merge \"Fix small typo in instack-virt-setup script\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/instack-undercloud/commit/280968c7e424b751255d0b912edd4ede6901bd86"}]}],"author":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2015-09-23 18:03:48.000000000","tz":-240},"committer":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2015-09-23 18:03:48.000000000","tz":-240},"subject":"Put staticweb middleware after keystoneauth in proxy","message":"Put staticweb middleware after keystoneauth in proxy\n\nThe staticweb middleware needs to be put after authentication\nmiddlewares to ensure correct functionality as documented in\nhttp://docs.openstack.org/developer/swift/middleware.html#staticweb\n\nWithout this Swift sends a HTML response even if the request was done\nusing a X-Auth-Token. This might result in a faulty handling of the\nresponse on the client side; for example, \"swift stat containername\"\nwould report an empty, private container, while the container might\nactually be public readable with data stored in it.\n\nChange-Id: Id008847376914752d7a30ce7bdd8c33a44bfb4fe\nRelated-bug: 1494896\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/instack-undercloud/commit/033f9d76b677eb2d01aa6c875365195019862aa0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/instack-undercloud/commit/033f9d76b677eb2d01aa6c875365195019862aa0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"280968c7e424b751255d0b912edd4ede6901bd86","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}