)]}'
{"instack_undercloud/undercloud.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"51a30384c9864da654bacc7b250ba9e345f21f58","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        _run_command(args, name\u003d\u0027mkdir instack-certs\u0027)"},{"line_number":645,"context_line":"        args \u003d [\u0027sudo\u0027, \u0027cp\u0027, \u0027-f\u0027, home_pem, undercloud_pem]"},{"line_number":646,"context_line":"        _run_command(args, name\u003d\u0027cp undercloud.pem\u0027)"},{"line_number":647,"context_line":"        args \u003d [\u0027sudo\u0027, \u0027semanage\u0027, \u0027fcontext\u0027, \u0027-a\u0027, \u0027-t\u0027, \u0027etc_t\u0027,"},{"line_number":648,"context_line":"                \u0027\"/etc/pki/instack-certs(/.*)?\"\u0027]"},{"line_number":649,"context_line":"        _run_command(args, name\u003d\u0027semanage\u0027)"},{"line_number":650,"context_line":"        args \u003d [\u0027sudo\u0027, \u0027restorecon\u0027, \u0027-R\u0027, \u0027/etc/pki/instack-certs\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_7049758b","line":647,"range":{"start_line":647,"start_character":61,"end_line":647,"end_character":66},"updated":"2016-02-15 16:09:49.000000000","message":"don\u0027t we want to use a cert_t context?","commit_id":"09d97d85183cb20f373b2a54e1e12ca0f076741f"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"49e4185c2138707f7d92cd0d8ebb796127ad3e78","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        _run_command(args, name\u003d\u0027mkdir instack-certs\u0027)"},{"line_number":645,"context_line":"        args \u003d [\u0027sudo\u0027, \u0027cp\u0027, \u0027-f\u0027, home_pem, undercloud_pem]"},{"line_number":646,"context_line":"        _run_command(args, name\u003d\u0027cp undercloud.pem\u0027)"},{"line_number":647,"context_line":"        args \u003d [\u0027sudo\u0027, \u0027semanage\u0027, \u0027fcontext\u0027, \u0027-a\u0027, \u0027-t\u0027, \u0027etc_t\u0027,"},{"line_number":648,"context_line":"                \u0027\"/etc/pki/instack-certs(/.*)?\"\u0027]"},{"line_number":649,"context_line":"        _run_command(args, name\u003d\u0027semanage\u0027)"},{"line_number":650,"context_line":"        args \u003d [\u0027sudo\u0027, \u0027restorecon\u0027, \u0027-R\u0027, \u0027/etc/pki/instack-certs\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_8e8df533","line":647,"range":{"start_line":647,"start_character":61,"end_line":647,"end_character":66},"in_reply_to":"dae33548_7049758b","updated":"2016-02-15 16:53:51.000000000","message":"That might also work, but this is what we currently document and I\u0027m hesitant to change it because we had a bunch of trouble getting this right originally on RHEL, and etc_t works.\n\nIf you want to try cert_t on both RHEL and CentOS to make sure it works both places I\u0027m fine with changing it, but it would also need to be changed in the docs then.","commit_id":"09d97d85183cb20f373b2a54e1e12ca0f076741f"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"f58dae01508a6ff1e76a4692ea40ecd3d54deff3","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                     \u0027connections.  Setting this enables SSL for the \u0027"},{"line_number":128,"context_line":"                     \u0027OpenStack API endpoints, leaving it unset disables SSL.\u0027)"},{"line_number":129,"context_line":"               ),"},{"line_number":130,"context_line":"    cfg.BoolOpt(\u0027generate_service_certificate\u0027,"},{"line_number":131,"context_line":"                default\u003dFalse,"},{"line_number":132,"context_line":"                help\u003d(\u0027When set to True, a self-signed SSL certificate will \u0027"},{"line_number":133,"context_line":"                      \u0027be generated as part of the undercloud install and \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_518753b4","line":130,"updated":"2016-04-21 03:03:11.000000000","message":"Would there be any harm in us always generating our own certificate? And thus we could just eliminate this config option?","commit_id":"b41a7a374fe3d325411c8c55bcbe54aab25debe6"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f3775d2d5c1b1995076723dacb77a29f503ee9b0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                     \u0027connections.  Setting this enables SSL for the \u0027"},{"line_number":128,"context_line":"                     \u0027OpenStack API endpoints, leaving it unset disables SSL.\u0027)"},{"line_number":129,"context_line":"               ),"},{"line_number":130,"context_line":"    cfg.BoolOpt(\u0027generate_service_certificate\u0027,"},{"line_number":131,"context_line":"                default\u003dFalse,"},{"line_number":132,"context_line":"                help\u003d(\u0027When set to True, a self-signed SSL certificate will \u0027"},{"line_number":133,"context_line":"                      \u0027be generated as part of the undercloud install and \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_9cac448e","line":130,"in_reply_to":"1a122d0e_518753b4","updated":"2016-04-21 14:17:24.000000000","message":"The only drawback might be for someone who wants to call the undercloud apis from another system.  Due to the self-signed cert, they\u0027d have to pull the CA cert off the undercloud and either install it on their system or use it as OS_CACERT in their rc file.\n\nI\u0027m fine with doing that though.  As an added bonus, it would reduce our testing matrix if we always had ssl enabled.  We\u0027ve found a few bugs (particularly around upgrading the undercloud) that only present with ssl enabled.","commit_id":"b41a7a374fe3d325411c8c55bcbe54aab25debe6"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9fa7e5c7ecd2652b5268c2c781c706eccbec119c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                     \u0027connections.  Setting this enables SSL for the \u0027"},{"line_number":128,"context_line":"                     \u0027OpenStack API endpoints, leaving it unset disables SSL.\u0027)"},{"line_number":129,"context_line":"               ),"},{"line_number":130,"context_line":"    cfg.BoolOpt(\u0027generate_service_certificate\u0027,"},{"line_number":131,"context_line":"                default\u003dFalse,"},{"line_number":132,"context_line":"                help\u003d(\u0027When set to True, a self-signed SSL certificate will \u0027"},{"line_number":133,"context_line":"                      \u0027be generated as part of the undercloud install and \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_b27300b4","line":130,"in_reply_to":"1a122d0e_9cac448e","updated":"2016-04-22 10:53:14.000000000","message":"Well, would be pretty cool to have SSL by default.","commit_id":"b41a7a374fe3d325411c8c55bcbe54aab25debe6"}],"undercloud.conf.sample":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"32991a895b37a1a6bc3c37367cc68c5f7baab5e2","unresolved":false,"context_lines":[{"line_number":93,"context_line":"# Whether to install Tempest in the Undercloud. (boolean value)"},{"line_number":94,"context_line":"#enable_tempest \u003d true"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# Whether to install Mistral services in the Undercloud. (boolean"},{"line_number":97,"context_line":"# value)"},{"line_number":98,"context_line":"#enable_mistral \u003d false"},{"line_number":99,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7a5de9d1_a72c39ac","line":96,"updated":"2016-01-27 23:58:29.000000000","message":"My assumption is that the rest of the changes in this file are a result of the config generator not being used to update the sample file in previous changes.","commit_id":"44676e6c219ff69fe430701a42d58830e6bbabed"}]}