)]}'
{"elements/puppet-stack-config/puppet-stack-config.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8eae6488f851e35744b812d47bcdcd7450f2fdd8","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    ironic                    \u003d\u003e true,"},{"line_number":437,"context_line":"    rabbitmq                  \u003d\u003e true,"},{"line_number":438,"context_line":"  }"},{"line_number":439,"context_line":"} else {"},{"line_number":440,"context_line":"  # sysctl_settings are set in puppet-tripleo/loadbalancer.pp"},{"line_number":441,"context_line":"  # so to avoid a duplicated resource we need to set it here manually only"},{"line_number":442,"context_line":"  # when we don\u0027t have service_certificate paramter."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_ec1794a0","line":439,"updated":"2016-08-18 13:43:13.000000000","message":"this means we won\u0027t apply any key when doing service_certificate though","commit_id":"6c5f75efd2e7a34f9d783023a44121e1768fb7c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"015440027b29a7e62d26b41552e7e6ff980e79ab","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    ironic                    \u003d\u003e true,"},{"line_number":437,"context_line":"    rabbitmq                  \u003d\u003e true,"},{"line_number":438,"context_line":"  }"},{"line_number":439,"context_line":"} else {"},{"line_number":440,"context_line":"  # sysctl_settings are set in puppet-tripleo/loadbalancer.pp"},{"line_number":441,"context_line":"  # so to avoid a duplicated resource we need to set it here manually only"},{"line_number":442,"context_line":"  # when we don\u0027t have service_certificate paramter."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_b2b8522b","line":439,"in_reply_to":"3ac371cc_b21cd26a","updated":"2016-08-18 13:49:24.000000000","message":"here: https://review.openstack.org/#/c/356755/1/manifests/loadbalancer.pp","commit_id":"6c5f75efd2e7a34f9d783023a44121e1768fb7c3"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"61cf4f0ef675c7dfe8a3d46c6674bae794eca7aa","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    ironic                    \u003d\u003e true,"},{"line_number":437,"context_line":"    rabbitmq                  \u003d\u003e true,"},{"line_number":438,"context_line":"  }"},{"line_number":439,"context_line":"} else {"},{"line_number":440,"context_line":"  # sysctl_settings are set in puppet-tripleo/loadbalancer.pp"},{"line_number":441,"context_line":"  # so to avoid a duplicated resource we need to set it here manually only"},{"line_number":442,"context_line":"  # when we don\u0027t have service_certificate paramter."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_32a46206","line":439,"in_reply_to":"3ac371cc_b21cd26a","updated":"2016-08-18 13:49:19.000000000","message":"yeah but not those in sysctl_settings, if we add any","commit_id":"6c5f75efd2e7a34f9d783023a44121e1768fb7c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4ab5fdda3247f97f4e339c6952d307b88a92f9a7","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    ironic                    \u003d\u003e true,"},{"line_number":437,"context_line":"    rabbitmq                  \u003d\u003e true,"},{"line_number":438,"context_line":"  }"},{"line_number":439,"context_line":"} else {"},{"line_number":440,"context_line":"  # sysctl_settings are set in puppet-tripleo/loadbalancer.pp"},{"line_number":441,"context_line":"  # so to avoid a duplicated resource we need to set it here manually only"},{"line_number":442,"context_line":"  # when we don\u0027t have service_certificate paramter."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_b21cd26a","line":439,"in_reply_to":"3ac371cc_ec1794a0","updated":"2016-08-18 13:48:39.000000000","message":"they will apply because they are defined in tripleo::loadbalancer class.","commit_id":"6c5f75efd2e7a34f9d783023a44121e1768fb7c3"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"21742d0da245d4a2ced8a899affd89c5ebfe2a17","unresolved":false,"context_lines":[{"line_number":439,"context_line":"} else {"},{"line_number":440,"context_line":"  # sysctl_settings are set in puppet-tripleo/loadbalancer.pp"},{"line_number":441,"context_line":"  # so to avoid a duplicated resource we need to set it here manually only"},{"line_number":442,"context_line":"  # when we don\u0027t have service_certificate paramter."},{"line_number":443,"context_line":"  create_resources(sysctl::value, hiera(\u0027sysctl_settings\u0027), { })"},{"line_number":444,"context_line":"}"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_233febb4","line":442,"updated":"2016-08-18 16:26:12.000000000","message":"parameter","commit_id":"6c5f75efd2e7a34f9d783023a44121e1768fb7c3"}]}
