)]}'
{"elements/puppet-stack-config/puppet-stack-config.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f25fd2bc39470267b807bf4cd7e5e1dc612fbc50","unresolved":false,"context_lines":[{"line_number":689,"context_line":"    tries       \u003d\u003e 10,"},{"line_number":690,"context_line":"    timeout     \u003d\u003e $db_sync_timeout,"},{"line_number":691,"context_line":"    logoutput   \u003d\u003e on_failure,"},{"line_number":692,"context_line":"    subscribe   \u003d\u003e ["},{"line_number":693,"context_line":"      Anchor[\u0027nova::db_pre_upgrade_online_data_migrations::begin\u0027],"},{"line_number":694,"context_line":"    ],"},{"line_number":695,"context_line":"    notify      \u003d\u003e ["},{"line_number":696,"context_line":"      Anchor[\u0027nova::install::begin\u0027],"},{"line_number":697,"context_line":"      Anchor[\u0027nova::db_pre_upgrade_online_data_migrations::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a461143_58ff4a34","line":694,"range":{"start_line":692,"start_character":4,"end_line":694,"end_character":6},"updated":"2017-01-25 18:02:32.000000000","message":"that anchor doesn\u0027t exist, just remove","commit_id":"fe39c28ff9220340af5dfe0bc8bcb16865b046fe"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f25fd2bc39470267b807bf4cd7e5e1dc612fbc50","unresolved":false,"context_lines":[{"line_number":692,"context_line":"    subscribe   \u003d\u003e ["},{"line_number":693,"context_line":"      Anchor[\u0027nova::db_pre_upgrade_online_data_migrations::begin\u0027],"},{"line_number":694,"context_line":"    ],"},{"line_number":695,"context_line":"    notify      \u003d\u003e ["},{"line_number":696,"context_line":"      Anchor[\u0027nova::install::begin\u0027],"},{"line_number":697,"context_line":"      Anchor[\u0027nova::db_pre_upgrade_online_data_migrations::end\u0027],"},{"line_number":698,"context_line":"    ],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a461143_b8ed8e90","line":695,"range":{"start_line":695,"start_character":4,"end_line":695,"end_character":10},"updated":"2017-01-25 18:02:32.000000000","message":"s/notify/before/ I expect","commit_id":"fe39c28ff9220340af5dfe0bc8bcb16865b046fe"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f25fd2bc39470267b807bf4cd7e5e1dc612fbc50","unresolved":false,"context_lines":[{"line_number":694,"context_line":"    ],"},{"line_number":695,"context_line":"    notify      \u003d\u003e ["},{"line_number":696,"context_line":"      Anchor[\u0027nova::install::begin\u0027],"},{"line_number":697,"context_line":"      Anchor[\u0027nova::db_pre_upgrade_online_data_migrations::end\u0027],"},{"line_number":698,"context_line":"    ],"},{"line_number":699,"context_line":"  }"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a461143_98f9b250","line":697,"range":{"start_line":697,"start_character":5,"end_line":697,"end_character":65},"updated":"2017-01-25 18:02:32.000000000","message":"this anchor doesn\u0027t exist either, just remove","commit_id":"fe39c28ff9220340af5dfe0bc8bcb16865b046fe"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"10f8cf26ef9b61786fab1cd32c1fa1dff0df3df0","unresolved":false,"context_lines":[{"line_number":684,"context_line":""},{"line_number":685,"context_line":"  exec { \u0027nova-db-pre-upgrade-online-data-migrations\u0027:"},{"line_number":686,"context_line":"    command     \u003d\u003e \u0027/usr/bin/nova-manage db online_data_migrations\u0027,"},{"line_number":687,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":688,"context_line":"    try_sleep   \u003d\u003e 5,"},{"line_number":689,"context_line":"    tries       \u003d\u003e 10,"},{"line_number":690,"context_line":"    timeout     \u003d\u003e $db_sync_timeout,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a461143_c59fcb5d","line":687,"range":{"start_line":687,"start_character":4,"end_line":687,"end_character":24},"updated":"2017-01-25 20:53:09.000000000","message":"refreshonly means don\u0027t run unless something notifies it, and it doesn\u0027t subscribe to anything, so it will not run","commit_id":"08d1446fe7679c1c27a88286e6cb218db2a0e85c"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"10f8cf26ef9b61786fab1cd32c1fa1dff0df3df0","unresolved":false,"context_lines":[{"line_number":685,"context_line":"  exec { \u0027nova-db-pre-upgrade-online-data-migrations\u0027:"},{"line_number":686,"context_line":"    command     \u003d\u003e \u0027/usr/bin/nova-manage db online_data_migrations\u0027,"},{"line_number":687,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":688,"context_line":"    try_sleep   \u003d\u003e 5,"},{"line_number":689,"context_line":"    tries       \u003d\u003e 10,"},{"line_number":690,"context_line":"    timeout     \u003d\u003e $db_sync_timeout,"},{"line_number":691,"context_line":"    logoutput   \u003d\u003e on_failure,"},{"line_number":692,"context_line":"    before      \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a461143_c5beebfe","line":689,"range":{"start_line":688,"start_character":4,"end_line":689,"end_character":22},"updated":"2017-01-25 20:53:09.000000000","message":"do you need to retry?","commit_id":"08d1446fe7679c1c27a88286e6cb218db2a0e85c"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"10f8cf26ef9b61786fab1cd32c1fa1dff0df3df0","unresolved":false,"context_lines":[{"line_number":687,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":688,"context_line":"    try_sleep   \u003d\u003e 5,"},{"line_number":689,"context_line":"    tries       \u003d\u003e 10,"},{"line_number":690,"context_line":"    timeout     \u003d\u003e $db_sync_timeout,"},{"line_number":691,"context_line":"    logoutput   \u003d\u003e on_failure,"},{"line_number":692,"context_line":"    before      \u003d\u003e ["},{"line_number":693,"context_line":"      Anchor[\u0027nova::install::begin\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a461143_c5626bd8","line":690,"range":{"start_line":690,"start_character":19,"end_line":690,"end_character":35},"updated":"2017-01-25 20:53:09.000000000","message":"this isn\u0027t set","commit_id":"08d1446fe7679c1c27a88286e6cb218db2a0e85c"}],"instack_undercloud/undercloud.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"34ef78e0b7b66a1b111d32bfd5d728514441a4d7","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"        _generate_init_data(instack_env)"},{"line_number":1282,"context_line":"        if upgrade:"},{"line_number":1283,"context_line":"            _run_command([\u0027sudo\u0027, \u0027/usr/bin/nova-manage\u0027, \u0027db\u0027,"},{"line_number":1284,"context_line":"                          \u0027online_data_migrations\u0027])"},{"line_number":1285,"context_line":"        if CONF.undercloud_update_packages:"},{"line_number":1286,"context_line":"            _run_yum_clean_all(instack_env)"},{"line_number":1287,"context_line":"            _run_yum_update(instack_env)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_a3493362","line":1284,"updated":"2017-01-30 22:55:21.000000000","message":"I assume we\u0027re running this here because we need to do this while still running the newton code base prior to having the ocata packages updated?  If so it would be beneficial to document why this is here.  Alternatively if the newton code doesn\u0027t need to get run, should we do some puppet tricks like in cell v2 instead?","commit_id":"9b4f10b159abb231673c4f1aa4e0ab8c327b0f84"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4b20affb47e3b91be68f65be98312bcadce77227","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"        _generate_init_data(instack_env)"},{"line_number":1282,"context_line":"        if upgrade:"},{"line_number":1283,"context_line":"            _run_command([\u0027sudo\u0027, \u0027/usr/bin/nova-manage\u0027, \u0027db\u0027,"},{"line_number":1284,"context_line":"                          \u0027online_data_migrations\u0027])"},{"line_number":1285,"context_line":"        if CONF.undercloud_update_packages:"},{"line_number":1286,"context_line":"            _run_yum_clean_all(instack_env)"},{"line_number":1287,"context_line":"            _run_yum_update(instack_env)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_7bf1a86a","line":1284,"in_reply_to":"3a461143_a3493362","updated":"2017-01-31 08:58:39.000000000","message":"yes this is my understanding from irc chat with sven yesterday. We need to run this twice, once with newton code like here and then again at https://github.com/openstack/instack-undercloud/blob/90cb8cf91af63fbae849fbdb89a435f9bcf5b753/elements/puppet-stack-config/puppet-stack-config.pp#L28\n\nthough +1 to a comment and ideally pointing at a bug or this review","commit_id":"9b4f10b159abb231673c4f1aa4e0ab8c327b0f84"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"37da8cc04658d2d26aaa3ceac4037630326dc35f","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"        _clean_os_refresh_config()"},{"line_number":1303,"context_line":"        _validate_configuration()"},{"line_number":1304,"context_line":"        instack_env \u003d _generate_environment(instack_root)"},{"line_number":1305,"context_line":"        _generate_init_data(instack_env)"},{"line_number":1306,"context_line":"        if upgrade:"},{"line_number":1307,"context_line":"            _run_command([\u0027sudo\u0027, \u0027/usr/bin/nova-manage\u0027, \u0027db\u0027,"},{"line_number":1308,"context_line":"                          \u0027online_data_migrations\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a461143_728293c9","line":1305,"updated":"2017-01-31 17:26:45.000000000","message":"do we need a TODO here to remove this bit after Ocata is branched?","commit_id":"41e1b475dccc29157f76df9eb158913ed0d8ca08"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"bc2276f414f2394cb5006337abf17b1eb0f73fd7","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"        _clean_os_refresh_config()"},{"line_number":1303,"context_line":"        _validate_configuration()"},{"line_number":1304,"context_line":"        instack_env \u003d _generate_environment(instack_root)"},{"line_number":1305,"context_line":"        _generate_init_data(instack_env)"},{"line_number":1306,"context_line":"        if upgrade:"},{"line_number":1307,"context_line":"            _run_command([\u0027sudo\u0027, \u0027/usr/bin/nova-manage\u0027, \u0027db\u0027,"},{"line_number":1308,"context_line":"                          \u0027online_data_migrations\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a461143_afe0f5cd","line":1305,"in_reply_to":"3a461143_3b7a8a24","updated":"2017-02-01 13:13:45.000000000","message":"I think it would be helpful if we can add a comment on why this needs to be run. But i wouldnt block it.","commit_id":"41e1b475dccc29157f76df9eb158913ed0d8ca08"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"91d7ca38f969ef8bb4d12cdf0dfd16f64ec6af37","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"        _clean_os_refresh_config()"},{"line_number":1303,"context_line":"        _validate_configuration()"},{"line_number":1304,"context_line":"        instack_env \u003d _generate_environment(instack_root)"},{"line_number":1305,"context_line":"        _generate_init_data(instack_env)"},{"line_number":1306,"context_line":"        if upgrade:"},{"line_number":1307,"context_line":"            _run_command([\u0027sudo\u0027, \u0027/usr/bin/nova-manage\u0027, \u0027db\u0027,"},{"line_number":1308,"context_line":"                          \u0027online_data_migrations\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a461143_3b7a8a24","line":1305,"in_reply_to":"3a461143_728293c9","updated":"2017-02-01 11:49:47.000000000","message":"No, I think this is a noop if there is nothing to to and it is necessary if there is something to do, so we might just keep it. But I have no strong opinion on the.","commit_id":"41e1b475dccc29157f76df9eb158913ed0d8ca08"}]}