)]}'
{"instack_undercloud/undercloud.py":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"4aebe9c2647a5c97d6895a7ada85434d00d86ac8","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                      \u0027the Undercloud.\u0027)"},{"line_number":328,"context_line":"                ),"},{"line_number":329,"context_line":"    cfg.BoolOpt(\u0027enable_container_images_build\u0027,"},{"line_number":330,"context_line":"                default\u003dTrue,"},{"line_number":331,"context_line":"                help\u003d(\u0027Whether to enable docker container images to be build \u0027"},{"line_number":332,"context_line":"                      \u0027on the undercloud.\u0027)"},{"line_number":333,"context_line":"                ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_8b868365","line":330,"updated":"2017-04-12 17:39:41.000000000","message":"My current understanding is that the kolla rpms will not ship to customers.  If this setting is true by default osp builds will fail, and are failing atm due to kolla.  This has to be set to false to work across all builds.","commit_id":"424899af9d78d6cf1cbfbb8e568cf0e5ac711971"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"6d26959e9b99396fedd07585b1674362e9b35711","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                      \u0027the Undercloud.\u0027)"},{"line_number":328,"context_line":"                ),"},{"line_number":329,"context_line":"    cfg.BoolOpt(\u0027enable_container_images_build\u0027,"},{"line_number":330,"context_line":"                default\u003dTrue,"},{"line_number":331,"context_line":"                help\u003d(\u0027Whether to enable docker container images to be build \u0027"},{"line_number":332,"context_line":"                      \u0027on the undercloud.\u0027)"},{"line_number":333,"context_line":"                ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ff52f3f_ebf96f4d","line":330,"in_reply_to":"9ff52f3f_ab0a4787","updated":"2017-04-13 13:40:27.000000000","message":"+1. We could diverge the defaults on this upstream vs. downstream, as there seem to be differing preferences. We could have a simple downstream-only patch changing the downstream default.","commit_id":"424899af9d78d6cf1cbfbb8e568cf0e5ac711971"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"53b5126fd36ff0635a18171b98af64027588465f","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                      \u0027the Undercloud.\u0027)"},{"line_number":328,"context_line":"                ),"},{"line_number":329,"context_line":"    cfg.BoolOpt(\u0027enable_container_images_build\u0027,"},{"line_number":330,"context_line":"                default\u003dTrue,"},{"line_number":331,"context_line":"                help\u003d(\u0027Whether to enable docker container images to be build \u0027"},{"line_number":332,"context_line":"                      \u0027on the undercloud.\u0027)"},{"line_number":333,"context_line":"                ),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ff52f3f_ab0a4787","line":330,"in_reply_to":"bff0334d_8b868365","updated":"2017-04-13 13:33:12.000000000","message":"Could we debate this default setting on this at a later time. For upstream we\u0027d like this on for now I think as we\u0027ve got nothing else to build containers in our CI","commit_id":"424899af9d78d6cf1cbfbb8e568cf0e5ac711971"}],"undercloud.conf.sample":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"4aebe9c2647a5c97d6895a7ada85434d00d86ac8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"# Whether to enable docker container images to be build on the undercloud."},{"line_number":203,"context_line":"# Note this installs the required packages but does not build the images"},{"line_number":204,"context_line":"# automatically."},{"line_number":205,"context_line":"#enable_container_images_build \u003d true"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# An optional docker \u0027registry-mirror\u0027 that will be"},{"line_number":208,"context_line":"# configured in /etc/docker/daemon.json."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bff0334d_ab5ca718","line":205,"updated":"2017-04-12 17:39:41.000000000","message":"My current understanding is that the kolla rpms will not ship to customers.  If this setting is true by default osp builds will fail, and are failing atm due to kolla.","commit_id":"424899af9d78d6cf1cbfbb8e568cf0e5ac711971"}]}