)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"647bc097018dc0b539da471b2707abd29bb37dee","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: I2fd1e4a95f000da19864e75299afa51527697101"},{"line_number":13,"context_line":"Change-Id: I5d0ef61e1527927882802f01c4f5c82b1f495cdd"},{"line_number":14,"context_line":"Partial-Bug: #1708653"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f436f4f_b653096b","line":14,"updated":"2017-08-15 16:45:42.000000000","message":"Is this really partial?  What else needs to be done to get it working?  If it\u0027s only partial because of the possible future custom resource classes work I\u0027d rather just close this bug and open a new RFE one for that.","commit_id":"a2b2566edf8b7bc1c85ca4c62ec31e661a130dd6"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f9552f6dfbf2f886e8818269e57c5b4fa4a04181","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: I2fd1e4a95f000da19864e75299afa51527697101"},{"line_number":13,"context_line":"Change-Id: I5d0ef61e1527927882802f01c4f5c82b1f495cdd"},{"line_number":14,"context_line":"Partial-Bug: #1708653"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f436f4f_969125f4","line":14,"in_reply_to":"9f436f4f_56f3bd74","updated":"2017-08-15 16:47:47.000000000","message":"Got it, thanks.","commit_id":"a2b2566edf8b7bc1c85ca4c62ec31e661a130dd6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3737d1150516cfc246abd16013556bcfe12c68ec","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: I2fd1e4a95f000da19864e75299afa51527697101"},{"line_number":13,"context_line":"Change-Id: I5d0ef61e1527927882802f01c4f5c82b1f495cdd"},{"line_number":14,"context_line":"Partial-Bug: #1708653"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f436f4f_56f3bd74","line":14,"in_reply_to":"9f436f4f_b653096b","updated":"2017-08-15 16:46:28.000000000","message":"I have a tripleo-common side to add resource_class to all new nodes: https://review.openstack.org/493943","commit_id":"a2b2566edf8b7bc1c85ca4c62ec31e661a130dd6"}],"instack_undercloud/undercloud.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ae0e3ad6bb11e6c7375def07fe53b0a329142abf","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"        if key.startswith(\u0027resources:CUSTOM_\u0027):"},{"line_number":1389,"context_line":"            LOG.warning(\u0027Not updating flavor %s, as it already has a custom \u0027"},{"line_number":1390,"context_line":"                        \u0027resource class %s\u0027, flavor.name, key)"},{"line_number":1391,"context_line":"            return"},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"    rc \u003d DEFAULT_NODE_RESOURCE_CLASS.upper()"},{"line_number":1394,"context_line":"    keys \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_e0b1cb48","line":1391,"updated":"2017-08-15 15:30:10.000000000","message":"Note that just having a CUSTOM_FOO resource doesn\u0027t mean it has the right one that is set on the nodes. I\u0027m assuming this is probably close enough, but it might be worth just checking for the actual RC and/or logging something about \"if you set your own RC I hope you did the flavor too\"","commit_id":"c7f7fcf0e818eacaa24a4aefd58b2c676a67abe5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f43c3143eb2cb5802d26fd78a8cdb2fae47aa7df","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"        if key.startswith(\u0027resources:CUSTOM_\u0027):"},{"line_number":1389,"context_line":"            LOG.warning(\u0027Not updating flavor %s, as it already has a custom \u0027"},{"line_number":1390,"context_line":"                        \u0027resource class %s\u0027, flavor.name, key)"},{"line_number":1391,"context_line":"            return"},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"    rc \u003d DEFAULT_NODE_RESOURCE_CLASS.upper()"},{"line_number":1394,"context_line":"    keys \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_60bb9bc4","line":1391,"in_reply_to":"9f436f4f_e0b1cb48","updated":"2017-08-15 15:39:18.000000000","message":"Done","commit_id":"c7f7fcf0e818eacaa24a4aefd58b2c676a67abe5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ae0e3ad6bb11e6c7375def07fe53b0a329142abf","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"                 node.uuid, DEFAULT_NODE_RESOURCE_CLASS)"},{"line_number":1413,"context_line":"        ironic.node.update(node.uuid,"},{"line_number":1414,"context_line":"                           [{\u0027path\u0027: \u0027/resource_class\u0027, \u0027op\u0027: \u0027add\u0027,"},{"line_number":1415,"context_line":"                             \u0027value\u0027: DEFAULT_NODE_RESOURCE_CLASS}])"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"def _copy_stackrc():"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_a0906396","line":1415,"updated":"2017-08-15 15:30:10.000000000","message":"It looks like you\u0027ll always just use the same RC, so maybe this supports my comment above about checking specifically for the one we\u0027re interested in?","commit_id":"c7f7fcf0e818eacaa24a4aefd58b2c676a67abe5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f43c3143eb2cb5802d26fd78a8cdb2fae47aa7df","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"                 node.uuid, DEFAULT_NODE_RESOURCE_CLASS)"},{"line_number":1413,"context_line":"        ironic.node.update(node.uuid,"},{"line_number":1414,"context_line":"                           [{\u0027path\u0027: \u0027/resource_class\u0027, \u0027op\u0027: \u0027add\u0027,"},{"line_number":1415,"context_line":"                             \u0027value\u0027: DEFAULT_NODE_RESOURCE_CLASS}])"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"def _copy_stackrc():"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_20b113e2","line":1415,"in_reply_to":"9f436f4f_a0906396","updated":"2017-08-15 15:39:18.000000000","message":"Done","commit_id":"c7f7fcf0e818eacaa24a4aefd58b2c676a67abe5"}]}