)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"05e359674b55954652783cdcaf25203dc2b77219","unresolved":false,"context_lines":[{"line_number":14,"context_line":"engine to reduce the support matrix.  This patch includes a post-config"},{"line_number":15,"context_line":"step do so."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I96952f78cb95252d2bc6c0df64561d07df51dc5a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f515b1d_dd47f34b","line":17,"updated":"2017-09-27 21:29:40.000000000","message":"If this change gets a revision it should get a\n\n  Closes-Bug: #1662920","commit_id":"9295d50fc33462de9cecb7bc830817b66d148abb"}],"elements/puppet-stack-config/puppet-stack-config.yaml.template":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"eddcf550163a7eee1df340a66197f25ec4b8d6cc","unresolved":false,"context_lines":[{"line_number":134,"context_line":"heat::engine::trusts_delegated_roles: []"},{"line_number":135,"context_line":"heat::engine::auth_encryption_key: {{UNDERCLOUD_HEAT_ENCRYPTION_KEY}}"},{"line_number":136,"context_line":"heat::engine::max_resources_per_stack: -1"},{"line_number":137,"context_line":"heat::engine::convergence_engine: false"},{"line_number":138,"context_line":"# NOTE(trown): We need to give heat engine more workers because we are throwing huge"},{"line_number":139,"context_line":"# nested stacks at it for the deploy. By not setting this, we get the heat default,"},{"line_number":140,"context_line":"# which is max(#CPUs,4)."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5f2577a7_3702b80c","side":"PARENT","line":137,"updated":"2017-09-14 16:18:23.000000000","message":"It might be worth setting this to true for a full cycle before removing the entry, just in case people want to switch it back to false to debug any issues we find","commit_id":"6c3ca0cf579d752e5b4946301b646894a9d2b85d"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c69bfd9079f21bdfa65bc3916c39afff6f930171","unresolved":false,"context_lines":[{"line_number":134,"context_line":"heat::engine::trusts_delegated_roles: []"},{"line_number":135,"context_line":"heat::engine::auth_encryption_key: {{UNDERCLOUD_HEAT_ENCRYPTION_KEY}}"},{"line_number":136,"context_line":"heat::engine::max_resources_per_stack: -1"},{"line_number":137,"context_line":"heat::engine::convergence_engine: false"},{"line_number":138,"context_line":"# NOTE(trown): We need to give heat engine more workers because we are throwing huge"},{"line_number":139,"context_line":"# nested stacks at it for the deploy. By not setting this, we get the heat default,"},{"line_number":140,"context_line":"# which is max(#CPUs,4)."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bf57530f_f9e11fd2","side":"PARENT","line":137,"in_reply_to":"5f2577a7_3702b80c","updated":"2017-09-20 20:59:19.000000000","message":"Done","commit_id":"6c3ca0cf579d752e5b4946301b646894a9d2b85d"}],"instack_undercloud/undercloud.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"4a520bef9f25c0c6c718066606a34fa750ad0e81","unresolved":false,"context_lines":[{"line_number":1673,"context_line":"        LOG.info(\u0027Migrating stack \"%s\" to convergence engine\u0027, stack.id)"},{"line_number":1674,"context_line":"        args \u003d [\u0027sudo\u0027, \u0027heat-manage\u0027, \u0027migrate_convergence_1\u0027, stack.id]"},{"line_number":1675,"context_line":"        _run_command(args, name\u003d\u0027heat-manage\u0027)"},{"line_number":1676,"context_line":"        LOG.info(\u0027Finished migrating stack \"%s\"\u0027, stack.id)"},{"line_number":1677,"context_line":""},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"def _post_config(instack_env, upgrade):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_bb28e633","line":1676,"updated":"2017-09-26 21:35:39.000000000","message":"It\u0027s worth noting that this will fail if the stack is not in a COMPLETE state prior to migration.\n\nGiven that we have to document how to do it anyway, to me it\u0027s a toss-up whether we should still try to do this automatically.","commit_id":"6f06379a2d5ed8c3478753a858f6611061f904ce"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"28ae89a3005ea6bb1425ce61956e699e37f33600","unresolved":false,"context_lines":[{"line_number":1673,"context_line":"        LOG.info(\u0027Migrating stack \"%s\" to convergence engine\u0027, stack.id)"},{"line_number":1674,"context_line":"        args \u003d [\u0027sudo\u0027, \u0027heat-manage\u0027, \u0027migrate_convergence_1\u0027, stack.id]"},{"line_number":1675,"context_line":"        _run_command(args, name\u003d\u0027heat-manage\u0027)"},{"line_number":1676,"context_line":"        LOG.info(\u0027Finished migrating stack \"%s\"\u0027, stack.id)"},{"line_number":1677,"context_line":""},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"def _post_config(instack_env, upgrade):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_15b0c5dc","line":1676,"in_reply_to":"7f515b1d_bb28e633","updated":"2017-09-27 19:53:15.000000000","message":"Hmm, that could be tricky.  The pre-upgrade validation checks for a complete state: https://github.com/openstack/tripleo-validations/blob/master/validations/stack-health.yaml but technically the validations are optional and I don\u0027t think we explicitly document anywhere that the stack should be in a complete state before attempting an upgrade.  We should probably do that.\n\nIf this gets run against a non-complete stack, the command would fail and we\u0027d stop here, right?  Maybe we need to add a mandatory validation before even attempting the upgrade to verify that the stack will be able to get migrated?  I think we want to enforce that everyone be on convergence in this release.","commit_id":"6f06379a2d5ed8c3478753a858f6611061f904ce"}]}