)]}'
{"instack_undercloud/undercloud.py":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"4491b15ff9fae6fa999df7ccdbe155982bdd22bc","unresolved":false,"context_lines":[{"line_number":115,"context_line":"REQUIRED_MB \u003d 7680"},{"line_number":116,"context_line":"# Control plane network name"},{"line_number":117,"context_line":"PHYSICAL_NETWORK \u003d \u0027ctlplane\u0027"},{"line_number":118,"context_line":"CTLPLANE_SUBNET_NAME \u003d \u0027ctlplane\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# When adding new options to the lists below, make sure to regenerate the"},{"line_number":121,"context_line":"# sample config by running \"tox -e genconfig\" in the project root."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_82db68eb","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":33},"updated":"2018-01-15 20:35:20.000000000","message":"Should this be \u0027ctlplane-subnet\u0027?","commit_id":"d3b9eab2135003e1a963ce0aaa127ee72477fd81"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4cc33dd4f44ba919c35e11e423b671937222e7dc","unresolved":false,"context_lines":[{"line_number":115,"context_line":"REQUIRED_MB \u003d 7680"},{"line_number":116,"context_line":"# Control plane network name"},{"line_number":117,"context_line":"PHYSICAL_NETWORK \u003d \u0027ctlplane\u0027"},{"line_number":118,"context_line":"CTLPLANE_SUBNET_NAME \u003d \u0027ctlplane\u0027"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# When adding new options to the lists below, make sure to regenerate the"},{"line_number":121,"context_line":"# sample config by running \"tox -e genconfig\" in the project root."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_bdb6c9f9","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":33},"in_reply_to":"7f96bb07_82db68eb","updated":"2018-01-15 20:49:39.000000000","message":"oops. Yes it should.","commit_id":"d3b9eab2135003e1a963ce0aaa127ee72477fd81"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"4491b15ff9fae6fa999df7ccdbe155982bdd22bc","unresolved":false,"context_lines":[{"line_number":1971,"context_line":"                                        CTLPLANE_SUBNET_NAME)"},{"line_number":1972,"context_line":""},{"line_number":1973,"context_line":"    # If the subnet is IPv6 we need to start a router so that router"},{"line_number":1974,"context_line":"    # advertisments are sent out for statless IP addressing to work."},{"line_number":1975,"context_line":"    if \u0027:\u0027 in CONF.dhcp_start:"},{"line_number":1976,"context_line":"        _ensure_neutron_router(client_conn, CTLPLANE_SUBNET_NAME, subnet.id)"},{"line_number":1977,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_a2d6a4c2","line":1974,"range":{"start_line":1974,"start_character":37,"end_line":1974,"end_character":45},"updated":"2018-01-15 20:35:20.000000000","message":"Nit - typo (stateless)","commit_id":"d3b9eab2135003e1a963ce0aaa127ee72477fd81"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4cc33dd4f44ba919c35e11e423b671937222e7dc","unresolved":false,"context_lines":[{"line_number":1971,"context_line":"                                        CTLPLANE_SUBNET_NAME)"},{"line_number":1972,"context_line":""},{"line_number":1973,"context_line":"    # If the subnet is IPv6 we need to start a router so that router"},{"line_number":1974,"context_line":"    # advertisments are sent out for statless IP addressing to work."},{"line_number":1975,"context_line":"    if \u0027:\u0027 in CONF.dhcp_start:"},{"line_number":1976,"context_line":"        _ensure_neutron_router(client_conn, CTLPLANE_SUBNET_NAME, subnet.id)"},{"line_number":1977,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_7dd04120","line":1974,"range":{"start_line":1974,"start_character":37,"end_line":1974,"end_character":45},"in_reply_to":"7f96bb07_a2d6a4c2","updated":"2018-01-15 20:49:39.000000000","message":"Done","commit_id":"d3b9eab2135003e1a963ce0aaa127ee72477fd81"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"b7bf81207d17308c12f6234edd4228ff39509e66","unresolved":false,"context_lines":[{"line_number":1946,"context_line":"    try:"},{"line_number":1947,"context_line":"        subnet \u003d list(sdk.network.subnets(cidr\u003dcidr, network_id\u003dnetwork_id))"},{"line_number":1948,"context_line":"    except Exception:"},{"line_number":1949,"context_line":"        raise"},{"line_number":1950,"context_line":""},{"line_number":1951,"context_line":"    return False if not subnet else subnet[0]"},{"line_number":1952,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_d77d14e8","line":1949,"updated":"2018-02-05 14:40:10.000000000","message":"Missing log line here?  Otherwise the except/raise seems unnecessary?","commit_id":"a7d289109d86277006d46194db6413fdadad4074"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5bc6c6e4f3fc75c26227d8ac290cd1f33ce52110","unresolved":false,"context_lines":[{"line_number":1946,"context_line":"    try:"},{"line_number":1947,"context_line":"        subnet \u003d list(sdk.network.subnets(cidr\u003dcidr, network_id\u003dnetwork_id))"},{"line_number":1948,"context_line":"    except Exception:"},{"line_number":1949,"context_line":"        raise"},{"line_number":1950,"context_line":""},{"line_number":1951,"context_line":"    return False if not subnet else subnet[0]"},{"line_number":1952,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_a204c8c7","line":1949,"in_reply_to":"3fa0c359_d77d14e8","updated":"2018-02-05 15:00:25.000000000","message":"Ack. I\u0027ll take a note of this and do a follow up.","commit_id":"a7d289109d86277006d46194db6413fdadad4074"}]}