)]}'
{"id":"openstack%2Finstack-undercloud~662488","triplet_id":"openstack%2Finstack-undercloud~stable%2Fqueens~I96f5e4e51947da6919724d8ffb8531b8ecf87ff8","project":"openstack/instack-undercloud","branch":"stable/queens","topic":"bug/1831253","hashtags":[],"change_id":"I96f5e4e51947da6919724d8ffb8531b8ecf87ff8","subject":"[queens-only] Rename the systemctl-daemon-reload exec","status":"MERGED","created":"2019-05-31 14:37:51.000000000","updated":"2019-07-30 23:41:34.000000000","submitted":"2019-05-31 22:38:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"662488-1559342299813-61dee02a","meta_rev_id":"1ab2a289f32115efa8d1c206b0adda07e5a82589","_number":662488,"virtual_id_number":662488,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-05-31 22:38:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-31 17:01:49.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-31 14:51:34.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-31 14:51:34.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-31 14:51:34.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-05-31 17:01:49.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-31 22:38:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"87961192b9f4af23c0e1504eadd43b740db566cb","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-05-31 14:37:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"98ae0a677cca9f9dc51b28f24d9082f1e4bead0c","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-05-31 14:51:34.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0d4027d5c15bd380ea26f56c7e3557aad3f37392","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-05-31 17:01:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/88/662488/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/731ec13/ : SUCCESS in 2h 16m 57s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/88/662488/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/a286297/ : SUCCESS in 2h 04m 39s","accounts_in_message":[],"_revision_number":1},{"id":"9ee94def629e654570ed25f8e6aa11b6a99683b6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-31 18:59:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/88/662488/1/check/puppet-openstack-lint/724aa62/ : SUCCESS in 3m 42s\n- puppet-openstack-syntax-4 http://logs.openstack.org/88/662488/1/check/puppet-openstack-syntax-4/b3ba13b/ : SUCCESS in 6m 36s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/88/662488/1/check/tripleo-ci-centos-7-undercloud-oooq/f1c8ef4/ : SUCCESS in 1h 10m 40s\n- tripleo-ci-centos-7-undercloud-upgrades http://logs.openstack.org/88/662488/1/check/tripleo-ci-centos-7-undercloud-upgrades/71eb109/ : SUCCESS in 1h 11m 11s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/88/662488/1/check/tripleo-ci-centos-7-containers-multinode/3ef6188/ : SUCCESS in 1h 58m 53s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/88/662488/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/0ba4cb0/ : FAILURE in 1h 52m 02s (non-voting)\n- openstack-tox-pep8 http://logs.openstack.org/88/662488/1/check/openstack-tox-pep8/a884524/ : SUCCESS in 2m 51s\n- openstack-tox-py27 http://logs.openstack.org/88/662488/1/check/openstack-tox-py27/82aa0db/ : SUCCESS in 3m 36s\n- openstack-tox-py35 http://logs.openstack.org/88/662488/1/check/openstack-tox-py35/dd928a3/ : SUCCESS in 3m 47s\n- openstack-tox-cover http://logs.openstack.org/88/662488/1/check/openstack-tox-cover/a45e5b8/cover/ : SUCCESS in 4m 35s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2447035a50514f94f78771514c112f2e47db7b95","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-31 19:00:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"bb540144b96fb636997c8c461de9906e196460a5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-31 22:38:19.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/88/662488/1/gate/puppet-openstack-lint/ae580a3/ : SUCCESS in 6m 14s\n- puppet-openstack-syntax-4 http://logs.openstack.org/88/662488/1/gate/puppet-openstack-syntax-4/3cdd6a9/ : SUCCESS in 3m 38s\n- tripleo-ci-centos-7-undercloud-oooq http://logs.openstack.org/88/662488/1/gate/tripleo-ci-centos-7-undercloud-oooq/38b0462/ : SUCCESS in 1h 12m 08s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/88/662488/1/gate/tripleo-ci-centos-7-containers-multinode/1d5accb/ : SUCCESS in 1h 46m 48s\n- openstack-tox-pep8 http://logs.openstack.org/88/662488/1/gate/openstack-tox-pep8/bf328f6/ : SUCCESS in 2m 49s\n- openstack-tox-py27 http://logs.openstack.org/88/662488/1/gate/openstack-tox-py27/154f793/ : SUCCESS in 2m 54s\n- openstack-tox-py35 http://logs.openstack.org/88/662488/1/gate/openstack-tox-py35/ddd4932/ : SUCCESS in 3m 09s","accounts_in_message":[],"_revision_number":1},{"id":"99ec4998f36f19858c64738b1e3471d7f59b6656","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-31 22:38:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"e71fca987dbb20571939102451a19b2ae9c64663","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-07-30 23:41:34.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit 764aaf6a5cfc6906e673322fac82d7b58419907e","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d12465b4a0134a2ecc0d5e5d9fb96cf55a730b6e","revisions":{"d12465b4a0134a2ecc0d5e5d9fb96cf55a730b6e":{"kind":"REWORK","_number":1,"created":"2019-05-31 14:37:51.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/88/662488/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/instack-undercloud","ref":"refs/changes/88/662488/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/instack-undercloud refs/changes/88/662488/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/instack-undercloud refs/changes/88/662488/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/instack-undercloud refs/changes/88/662488/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/instack-undercloud refs/changes/88/662488/1"}}},"commit":{"parents":[{"commit":"d381995a8c93f299e96d3da995d9488edc84e184","subject":"Merge \"Get the stack name if possible before running the validations group\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/instack-undercloud/commit/d381995a8c93f299e96d3da995d9488edc84e184"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-05-31 14:33:34.000000000","tz":120},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-05-31 14:33:34.000000000","tz":120},"subject":"[queens-only] Rename the systemctl-daemon-reload exec","message":"[queens-only] Rename the systemctl-daemon-reload exec\n\nWhile rebasing puppet-rabbitmq due to other reasons, I noticed that the\nundercloud (re) deploy would fail with:\n\n2019-05-31 09:59:00,919 INFO: Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Exec[systemctl-daemon-reload] is already declared in file /etc/puppet/manifests/puppet-stack-config.pp:99; cannot redeclare at /etc/puppet/modules/systemd/manifests/systemctl/daemon_reload.pp:5 at /etc/puppet/modules/systemd/manifests/systemctl/daemon_reload.pp:5:3 at /etc/puppet/modules/rabbitmq/manifests/config.pp:231 on node undercloud-0.redhat.local\n2019-05-31 09:59:00,982 INFO: + rc\u003d1\n\nThis is because a newer puppet-rabbitmq introduced:\n+\n+ if $::facts[\u0027systemd\u0027] {\n+ Class[\u0027systemd::systemctl::daemon_reload\u0027] -\u003e Service[\u0027rabbitmq-server\u0027]\n+ }\n   }\n\nWhich then pulls in the exec called \u0027systemctl-daemon-reload\u0027 from the\nsystemd module which conflicts with the same call we do in undercloud\npuppet manifest.\nLet\u0027s just rename this exact to \u0027systemctl-daemon-undercloud\u0027 so we do\nnot duplicate this resource ever. Tested this on a queens undercloud\nwith a puppet-rabbitmq that triggers the problematic exec and got a\ncorrectly redeployed undercloud.\n\nWe could have used the systemd module instead but that might require\nother backports and this seems the smallest possible approach to solve\nthis.\n\nChange-Id: I96f5e4e51947da6919724d8ffb8531b8ecf87ff8\nCloses-Bug: #1831253\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/instack-undercloud/commit/d12465b4a0134a2ecc0d5e5d9fb96cf55a730b6e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/instack-undercloud/commit/d12465b4a0134a2ecc0d5e5d9fb96cf55a730b6e"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}