)]}'
{"elements/puppet-stack-config/puppet-stack-config.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"22ad60a0ef279d5ca92dc53ff0b7c0bf5f9435e7","unresolved":false,"context_lines":[{"line_number":422,"context_line":"  bridge_mappings \u003d\u003e split(hiera(\u0027neutron_bridge_mappings\u0027), \u0027,\u0027),"},{"line_number":423,"context_line":"}"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"if str2bool(hiera(\u0027enable_telemetry\u0027, true)) {"},{"line_number":426,"context_line":"  neutron_config {"},{"line_number":427,"context_line":"    \u0027DEFAULT/notification_driver\u0027: value \u003d\u003e \u0027messaging\u0027;"},{"line_number":428,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7faddb67_3115ae3d","line":425,"updated":"2019-08-05 23:28:59.000000000","message":"Actually we likely want to set this via hieradata since it\u0027s a default parameter to most classes.  You can do if conditions in the .yaml using mustache","commit_id":"66a0156fcd1c7a20bcef803badf6cfa06c6636ea"}],"instack_undercloud/undercloud.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5ce81a46b22373bb06a60956cb409e74d6362d32","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"        inspection_kernel_args.append(\u0027ipa-collect-lldp\u003d1\u0027)"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"    # set notification driver based on if we\u0027re using telemetry or not"},{"line_number":1399,"context_line":"    if CONF.enable_telemetry:"},{"line_number":1400,"context_line":"        instack_env[\u0027NOTIFICATION_DRIVER\u0027] \u003d \u0027messaging\u0027"},{"line_number":1401,"context_line":"    else:"},{"line_number":1402,"context_line":"        instack_env[\u0027NOTIFICATION_DRIVER\u0027] \u003d \u0027noop\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_9a510811","line":1399,"updated":"2019-08-06 19:57:13.000000000","message":"I would also add a docstring in enable_telemetry to document the impact of disabling (or enabling) telemetry, on the notification driver.","commit_id":"a25d393cddb1a0be0912bc6052ae9b8c88c7786f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"da8737dd2eae1444ddb0c1c874cffa051d5053ee","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"        inspection_kernel_args.append(\u0027ipa-collect-lldp\u003d1\u0027)"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"    # set notification driver based on if we\u0027re using telemetry or not"},{"line_number":1399,"context_line":"    if CONF.enable_telemetry:"},{"line_number":1400,"context_line":"        instack_env[\u0027NOTIFICATION_DRIVER\u0027] \u003d \u0027messaging\u0027"},{"line_number":1401,"context_line":"    else:"},{"line_number":1402,"context_line":"        instack_env[\u0027NOTIFICATION_DRIVER\u0027] \u003d \u0027noop\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_ba2ba492","line":1399,"in_reply_to":"7faddb67_9a510811","updated":"2019-08-06 20:41:21.000000000","message":"afaik ceilometer is the only consumer of the notification driver stuff. I\u0027ll add a note but I don\u0027t think it\u0027s something the person installing the undercloud needs to be aware of.","commit_id":"a25d393cddb1a0be0912bc6052ae9b8c88c7786f"}]}