)]}'
{"id":"openstack%2Finstack-undercloud~676821","triplet_id":"openstack%2Finstack-undercloud~stable%2Fqueens~I75441352c29b0421358fc0c87f8708355e7fbb2a","project":"openstack/instack-undercloud","branch":"stable/queens","topic":"bug/1838828","hashtags":[],"change_id":"I75441352c29b0421358fc0c87f8708355e7fbb2a","subject":"Set notification driver to noop when enable_telemetry\u003dfalse","status":"MERGED","created":"2019-08-15 20:43:49.000000000","updated":"2019-08-16 17:48:19.000000000","submitted":"2019-08-16 17:48:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676821-1565977699110-ed945153","meta_rev_id":"3c265e3196b57c672a0d45d0d3264af4143fc088","_number":676821,"virtual_id_number":676821,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-16 17:48:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-15 23:46:11.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-16 15:21:20.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-16 15:21:20.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"date":"2019-08-15 20:43:49.000000000","_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-15 20:43:49.000000000","updated_by":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"reviewer":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"state":"REVIEWER"},{"updated":"2019-08-15 23:46:11.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-16 15:21:20.000000000","updated_by":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"reviewer":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"state":"REVIEWER"},{"updated":"2019-08-16 17:48:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c6af0541733090afc2a8006dce0024ac8bf59f8a","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-15 20:43:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"556d537a1989fe07f12c6f54f829ce61993476e8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 22:54:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/14c26bc92dd745b19d1ca24ac8f97f15 : SUCCESS in 4m 56s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/3b0596f9177841bfb56492f329a67bdf : SUCCESS in 5m 09s\n- tripleo-ci-centos-7-undercloud-oooq https://zuul.opendev.org/t/openstack/build/0422a1db4b0a40278f3e560b94c2859f : SUCCESS in 1h 13m 48s\n- tripleo-ci-centos-7-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/46f104a9132e4923be653d35cfd8d99a : SUCCESS in 1h 24m 24s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/4300872a5089482682cfda99fe34978b : SUCCESS in 2h 07m 49s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/5c208cc4ca694c29af9520e158dc2952 : FAILURE in 2h 08m 00s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d5e848e062d04e6f8382de594d77c5a0 : SUCCESS in 3m 25s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/cde7c760ba7b414ea6fae34a38c59f76 : SUCCESS in 4m 31s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/0c302b1f5666403da7295937be46eb22 : SUCCESS in 4m 15s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/477c061a7786415d9aa8b79f52ac5c83 : SUCCESS in 4m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6034ac346cb11835f0470a36ce1723085896bbf4","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-08-15 23:46:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/21/676821/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/c1646d9/ : SUCCESS in 3h 01m 46s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/21/676821/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/fcdf513/ : SUCCESS in 2h 20m 29s","accounts_in_message":[],"_revision_number":1},{"id":"0b27d88f9a5790294af639216a4fe7b1bea159e5","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2019-08-16 15:21:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e8fcadb9255e122f31e993d891acf8f58c55f1c3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 15:21:35.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5899f0800145031a58d586b82115cff35f70bb3d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 17:48:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/7bb5bcd4058d45cf96f2f8230ed74440 : SUCCESS in 8m 06s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/a5e33552e0d84a8b8f806e6f7e969b89 : SUCCESS in 5m 53s\n- tripleo-ci-centos-7-undercloud-oooq https://zuul.opendev.org/t/openstack/build/a86db1877343452bb9bea558feae02b3 : SUCCESS in 1h 22m 38s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/2d94deb87178427f89a206afa7bd02ba : SUCCESS in 2h 12m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f189240977a8495b9a5f22e5d651d3ea : SUCCESS in 4m 52s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/38a52f7430c84c389cf50c260440d672 : SUCCESS in 4m 37s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/9fd59f5b8f6147e79c06a2909295af47 : SUCCESS in 3m 32s","accounts_in_message":[],"_revision_number":1},{"id":"b641fff5e14b8e56f1175cd1c59448c2b3d61679","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 17:48:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3e1125cc7266afb938965d07f1c4341cde685e0a","revisions":{"3e1125cc7266afb938965d07f1c4341cde685e0a":{"kind":"REWORK","_number":1,"created":"2019-08-15 20:43:49.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/21/676821/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/instack-undercloud","ref":"refs/changes/21/676821/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/instack-undercloud refs/changes/21/676821/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/instack-undercloud refs/changes/21/676821/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/instack-undercloud refs/changes/21/676821/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/instack-undercloud refs/changes/21/676821/1"}}},"commit":{"parents":[{"commit":"3d17c6d6856f99e3792633a8bad87876b83d121c","subject":"Quote controller_public_host_wrapped","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/instack-undercloud/commit/3d17c6d6856f99e3792633a8bad87876b83d121c"}]}],"author":{"name":"David Hill","email":"dhill@redhat.com","date":"2019-08-02 02:52:59.000000000","tz":-240},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-15 20:43:24.000000000","tz":-360},"subject":"Set notification driver to noop when enable_telemetry\u003dfalse","message":"Set notification driver to noop when enable_telemetry\u003dfalse\n\nActually, enable_telemetry\u003dfalse doesn\u0027t do anything because\nthe notification_drivers values are hardcoded to messaging.\nThis commit changes this behavior by setting notification_drivers\nto noop if enable_telemetry is set to false.\n\nConflicts:\n\telements/puppet-stack-config/puppet-stack-config.yaml.template\n\nChange-Id: I75441352c29b0421358fc0c87f8708355e7fbb2a\nCloses-bug: #1838828\nCo-Authored-By: Alex Schultz \u003caschultz@redhat.com\u003e\n(cherry picked from commit 8b6d68d13fab7cf28388d7e48f2b89be2c8932e8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/instack-undercloud/commit/3e1125cc7266afb938965d07f1c4341cde685e0a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/instack-undercloud/commit/3e1125cc7266afb938965d07f1c4341cde685e0a"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}