)]}'
{"specs/etcd-coordination.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"cb2310af4b948ac468027ad55f7c1470f1ff2c72","unresolved":false,"context_lines":[{"line_number":21,"context_line":"splitted into two services both running under ``oslo.service``, namely"},{"line_number":22,"context_line":"``ironic_inspector`` and ``ironic-inspector-conductor``."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"To split two services into two processes, we need to address existing"},{"line_number":25,"context_line":"functional test issue before we can split two services into respective"},{"line_number":26,"context_line":"executables. Currently the functional test uses fake messaging driver"},{"line_number":27,"context_line":"which only works for single process, we can either add rabbitmq support"},{"line_number":28,"context_line":"for functional test env or introduce another messaging mechanism like"},{"line_number":29,"context_line":"``json-rpc``, but the first solution is not desirable."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_7d84ee5e","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":11},"updated":"2019-04-16 08:17:48.000000000","message":"nit: maybe rewrite this as there\u0027s a repetition between beginning and end of the phrase","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"cb2310af4b948ac468027ad55f7c1470f1ff2c72","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"As etcd is already a base service for the OpenStack platform, the spec"},{"line_number":41,"context_line":"proposes to add ``python-etcd3`` and ``tooz`` as project requirements for the"},{"line_number":42,"context_line":"service coordination. ``tooz`` provides several feature encapsulations like"},{"line_number":43,"context_line":"group management, locking, etc. Group management is only implemented for ETCD"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_bdc9f678","line":40,"range":{"start_line":40,"start_character":3,"end_line":40,"end_character":7},"updated":"2019-04-16 08:17:48.000000000","message":"would add a short introduction sentence about etcd","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6032a28a3292bcefad5e3b11713b42a2dbeea1d8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"As etcd is already a base service for the OpenStack platform, the spec"},{"line_number":41,"context_line":"proposes to add ``python-etcd3`` and ``tooz`` as project requirements for the"},{"line_number":42,"context_line":"service coordination. ``tooz`` provides several feature encapsulations like"},{"line_number":43,"context_line":"group management, locking, etc. Group management is only implemented for ETCD"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfbec78f_df2e36f9","line":40,"range":{"start_line":40,"start_character":3,"end_line":40,"end_character":7},"in_reply_to":"3fce034c_bdc9f678","updated":"2019-05-08 06:49:19.000000000","message":"Done","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"cb2310af4b948ac468027ad55f7c1470f1ff2c72","unresolved":false,"context_lines":[{"line_number":50,"context_line":"#. Create a coordinator with hostname"},{"line_number":51,"context_line":"#. Create a group \"ironic-inspector-service-group\", bypass if the group"},{"line_number":52,"context_line":"   already exists."},{"line_number":53,"context_line":"#. Query query group members upon API request, randomly pick one conductor,"},{"line_number":54,"context_line":"   generate topic according to hostname and send rpc request."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The example workflow for ironic-inspector conductor service:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_bd6d7699","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":14},"updated":"2019-04-16 08:17:48.000000000","message":"nit: remove one \"query\" word","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6032a28a3292bcefad5e3b11713b42a2dbeea1d8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"#. Create a coordinator with hostname"},{"line_number":51,"context_line":"#. Create a group \"ironic-inspector-service-group\", bypass if the group"},{"line_number":52,"context_line":"   already exists."},{"line_number":53,"context_line":"#. Query query group members upon API request, randomly pick one conductor,"},{"line_number":54,"context_line":"   generate topic according to hostname and send rpc request."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The example workflow for ironic-inspector conductor service:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfbec78f_1fc12e2f","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":14},"in_reply_to":"3fce034c_bd6d7699","updated":"2019-05-08 06:49:19.000000000","message":"Done","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"cb2310af4b948ac468027ad55f7c1470f1ff2c72","unresolved":false,"context_lines":[{"line_number":56,"context_line":"The example workflow for ironic-inspector conductor service:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#. Create a coordinator with hostname"},{"line_number":59,"context_line":"#. Join group \"ironic-inspector-service-group\", create and join if the"},{"line_number":60,"context_line":"   group does not exist."},{"line_number":61,"context_line":"#. Leaving group explicitly when service is shutdown."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_bdf016cb","line":59,"range":{"start_line":59,"start_character":15,"end_line":59,"end_character":45},"updated":"2019-04-16 08:17:48.000000000","message":"same group as API ?","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6ec1519ffceb439114b177bb0e798700a91c3c77","unresolved":false,"context_lines":[{"line_number":56,"context_line":"The example workflow for ironic-inspector conductor service:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#. Create a coordinator with hostname"},{"line_number":59,"context_line":"#. Join group \"ironic-inspector-service-group\", create and join if the"},{"line_number":60,"context_line":"   group does not exist."},{"line_number":61,"context_line":"#. Leaving group explicitly when service is shutdown."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_80be1163","line":59,"range":{"start_line":59,"start_character":15,"end_line":59,"end_character":45},"in_reply_to":"3fce034c_bdf016cb","updated":"2019-04-16 09:07:58.000000000","message":"right, the same group, so that api service will know how many conductor services there.","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"cb2310af4b948ac468027ad55f7c1470f1ff2c72","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Alternatives"},{"line_number":68,"context_line":"------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Though it\u0027s totally workable to utilize database as the the coordination"},{"line_number":71,"context_line":"source just like ironic, it would be much lighter if implemented with tooz."},{"line_number":72,"context_line":"tooz also supports multiple backends, which brings more possibilities in"},{"line_number":73,"context_line":"deployement."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_3ddd0642","line":70,"range":{"start_line":70,"start_character":52,"end_line":70,"end_character":59},"updated":"2019-04-16 08:17:48.000000000","message":"nit: remove one \"the\" word","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6032a28a3292bcefad5e3b11713b42a2dbeea1d8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Alternatives"},{"line_number":68,"context_line":"------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Though it\u0027s totally workable to utilize database as the the coordination"},{"line_number":71,"context_line":"source just like ironic, it would be much lighter if implemented with tooz."},{"line_number":72,"context_line":"tooz also supports multiple backends, which brings more possibilities in"},{"line_number":73,"context_line":"deployement."}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfbec78f_5fc7a646","line":70,"range":{"start_line":70,"start_character":52,"end_line":70,"end_character":59},"in_reply_to":"3fce034c_3ddd0642","updated":"2019-05-08 06:49:19.000000000","message":"Done","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"cb2310af4b948ac468027ad55f7c1470f1ff2c72","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Deployer impact"},{"line_number":112,"context_line":"---------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"A new configuration section ``etcd`` with options below will be added to"},{"line_number":115,"context_line":"support etcd operation:"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* ``host`` and ``port``: specify the etcd service endpoint."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_9da43abb","line":114,"range":{"start_line":114,"start_character":42,"end_line":114,"end_character":55},"updated":"2019-04-16 08:17:48.000000000","message":"s/options below/the following options","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6032a28a3292bcefad5e3b11713b42a2dbeea1d8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Deployer impact"},{"line_number":112,"context_line":"---------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"A new configuration section ``etcd`` with options below will be added to"},{"line_number":115,"context_line":"support etcd operation:"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* ``host`` and ``port``: specify the etcd service endpoint."}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfbec78f_3fcc3269","line":114,"range":{"start_line":114,"start_character":42,"end_line":114,"end_character":55},"in_reply_to":"3fce034c_9da43abb","updated":"2019-05-08 06:49:19.000000000","message":"Done","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"cb2310af4b948ac468027ad55f7c1470f1ff2c72","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":137,"context_line":"------------------------------------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"After this spec is implemented, etcd v3 will be a mandatory requirement for"},{"line_number":140,"context_line":"inspector service working properly."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_7d8f0e23","line":139,"range":{"start_line":139,"start_character":32,"end_line":139,"end_character":71},"updated":"2019-04-16 08:17:48.000000000","message":"The idea in general is great, I\u0027m just not sure forcing etcd as mandatory requirement to deploy inspector is; do you think it would be possible to make this optional ?","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6ec1519ffceb439114b177bb0e798700a91c3c77","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":137,"context_line":"------------------------------------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"After this spec is implemented, etcd v3 will be a mandatory requirement for"},{"line_number":140,"context_line":"inspector service working properly."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_9302e908","line":139,"range":{"start_line":139,"start_character":32,"end_line":139,"end_character":71},"in_reply_to":"3fce034c_7d8f0e23","updated":"2019-04-16 09:07:58.000000000","message":"Yeah, that\u0027s the same convern I have, though it probably a light impact on deployment. As I know ubuntu 18.04 already shipped with etcd v3, we barely need to setup anything for simple cases, just install and run for a single host.\n\nWe could implement this based on database, but it seems Dmitry and Julia prefer the etcd way, I\u0027d love to have more thoughts on this.","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f9ddc107fbce79c9a75ed29345521e7e86bc3f0f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":137,"context_line":"------------------------------------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"After this spec is implemented, etcd v3 will be a mandatory requirement for"},{"line_number":140,"context_line":"inspector service working properly."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_b354c5cb","line":139,"range":{"start_line":139,"start_character":32,"end_line":139,"end_character":71},"in_reply_to":"3fce034c_9302e908","updated":"2019-04-16 09:22:19.000000000","message":"etcd is a part of the openstack base services: https://governance.openstack.org/tc/reference/base-services.html#current-list-of-base-services. requiring it should not be a big surprise. we could do it through database, but if you look at the ironic implementation, you\u0027ll see that we invent a lot of things that go for free with etcd.","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4192b897757537b0d614b749b55368ca0ef116d1","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":137,"context_line":"------------------------------------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"After this spec is implemented, etcd v3 will be a mandatory requirement for"},{"line_number":140,"context_line":"inspector service working properly."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_f3732d7f","line":139,"range":{"start_line":139,"start_character":32,"end_line":139,"end_character":71},"in_reply_to":"3fce034c_b354c5cb","updated":"2019-04-16 09:23:40.000000000","message":"another thought: we can keep single-process ironic-inspector working instead of deprecating it as a part of the HA work. this will serve the simplest case. and we can make etcd mandatory when rabbitmq is not used. it will require more code, but will provide an alternative.","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"57bc44a1f45af746c5f9e0340f6a5044b53a733b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":137,"context_line":"------------------------------------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"After this spec is implemented, etcd v3 will be a mandatory requirement for"},{"line_number":140,"context_line":"inspector service working properly."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_fa052bc3","line":139,"range":{"start_line":139,"start_character":32,"end_line":139,"end_character":71},"in_reply_to":"3fce034c_b354c5cb","updated":"2019-04-17 06:05:06.000000000","message":"yup, but it doesn\u0027t say etcd v3 is the minimum version, but we will need etcd3 for the group management feature.\n\ncoreos said \"etcd v2 will no longer be shipped with Container Linux after June 2018.\" It may need some time for the shift.\n\nI don\u0027t know the plan of other linux distributions, but bionic seems ok, this means we have an upstream environment for the implementation, while doesn\u0027t impact existing deployment as long as the etcd implementation is optional.","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"57bc44a1f45af746c5f9e0340f6a5044b53a733b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":137,"context_line":"------------------------------------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"After this spec is implemented, etcd v3 will be a mandatory requirement for"},{"line_number":140,"context_line":"inspector service working properly."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_5a2a3f90","line":139,"range":{"start_line":139,"start_character":32,"end_line":139,"end_character":71},"in_reply_to":"3fce034c_f3732d7f","updated":"2019-04-17 06:05:06.000000000","message":"I am thinking some option like [DEFAULT]standalone (boolean)\n\nwe will have three console scripts after the split:\n\n* ironic-inspector: runs at standalone\u003dTrue, stop otherwise. No etcd dependency.\n* ironic-inspector-api, ironic-inspector-conductor: runs at standalone\u003dFalse, stop otherwise. Requires etcd.\n\nwe can still keep rabbitmq as an alternative for messaging, use [DEFAULT]rpc_backend to control rpc backend, rabbit, json-rpc, etc.\n\nSounds a reverse process of single process ironic heh :)\n\nWe can drop the standalone one at suitable time.","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c0506dc8963bce273aa11cdf688f3be725632acb","unresolved":false,"context_lines":[{"line_number":136,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":137,"context_line":"------------------------------------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"After this spec is implemented, etcd v3 will be a mandatory requirement for"},{"line_number":140,"context_line":"inspector service working properly."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_bd168448","line":139,"range":{"start_line":139,"start_character":32,"end_line":139,"end_character":71},"in_reply_to":"3fce034c_fa052bc3","updated":"2019-04-19 08:51:14.000000000","message":"Thanks Kaifeng and Dmitry for the replies!\nCentOS and Fedora also provide etcd v3 by default, so I wouldn\u0027t worry too much about that.\nAgain, I really like the idea and I\u0027m all for it, definitely etcd \u003e database!\nI know it\u0027s more work, but if I we could keep an alternative at least for a while and then dropping the standalone at some point, would be great.\nThe option alternative sounds good to me :)","commit_id":"2a157e26300be615e8e81fb98774d50a27295afd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a7fd83855025d1a7c0c5391ba1d4934626461996","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#. Create a predefined group, bypass if the group already exists. By default,"},{"line_number":54,"context_line":"   the group name is ``ironic-inspector-service-group``."},{"line_number":55,"context_line":"#. Upon each API request, the API service will query members from the group,"},{"line_number":56,"context_line":"   randomly pick one conductor and deliver the request to it through rpc"},{"line_number":57,"context_line":"   mechanism."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The example workflow for ironic-inspector conductor service is listed below:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_8db533d3","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":13},"updated":"2019-07-03 13:20:28.000000000","message":"Logical I guess. But would this mean that my ironic-inspector cluster would be world wide, or will I be able to operate smaller islands of inspector clusters?","commit_id":"305d08fa1bbe621ef15866190a147a85d9e5c601"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"302fe50277f8826c448baa44854ef9d19802caa0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#. Create a predefined group, bypass if the group already exists. By default,"},{"line_number":54,"context_line":"   the group name is ``ironic-inspector-service-group``."},{"line_number":55,"context_line":"#. Upon each API request, the API service will query members from the group,"},{"line_number":56,"context_line":"   randomly pick one conductor and deliver the request to it through rpc"},{"line_number":57,"context_line":"   mechanism."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The example workflow for ironic-inspector conductor service is listed below:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_2de68eea","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":13},"in_reply_to":"9fb8cfa7_8db533d3","updated":"2019-07-04 03:18:23.000000000","message":"Sorry for not following here, but it sounds like the concept of conductor group if I am guessing right.\nIt could be a further enhancement I guess, we have not considered conductor group though. Our current focus is on the service split, there\u0027s undesired result as the service could only be deployed into a single node, which is not coping well within the same cloud infrastructure.\n\nRecently there is a new requirement due to the lack of etcd service in the cloud, so user don\u0027t want to deploy a new service for inspector and especially from an upgrade. I think it\u0027s still doable with little impact, all we need to do is to implement a db lock mechanism, and utilize messaging queue to load balance rpc requests. I\u0027d like to update the spec to have this proposal if everyone is good with it :)","commit_id":"305d08fa1bbe621ef15866190a147a85d9e5c601"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a7fd83855025d1a7c0c5391ba1d4934626461996","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#. Create a coordinator with hostname"},{"line_number":62,"context_line":"#. Join the predefined group as a member, the group name is"},{"line_number":63,"context_line":"   ``ironic-inspector-service-group`` by default. If the group does not exist,"},{"line_number":64,"context_line":"   it will be created."},{"line_number":65,"context_line":"#. Leave group when service is shutdown."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_4de41be1","line":63,"range":{"start_line":63,"start_character":5,"end_line":63,"end_character":35},"updated":"2019-07-03 13:20:28.000000000","message":"Based on my above comment, maybe and just suggesting this as an idea, that this is made configurable.","commit_id":"305d08fa1bbe621ef15866190a147a85d9e5c601"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"302fe50277f8826c448baa44854ef9d19802caa0","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#. Create a coordinator with hostname"},{"line_number":62,"context_line":"#. Join the predefined group as a member, the group name is"},{"line_number":63,"context_line":"   ``ironic-inspector-service-group`` by default. If the group does not exist,"},{"line_number":64,"context_line":"   it will be created."},{"line_number":65,"context_line":"#. Leave group when service is shutdown."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7faddb67_cdfedaad","line":63,"range":{"start_line":63,"start_character":5,"end_line":63,"end_character":35},"in_reply_to":"9fb8cfa7_4de41be1","updated":"2019-07-04 03:18:23.000000000","message":"Indeed, the configuration option is noted at L147, out of sync with example it appears.","commit_id":"305d08fa1bbe621ef15866190a147a85d9e5c601"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a7fd83855025d1a7c0c5391ba1d4934626461996","unresolved":false,"context_lines":[{"line_number":155,"context_line":"has no impact on the single process ``ironic-inspector``."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"New options introduced in this spec only needs to be configured when ironic"},{"line_number":158,"context_line":"inspector service is running distributedly."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_6d023f72","line":158,"updated":"2019-07-03 13:20:28.000000000","message":"So for a standalone install, they should notice nothing it seems. Sounds good.","commit_id":"305d08fa1bbe621ef15866190a147a85d9e5c601"}]}