)]}'
{"ironic_discoverd/test/test_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac8fd5929266245d91a420fc947bcb7de543b26d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":10,"context_line":"# implied."},{"line_number":11,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":"import sys"},{"line_number":14,"context_line":"import unittest"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_fd800f4b","line":12,"updated":"2015-01-13 21:29:27.000000000","message":"nit: newline here","commit_id":"110d62042c914127291403734074e49180344948"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"f6316fee830e4bdda774976813e6de248c7d9476","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":10,"context_line":"# implied."},{"line_number":11,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":"import sys"},{"line_number":14,"context_line":"import unittest"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_fdbacf6f","line":12,"in_reply_to":"3a961159_fd800f4b","updated":"2015-01-13 22:12:26.000000000","message":"Done","commit_id":"110d62042c914127291403734074e49180344948"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac8fd5929266245d91a420fc947bcb7de543b26d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.name \u003d \u0027member\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class TestUtils(unittest.TestCase):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @mock.patch(\u0027keystoneclient.v2_0.client.Client\u0027)"},{"line_number":52,"context_line":"    def test_admin_token(self, mock_ks):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_fdce4fb6","line":49,"updated":"2015-01-13 21:29:27.000000000","message":"please inherit from base.BaseTest - and test failure under Python 3 should be gone","commit_id":"110d62042c914127291403734074e49180344948"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"f6316fee830e4bdda774976813e6de248c7d9476","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.name \u003d \u0027member\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class TestUtils(unittest.TestCase):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @mock.patch(\u0027keystoneclient.v2_0.client.Client\u0027)"},{"line_number":52,"context_line":"    def test_admin_token(self, mock_ks):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_5db84375","line":49,"in_reply_to":"3a961159_fdce4fb6","updated":"2015-01-13 22:12:26.000000000","message":"Done","commit_id":"110d62042c914127291403734074e49180344948"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac8fd5929266245d91a420fc947bcb7de543b26d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        conf.CONF.set(\u0027discoverd\u0027, \u0027os_tenant_name\u0027, \u0027tenant\u0027)"},{"line_number":54,"context_line":"        conf.CONF.set(\u0027discoverd\u0027, \u0027os_auth_url\u0027, \u0027127.0.0.1\u0027)"},{"line_number":55,"context_line":"        fake_client \u003d FakeClient()"},{"line_number":56,"context_line":"        fake_client.roles \u003d FakeAdminRoleManager()"},{"line_number":57,"context_line":"        mock_ks.return_value \u003d fake_client"},{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            utils.check_is_admin(\u0027token\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_9d61cbd6","line":56,"updated":"2015-01-13 21:29:27.000000000","message":"please try\n\n fake_client \u003d mock_ks.return_value\n fake_client.roles.roles_for_user.return_value \u003d [mock.Mock(name\u003d\u0027admin\u0027)]\n\nthus you won\u0027t need these Fake* classes above","commit_id":"110d62042c914127291403734074e49180344948"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"f6316fee830e4bdda774976813e6de248c7d9476","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        conf.CONF.set(\u0027discoverd\u0027, \u0027os_tenant_name\u0027, \u0027tenant\u0027)"},{"line_number":54,"context_line":"        conf.CONF.set(\u0027discoverd\u0027, \u0027os_auth_url\u0027, \u0027127.0.0.1\u0027)"},{"line_number":55,"context_line":"        fake_client \u003d FakeClient()"},{"line_number":56,"context_line":"        fake_client.roles \u003d FakeAdminRoleManager()"},{"line_number":57,"context_line":"        mock_ks.return_value \u003d fake_client"},{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            utils.check_is_admin(\u0027token\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_4f87aab6","line":56,"in_reply_to":"3a961159_9d61cbd6","updated":"2015-01-13 22:12:26.000000000","message":"Awesome!\nI had to do it slightly differently, because name is a special attribute, but this got me most of the way there.","commit_id":"110d62042c914127291403734074e49180344948"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac8fd5929266245d91a420fc947bcb7de543b26d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        except Exception:"},{"line_number":61,"context_line":"            fail_msg \u003d (\"Unexpected exception: \""},{"line_number":62,"context_line":"                        \"%s: %s\" % (sys.exc_info()[0], sys.exc_info()[1]))"},{"line_number":63,"context_line":"            self.fail(fail_msg)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @mock.patch(\u0027keystoneclient.v2_0.client.Client\u0027)"},{"line_number":66,"context_line":"    def test_non_admin_token(self, mock_ks):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_7d389fd4","line":63,"updated":"2015-01-13 21:29:27.000000000","message":"you don\u0027t need this try..except.. because unexpected exception is a test failure already","commit_id":"110d62042c914127291403734074e49180344948"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"f6316fee830e4bdda774976813e6de248c7d9476","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        except Exception:"},{"line_number":61,"context_line":"            fail_msg \u003d (\"Unexpected exception: \""},{"line_number":62,"context_line":"                        \"%s: %s\" % (sys.exc_info()[0], sys.exc_info()[1]))"},{"line_number":63,"context_line":"            self.fail(fail_msg)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @mock.patch(\u0027keystoneclient.v2_0.client.Client\u0027)"},{"line_number":66,"context_line":"    def test_non_admin_token(self, mock_ks):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_8f9192f3","line":63,"in_reply_to":"3a961159_7d389fd4","updated":"2015-01-13 22:12:26.000000000","message":"Done","commit_id":"110d62042c914127291403734074e49180344948"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac8fd5929266245d91a420fc947bcb7de543b26d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        conf.CONF.set(\u0027discoverd\u0027, \u0027os_tenant_name\u0027, \u0027tenant\u0027)"},{"line_number":68,"context_line":"        conf.CONF.set(\u0027discoverd\u0027, \u0027os_auth_url\u0027, \u0027127.0.0.1\u0027)"},{"line_number":69,"context_line":"        fake_client \u003d FakeClient()"},{"line_number":70,"context_line":"        fake_client.roles \u003d FakeMemberRoleManager()"},{"line_number":71,"context_line":"        self.assertRaises(keystone_exc.Unauthorized,"},{"line_number":72,"context_line":"                          utils.check_is_admin, \u0027token\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_7dadffe9","line":70,"updated":"2015-01-13 21:29:27.000000000","message":"ditto about using mocks instead of Fake*","commit_id":"110d62042c914127291403734074e49180344948"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"f6316fee830e4bdda774976813e6de248c7d9476","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        conf.CONF.set(\u0027discoverd\u0027, \u0027os_tenant_name\u0027, \u0027tenant\u0027)"},{"line_number":68,"context_line":"        conf.CONF.set(\u0027discoverd\u0027, \u0027os_auth_url\u0027, \u0027127.0.0.1\u0027)"},{"line_number":69,"context_line":"        fake_client \u003d FakeClient()"},{"line_number":70,"context_line":"        fake_client.roles \u003d FakeMemberRoleManager()"},{"line_number":71,"context_line":"        self.assertRaises(keystone_exc.Unauthorized,"},{"line_number":72,"context_line":"                          utils.check_is_admin, \u0027token\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_cfbaba70","line":70,"in_reply_to":"3a961159_7dadffe9","updated":"2015-01-13 22:12:26.000000000","message":"Done","commit_id":"110d62042c914127291403734074e49180344948"}],"ironic_discoverd/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09cfc0f0a03f4baf6391d7d06b53f226498c6ca8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    return client.get_client(1, **args)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def get_keystone(token, tenant_name\u003d\"admin\"):  # pragma: no cover"},{"line_number":44,"context_line":"    return keystone.Client(token\u003dtoken,"},{"line_number":45,"context_line":"                           auth_url\u003dconf.get(\u0027discoverd\u0027, \u0027os_auth_url\u0027),"},{"line_number":46,"context_line":"                           tenant_name\u003dtenant_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_e11637a6","line":43,"updated":"2015-01-08 09:44:38.000000000","message":"I think instead of passing tenant_name here, we should have configuration like os_tenant_name","commit_id":"b62937aacd2218d3fe0488466e6ae201f7c8e85a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0febc0e82b125513294d26b156d81eb11a3778db","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    return client.get_client(1, **args)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def is_admin(token):  # pragma: no cover"},{"line_number":45,"context_line":"    # Create a client from the token and auth_url using the admin tenant"},{"line_number":46,"context_line":"    # this will raise keystoneclient.exceptions.Unauthorized if the user does"},{"line_number":47,"context_line":"    # not have the admin role in the admin tenant"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_6715c24b","line":44,"updated":"2015-01-10 10:26:28.000000000","message":"now that this functions carries some logic could you please:\n\n1. write a couple of tests for this code and drop \"# pragma: no cover\"?\n\n2. create a docstring","commit_id":"f7b3f7913ad80d69ef111be4b51f935e82f87f84"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0febc0e82b125513294d26b156d81eb11a3778db","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    # this will raise keystoneclient.exceptions.Unauthorized if the user does"},{"line_number":47,"context_line":"    # not have the admin role in the admin tenant"},{"line_number":48,"context_line":"    kc \u003d keystone.Client(token\u003dtoken,"},{"line_number":49,"context_line":"                         tenant_name\u003d\"admin\","},{"line_number":50,"context_line":"                         auth_url\u003dconf.get(\u0027discoverd\u0027,"},{"line_number":51,"context_line":"                                           \u0027os_auth_url\u0027))"},{"line_number":52,"context_line":"    # Check for admin role on the admin tenant, and raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_0706be21","line":49,"updated":"2015-01-10 10:26:28.000000000","message":"shouldn\u0027t we put this \u0027admin\u0027 string to configuration? like os_tenant_name. or is it always \u0027admin\u0027 for everyone? if so, it\u0027s anyway better to have it as a module level constant","commit_id":"f7b3f7913ad80d69ef111be4b51f935e82f87f84"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0febc0e82b125513294d26b156d81eb11a3778db","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                           tenant\u003dkc.tenant_id)]:"},{"line_number":58,"context_line":"        raise keystone_exc.Unauthorized"},{"line_number":59,"context_line":"    # If we get here we are admin on the admin tenant, so return True"},{"line_number":60,"context_line":"    return True"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def is_valid_mac(address):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_a70faa38","line":60,"updated":"2015-01-10 10:26:28.000000000","message":"I think we don\u0027t need to return anything. actually the function should be called \u0027check_is_admin\u0027 or similar, as we raise an exception in case of failure, not return False.","commit_id":"f7b3f7913ad80d69ef111be4b51f935e82f87f84"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a30f273e0c6749d93a2d5dfc660dbf7fa10d6645","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        the admin role in the tenant provided in the os_tenant_name option."},{"line_number":50,"context_line":"    \"\"\""},{"line_number":51,"context_line":"    kc \u003d keystone.Client(token\u003dtoken,"},{"line_number":52,"context_line":"                         tenant_name\u003dconf.get(\u0027discoverd\u0027, \u0027os_tenant_name\u0027),"},{"line_number":53,"context_line":"                         auth_url\u003dconf.get(\u0027discoverd\u0027, \u0027os_auth_url\u0027))"},{"line_number":54,"context_line":"    if \"admin\" not in [role.name"},{"line_number":55,"context_line":"                       for role in kc.roles.roles_for_user("}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_e41ea95e","line":52,"updated":"2015-01-14 10:01:39.000000000","message":"unfortunately adding tenant_name makes it no longer accept any tokens. investigating...","commit_id":"9c9b7a53e802d22504ce384d2e25dcc18ecb8c23"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"59052a1b3c6a98c95d65a1df5724424393fcd0e5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        the admin role in the tenant provided in the os_tenant_name option."},{"line_number":50,"context_line":"    \"\"\""},{"line_number":51,"context_line":"    kc \u003d keystone.Client(token\u003dtoken,"},{"line_number":52,"context_line":"                         tenant_name\u003dconf.get(\u0027discoverd\u0027, \u0027os_tenant_name\u0027),"},{"line_number":53,"context_line":"                         auth_url\u003dconf.get(\u0027discoverd\u0027, \u0027os_auth_url\u0027))"},{"line_number":54,"context_line":"    if \"admin\" not in [role.name"},{"line_number":55,"context_line":"                       for role in kc.roles.roles_for_user("}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_d0d79c21","line":52,"in_reply_to":"3a961159_24cfd158","updated":"2015-01-14 15:24:51.000000000","message":"Done","commit_id":"9c9b7a53e802d22504ce384d2e25dcc18ecb8c23"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e0de59059bbd29cd8c14779eb699bf5d471008fd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        the admin role in the tenant provided in the os_tenant_name option."},{"line_number":50,"context_line":"    \"\"\""},{"line_number":51,"context_line":"    kc \u003d keystone.Client(token\u003dtoken,"},{"line_number":52,"context_line":"                         tenant_name\u003dconf.get(\u0027discoverd\u0027, \u0027os_tenant_name\u0027),"},{"line_number":53,"context_line":"                         auth_url\u003dconf.get(\u0027discoverd\u0027, \u0027os_auth_url\u0027))"},{"line_number":54,"context_line":"    if \"admin\" not in [role.name"},{"line_number":55,"context_line":"                       for role in kc.roles.roles_for_user("}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_24cfd158","line":52,"in_reply_to":"3a961159_e41ea95e","updated":"2015-01-14 10:13:17.000000000","message":"ok, seems like I was wrong and conf.get(\u0027discoverd\u0027, \u0027os_tenant_name\u0027) should not be passed here, because e.g. on instack, it\u0027s not \u0027admin\u0027, it\u0027s special tenant \u0027service\u0027. looks like we need a new configuration option like \u0027admin_tenant_name\u0027 defaulting to \u0027admin\u0027 to be used here.\n\nIf I change tenant_name to \u0027admin\u0027 here, it seems to work.","commit_id":"9c9b7a53e802d22504ce384d2e25dcc18ecb8c23"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a30f273e0c6749d93a2d5dfc660dbf7fa10d6645","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       for role in kc.roles.roles_for_user("},{"line_number":56,"context_line":"                           kc.user_id,"},{"line_number":57,"context_line":"                           tenant\u003dkc.tenant_id)]:"},{"line_number":58,"context_line":"        raise keystone_exc.Unauthorized"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def is_valid_mac(address):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_243fd1b6","line":58,"updated":"2015-01-14 10:01:39.000000000","message":"oh btw, we should be raising instance, not a class:\n\n raise keystone_exc.Unauthorized()","commit_id":"9c9b7a53e802d22504ce384d2e25dcc18ecb8c23"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"59052a1b3c6a98c95d65a1df5724424393fcd0e5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       for role in kc.roles.roles_for_user("},{"line_number":56,"context_line":"                           kc.user_id,"},{"line_number":57,"context_line":"                           tenant\u003dkc.tenant_id)]:"},{"line_number":58,"context_line":"        raise keystone_exc.Unauthorized"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def is_valid_mac(address):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_503d6cba","line":58,"in_reply_to":"3a961159_243fd1b6","updated":"2015-01-14 15:24:51.000000000","message":"Whoops. Nice catch.","commit_id":"9c9b7a53e802d22504ce384d2e25dcc18ecb8c23"}]}
