)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c99d4ce767970b7ee324e3939d0c5e6721f7d718","unresolved":false,"context_lines":[{"line_number":13,"context_line":"ssl_key_path and ssl_cert_path configuration options."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I67792722129645e1f452c7d7d04e7c9d26176e0a"},{"line_number":16,"context_line":"Closes-Bug: 1413204"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_22618505","line":16,"updated":"2015-06-01 14:21:30.000000000","message":"nit: # add before bug number","commit_id":"e70de2e971a71f45b3f28fc05a89e19c5683ddd0"}],"ironic_inspector/conf.py":[{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"68120b87ccfb373d8dbbfcfbf22b71dc27bce480","unresolved":false,"context_lines":[{"line_number":169,"context_line":"               help\u003d\u0027Amount of time in seconds, after which repeat clean up \u0027"},{"line_number":170,"context_line":"                    \u0027of timed out nodes and old nodes status information.\u0027,"},{"line_number":171,"context_line":"               deprecated_group\u003d\u0027discoverd\u0027),"},{"line_number":172,"context_line":"    cfg.IntOpt(\u0027ssl\u0027,"},{"line_number":173,"context_line":"               default\u003dFalse,"},{"line_number":174,"context_line":"               help\u003d\u0027SSL Enabled/Disabled\u0027,"},{"line_number":175,"context_line":"               deprecated_group\u003d\u0027discoverd\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_684b0d88","line":172,"updated":"2015-05-29 17:27:12.000000000","message":"cfg.IntOpt -\u003e cfg.BoolOpt","commit_id":"1c452e1e54d51c19cf7e9985a8eff92cd044da9a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"68120b87ccfb373d8dbbfcfbf22b71dc27bce480","unresolved":false,"context_lines":[{"line_number":173,"context_line":"               default\u003dFalse,"},{"line_number":174,"context_line":"               help\u003d\u0027SSL Enabled/Disabled\u0027,"},{"line_number":175,"context_line":"               deprecated_group\u003d\u0027discoverd\u0027),"},{"line_number":176,"context_line":"    # cfg.IntOpt(\u0027ssl_cert_path\u0027,"},{"line_number":177,"context_line":"    #            default\u003d\u0027\u0027,"},{"line_number":178,"context_line":"    #            help\u003d\u0027Path to SSL certificate\u0027,"},{"line_number":179,"context_line":"    #            deprecated_group\u003d\u0027discoverd\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_e85ffd3e","line":176,"updated":"2015-05-29 17:27:12.000000000","message":"cfg.IntOpt -\u003e cfg.StrOpt","commit_id":"1c452e1e54d51c19cf7e9985a8eff92cd044da9a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"68120b87ccfb373d8dbbfcfbf22b71dc27bce480","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    #            default\u003d\u0027\u0027,"},{"line_number":178,"context_line":"    #            help\u003d\u0027Path to SSL certificate\u0027,"},{"line_number":179,"context_line":"    #            deprecated_group\u003d\u0027discoverd\u0027),"},{"line_number":180,"context_line":"    # cfg.IntOpt(\u0027ssl_key_path\u0027,"},{"line_number":181,"context_line":"    #            default\u003d\u0027\u0027,"},{"line_number":182,"context_line":"    #            help\u003d\u0027Path to SSL key\u0027,"},{"line_number":183,"context_line":"    #            deprecated_group\u003d\u0027discoverd\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_a855851e","line":180,"updated":"2015-05-29 17:27:12.000000000","message":"cfg.IntOpt -\u003e cfg.StrOpt","commit_id":"1c452e1e54d51c19cf7e9985a8eff92cd044da9a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"728533ddd1a209f551997e0ff8a3bae85a8dad7d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"               help\u003d\u0027Amount of time in seconds, after which repeat clean up \u0027"},{"line_number":170,"context_line":"                    \u0027of timed out nodes and old nodes status information.\u0027,"},{"line_number":171,"context_line":"               deprecated_group\u003d\u0027discoverd\u0027),"},{"line_number":172,"context_line":"    cfg.BoolOpt(\u0027ssl\u0027,"},{"line_number":173,"context_line":"                default\u003dFalse,"},{"line_number":174,"context_line":"                help\u003d\u0027SSL Enabled/Disabled\u0027,"},{"line_number":175,"context_line":"                deprecated_group\u003d\u0027discoverd\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_40100459","line":172,"updated":"2015-06-01 10:05:24.000000000","message":"I\u0027d prefer s/ssl/use_ssl/","commit_id":"ec7c036531cb89856bd4dfd2a4ac6128cd49bc7d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"28aaa19aa285d4099de5032fa633cfef98f4895c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"               help\u003d\u0027Amount of time in seconds, after which repeat clean up \u0027"},{"line_number":170,"context_line":"                    \u0027of timed out nodes and old nodes status information.\u0027,"},{"line_number":171,"context_line":"               deprecated_group\u003d\u0027discoverd\u0027),"},{"line_number":172,"context_line":"    cfg.BoolOpt(\u0027ssl\u0027,"},{"line_number":173,"context_line":"                default\u003dFalse,"},{"line_number":174,"context_line":"                help\u003d\u0027SSL Enabled/Disabled\u0027,"},{"line_number":175,"context_line":"                deprecated_group\u003d\u0027discoverd\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_360f8f38","line":172,"in_reply_to":"7a016987_40100459","updated":"2015-06-01 13:25:35.000000000","message":"Done","commit_id":"ec7c036531cb89856bd4dfd2a4ac6128cd49bc7d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"728533ddd1a209f551997e0ff8a3bae85a8dad7d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    cfg.StrOpt(\u0027ssl_key_path\u0027,"},{"line_number":181,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":182,"context_line":"               help\u003d\u0027Path to SSL key\u0027,"},{"line_number":183,"context_line":"               deprecated_group\u003d\u0027discoverd\u0027),"},{"line_number":184,"context_line":"]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_2013c866","line":183,"updated":"2015-06-01 10:05:24.000000000","message":"1. there\u0027s no \"deprecated_group\" for these options\n\n2. please rerun tox -egenconfig again once you fix it","commit_id":"ec7c036531cb89856bd4dfd2a4ac6128cd49bc7d"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"1bcd509929e92e9bf4a619aef6480d40155d27aa","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    cfg.StrOpt(\u0027ssl_key_path\u0027,"},{"line_number":181,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":182,"context_line":"               help\u003d\u0027Path to SSL key\u0027,"},{"line_number":183,"context_line":"               deprecated_group\u003d\u0027discoverd\u0027),"},{"line_number":184,"context_line":"]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_0061ec04","line":183,"updated":"2015-06-01 10:04:56.000000000","message":"Could you please regenerate example.conf by executing \"tox -egenconfig\" command? Otherwise, these configs will not be shown in example.conf.","commit_id":"ec7c036531cb89856bd4dfd2a4ac6128cd49bc7d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"28aaa19aa285d4099de5032fa633cfef98f4895c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    cfg.StrOpt(\u0027ssl_key_path\u0027,"},{"line_number":181,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":182,"context_line":"               help\u003d\u0027Path to SSL key\u0027,"},{"line_number":183,"context_line":"               deprecated_group\u003d\u0027discoverd\u0027),"},{"line_number":184,"context_line":"]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_4c103a00","line":183,"in_reply_to":"7a016987_2013c866","updated":"2015-06-01 13:25:35.000000000","message":"Done","commit_id":"ec7c036531cb89856bd4dfd2a4ac6128cd49bc7d"}],"ironic_inspector/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"728533ddd1a209f551997e0ff8a3bae85a8dad7d","unresolved":false,"context_lines":[{"line_number":188,"context_line":"               \u0027port\u0027: CONF.listen_port}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        if CONF.ssl:"},{"line_number":191,"context_line":"            context \u003d ssl.SSLContext(ssl.PROTOCOL_TLSv1_2)"},{"line_number":192,"context_line":"            try:"},{"line_number":193,"context_line":"                context.load_cert_chain(CONF.ssl_cert_path,"},{"line_number":194,"context_line":"                                        CONF.ssl_key_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_000fac37","line":191,"updated":"2015-06-01 10:05:24.000000000","message":"Is there a way to avoid hardcoding protocol? Something like \"use the best\"?\n\nwhy not use create_default_context first and then call load_cert_chain if paths are provided?","commit_id":"ec7c036531cb89856bd4dfd2a4ac6128cd49bc7d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"28aaa19aa285d4099de5032fa633cfef98f4895c","unresolved":false,"context_lines":[{"line_number":188,"context_line":"               \u0027port\u0027: CONF.listen_port}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        if CONF.ssl:"},{"line_number":191,"context_line":"            context \u003d ssl.SSLContext(ssl.PROTOCOL_TLSv1_2)"},{"line_number":192,"context_line":"            try:"},{"line_number":193,"context_line":"                context.load_cert_chain(CONF.ssl_cert_path,"},{"line_number":194,"context_line":"                                        CONF.ssl_key_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_d6283b99","line":191,"in_reply_to":"7a016987_000fac37","updated":"2015-06-01 13:25:35.000000000","message":"Done","commit_id":"ec7c036531cb89856bd4dfd2a4ac6128cd49bc7d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"728533ddd1a209f551997e0ff8a3bae85a8dad7d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                                        CONF.ssl_key_path)"},{"line_number":195,"context_line":"            except IOError:"},{"line_number":196,"context_line":"                context.load_default_certs(ssl.Purpose.CLIENT_AUTH)"},{"line_number":197,"context_line":"            kws[\u0027ssl_context\u0027] \u003d context"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        app.run(**kws)"},{"line_number":200,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_e0093032","line":197,"updated":"2015-06-01 10:05:24.000000000","message":"I think it should be done before init() and outside of try..finally.. block","commit_id":"ec7c036531cb89856bd4dfd2a4ac6128cd49bc7d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"28aaa19aa285d4099de5032fa633cfef98f4895c","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                                        CONF.ssl_key_path)"},{"line_number":195,"context_line":"            except IOError:"},{"line_number":196,"context_line":"                context.load_default_certs(ssl.Purpose.CLIENT_AUTH)"},{"line_number":197,"context_line":"            kws[\u0027ssl_context\u0027] \u003d context"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        app.run(**kws)"},{"line_number":200,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_961d2375","line":197,"in_reply_to":"7a016987_e0093032","updated":"2015-06-01 13:25:35.000000000","message":"Done","commit_id":"ec7c036531cb89856bd4dfd2a4ac6128cd49bc7d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c99d4ce767970b7ee324e3939d0c5e6721f7d718","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            except Exception as exc:"},{"line_number":196,"context_line":"                LOG.warning(_LW(\u0027Failed to load certificate and key from \u0027"},{"line_number":197,"context_line":"                                \u0027defined locations, will continue to run with \u0027"},{"line_number":198,"context_line":"                                \u0027the default settings: %s\u0027) % exc)"},{"line_number":199,"context_line":"        app_kwargs[\u0027ssl_context\u0027] \u003d context"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    init()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_025c4949","line":198,"updated":"2015-06-01 14:21:30.000000000","message":"nit: % -\u003e ,","commit_id":"e70de2e971a71f45b3f28fc05a89e19c5683ddd0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"395eaeba7323d70863c340d627468369e51198a0","unresolved":false,"context_lines":[{"line_number":172,"context_line":"def create_ssl_context():"},{"line_number":173,"context_line":"    if not CONF.use_ssl:"},{"line_number":174,"context_line":"        return"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_87725d7b","line":175,"updated":"2015-06-01 20:26:40.000000000","message":"MIN_VERSION \u003d (2, 7, 9)","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"aa16b819340110b2b6875188931e7b7f9a2d5a9e","unresolved":false,"context_lines":[{"line_number":172,"context_line":"def create_ssl_context():"},{"line_number":173,"context_line":"    if not CONF.use_ssl:"},{"line_number":174,"context_line":"        return"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_2fb929ea","line":175,"in_reply_to":"5afe65bd_87725d7b","updated":"2015-06-02 11:04:33.000000000","message":"Done","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"395eaeba7323d70863c340d627468369e51198a0","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    if not CONF.use_ssl:"},{"line_number":174,"context_line":"        return"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"},{"line_number":179,"context_line":"                        \u0027to enable this feature.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_a7455918","line":176,"updated":"2015-06-01 20:26:40.000000000","message":"Nit:\n\n if sys.version_info \u003c (2, 7, 9):\n\nCan use the whole sys.version_info value.","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"aa16b819340110b2b6875188931e7b7f9a2d5a9e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    if not CONF.use_ssl:"},{"line_number":174,"context_line":"        return"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"},{"line_number":179,"context_line":"                        \u0027to enable this feature.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_4fb465f1","line":176,"in_reply_to":"5afe65bd_a7455918","updated":"2015-06-02 11:04:33.000000000","message":"Done","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"395eaeba7323d70863c340d627468369e51198a0","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        return"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"},{"line_number":179,"context_line":"                        \u0027to enable this feature.\u0027))"},{"line_number":180,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_270049aa","line":177,"updated":"2015-06-01 20:26:40.000000000","message":"Might be nice to print what version they are using.","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"aa16b819340110b2b6875188931e7b7f9a2d5a9e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        return"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"},{"line_number":179,"context_line":"                        \u0027to enable this feature.\u0027))"},{"line_number":180,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_6fbf21d1","line":177,"in_reply_to":"5afe65bd_270049aa","updated":"2015-06-02 11:04:33.000000000","message":"Done","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"395eaeba7323d70863c340d627468369e51198a0","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"},{"line_number":179,"context_line":"                        \u0027to enable this feature.\u0027))"},{"line_number":180,"context_line":"        return"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_c70e15e5","line":178,"updated":"2015-06-01 20:26:40.000000000","message":"\u0027ensure your version of Python is greater than %s \u0027","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"aa16b819340110b2b6875188931e7b7f9a2d5a9e","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"},{"line_number":179,"context_line":"                        \u0027to enable this feature.\u0027))"},{"line_number":180,"context_line":"        return"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_8fba5de0","line":178,"in_reply_to":"5afe65bd_c70e15e5","updated":"2015-06-02 11:04:33.000000000","message":"Done","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"395eaeba7323d70863c340d627468369e51198a0","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"},{"line_number":179,"context_line":"                        \u0027to enable this feature.\u0027))"},{"line_number":180,"context_line":"        return"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    context \u003d ssl.create_default_context(purpose\u003dssl.Purpose.CLIENT_AUTH)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_e70911df","line":179,"updated":"2015-06-01 20:26:40.000000000","message":"% \u0027.\u0027.join(MIN_VERSION)","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"aa16b819340110b2b6875188931e7b7f9a2d5a9e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"},{"line_number":179,"context_line":"                        \u0027to enable this feature.\u0027))"},{"line_number":180,"context_line":"        return"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    context \u003d ssl.create_default_context(purpose\u003dssl.Purpose.CLIENT_AUTH)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_efcb1171","line":179,"in_reply_to":"5afe65bd_5917a5ed","updated":"2015-06-02 11:04:33.000000000","message":"Done","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"3fefa9a7fcd7a4c0028eeb2f3f1e01f03b9f1a7b","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    if sys.version_info[:3] \u003c (2, 7, 9):"},{"line_number":177,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python, please \u0027"},{"line_number":178,"context_line":"                        \u0027ensure your version of Python is greater than 2.7.9 \u0027"},{"line_number":179,"context_line":"                        \u0027to enable this feature.\u0027))"},{"line_number":180,"context_line":"        return"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    context \u003d ssl.create_default_context(purpose\u003dssl.Purpose.CLIENT_AUTH)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_5917a5ed","line":179,"in_reply_to":"5afe65bd_e70911df","updated":"2015-06-01 23:59:19.000000000","message":"Agree with John.","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"395eaeba7323d70863c340d627468369e51198a0","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        try:"},{"line_number":185,"context_line":"            context.load_cert_chain(CONF.ssl_cert_path, CONF.ssl_key_path)"},{"line_number":186,"context_line":"        except Exception as exc:"},{"line_number":187,"context_line":"            LOG.warning(_LW(\u0027Failed to load certificate and key from \u0027"},{"line_number":188,"context_line":"                            \u0027defined locations, will continue to run with \u0027"},{"line_number":189,"context_line":"                            \u0027the default settings: %s\u0027), exc)"},{"line_number":190,"context_line":"    return context"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_c725f55c","line":187,"updated":"2015-06-01 20:26:40.000000000","message":"I think printing the locations would be a good idea.","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"aa16b819340110b2b6875188931e7b7f9a2d5a9e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        try:"},{"line_number":185,"context_line":"            context.load_cert_chain(CONF.ssl_cert_path, CONF.ssl_key_path)"},{"line_number":186,"context_line":"        except Exception as exc:"},{"line_number":187,"context_line":"            LOG.warning(_LW(\u0027Failed to load certificate and key from \u0027"},{"line_number":188,"context_line":"                            \u0027defined locations, will continue to run with \u0027"},{"line_number":189,"context_line":"                            \u0027the default settings: %s\u0027), exc)"},{"line_number":190,"context_line":"    return context"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_cfc85577","line":187,"in_reply_to":"5afe65bd_c725f55c","updated":"2015-06-02 11:04:33.000000000","message":"Done","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"fd5bdda8df5a3f5e3ff7501bff4a617aa29493c1","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    if not CONF.use_ssl:"},{"line_number":174,"context_line":"        return"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    MIN_VERSION \u003d (2, 7, 9)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    if sys.version_info \u003c MIN_VERSION:"},{"line_number":179,"context_line":"        LOG.warning(_LW(\u0027Unable to use SSL in this version of Python: \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_38f851e5","line":176,"updated":"2015-06-02 12:34:39.000000000","message":"Maybe describing MIN_VERSION in README.rst could be better.","commit_id":"8efb8cba04f16ba5b860a26ae36815a9b2a2b4cc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d420b31de0a0aa26955f951e93ddfbff8b87b289","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                        \u0027%{current}, please ensure your version of Python is \u0027"},{"line_number":181,"context_line":"                        \u0027greater than %{min} to enable this feature.\u0027),"},{"line_number":182,"context_line":"                    {\u0027current\u0027: \u0027.\u0027.join(map(str, sys.version_info[:3])),"},{"line_number":183,"context_line":"                     \u0027min\u0027: \u0027.\u0027.join(map(str, MIN_VERSION))})"},{"line_number":184,"context_line":"        return"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    context \u003d ssl.create_default_context(purpose\u003dssl.Purpose.CLIENT_AUTH)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_f2ce5a59","line":183,"updated":"2015-06-02 11:43:49.000000000","message":"nit: you can just embed \"2.7.9\" in the message, it won\u0027t ever change, I guess","commit_id":"8efb8cba04f16ba5b860a26ae36815a9b2a2b4cc"}],"ironic_inspector/test/test_main.py":[{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"3fefa9a7fcd7a4c0028eeb2f3f1e01f03b9f1a7b","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    @mock.patch.object(ssl, \u0027create_default_context\u0027, autospec\u003dTrue)"},{"line_number":317,"context_line":"    def test_load_cert_chain_fails(self, mock_cdc):"},{"line_number":318,"context_line":"        CONF.set_override(\u0027use_ssl\u0027, True)"},{"line_number":319,"context_line":"        mock_context \u003d mock_cdc()"},{"line_number":320,"context_line":"        key_path \u003d \u0027/some/fake/path/key\u0027"},{"line_number":321,"context_line":"        cert_path \u003d \u0027/some/fake/path/cert\u0027"},{"line_number":322,"context_line":"        CONF.set_override(\u0027use_ssl\u0027, True)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_39d06953","line":319,"updated":"2015-06-01 23:59:19.000000000","message":"This line is unnecessary because this is called in L325 again.","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"aa16b819340110b2b6875188931e7b7f9a2d5a9e","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    @mock.patch.object(ssl, \u0027create_default_context\u0027, autospec\u003dTrue)"},{"line_number":317,"context_line":"    def test_load_cert_chain_fails(self, mock_cdc):"},{"line_number":318,"context_line":"        CONF.set_override(\u0027use_ssl\u0027, True)"},{"line_number":319,"context_line":"        mock_context \u003d mock_cdc()"},{"line_number":320,"context_line":"        key_path \u003d \u0027/some/fake/path/key\u0027"},{"line_number":321,"context_line":"        cert_path \u003d \u0027/some/fake/path/cert\u0027"},{"line_number":322,"context_line":"        CONF.set_override(\u0027use_ssl\u0027, True)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_0f40ada4","line":319,"in_reply_to":"5afe65bd_39d06953","updated":"2015-06-02 11:04:33.000000000","message":"Done","commit_id":"27252676cd48c908ac6e7473ae830ab224347e08"}]}