)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"5a23a24a78bbb8ae6e456ea725891dff093a89bf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Recommend using ENROLL for setting IPMI credentials"},{"line_number":10,"context_line":"* Deprecate using maintenance mode, will be dropped once we stop"},{"line_number":11,"context_line":"  supporing Ironic Kilo"},{"line_number":12,"context_line":"* Drop bits related to Ironic Juno, we no longer support it"},{"line_number":13,"context_line":"* Clarify error message about wrong provision state, stop mentioning"},{"line_number":14,"context_line":"  maintenance mode there"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_0273cbb5","line":11,"updated":"2015-09-01 15:55:14.000000000","message":"s/supporing/supporting/","commit_id":"6c710d30d638d9372b22c1f63b18aeffe3b2029c"}],"README.rst":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e5488b3ce85e1c40ca3655b885abef431b106c94","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    ironic node-set-provision-state \u003cUUID\u003e manage"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"* After successful introspection and before deploying nodes should be made"},{"line_number":271,"context_line":"  available to Nova, either by moving them to ``AVAILABLE`` state::"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    ironic node-set-provision-state \u003cUUID\u003e provide"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_3c195d7a","line":271,"updated":"2015-09-01 14:21:57.000000000","message":"s/either by moving them to/by moving them to/","commit_id":"6c710d30d638d9372b22c1f63b18aeffe3b2029c"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"40cb630825026c8e9d98932f04cdc1b4522a77bf","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"  .. note::"},{"line_number":276,"context_line":"    Due to how Nova interacts with Ironic driver, you should wait 1 minute"},{"line_number":277,"context_line":"    before Nova becomes aware of available nodes after issuing this command."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"Setting IPMI Credentials"},{"line_number":280,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_b8cb3ea3","line":277,"updated":"2015-09-01 12:56:56.000000000","message":"maybe we could add a note about checking nova status with `nova hypervisor-stats` to confirm the nodes are known to Nova.","commit_id":"6c710d30d638d9372b22c1f63b18aeffe3b2029c"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"40cb630825026c8e9d98932f04cdc1b4522a77bf","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"  Providing ``ipmi_address`` allows **ironic-inspector** to distinguish nodes."},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"* With Ironic Kilo or older, set maintenance mode on nodes."},{"line_number":301,"context_line":"  That\u0027s an important step, otherwise Ironic might interfere with introspection"},{"line_number":302,"context_line":"  process. This is replaced by ``enroll`` state in Ironic Liberty."},{"line_number":303,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_78c84655","line":300,"updated":"2015-09-01 12:56:56.000000000","message":"I am not sure how we could make this stand out more, but it seems like we should since we do not check in the code anymore.","commit_id":"6c710d30d638d9372b22c1f63b18aeffe3b2029c"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"40cb630825026c8e9d98932f04cdc1b4522a77bf","unresolved":false,"context_lines":[{"line_number":310,"context_line":"* Manually power on the nodes and wait."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"* After introspection is finished (watch nodes power state or use"},{"line_number":313,"context_line":"  **ironic-inspector** status API) you can move node to ``manageable`` and"},{"line_number":314,"context_line":"  then ``available`` states - see `Node States`_."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"Note that due to various limitations on password value in different BMC,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_98dbda4e","line":313,"updated":"2015-09-01 12:56:56.000000000","message":"a bit silly, but we never say to take nodes out of maintenance for Kilo.","commit_id":"6c710d30d638d9372b22c1f63b18aeffe3b2029c"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"2d0b1cf48a5e665a8335546f1650004d3ee6f054","unresolved":false,"context_lines":[{"line_number":290,"context_line":"  configuration file, restart **ironic-inspector**."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"* Enroll nodes in Ironic with setting their ``ipmi_address`` only (or"},{"line_number":293,"context_line":"  equivalent driver-specific property)."},{"line_number":294,"context_line":"  With Ironic Liberty use ironic API version ``1.11``, so that new node gets"},{"line_number":295,"context_line":"  into ``enroll`` provision state::"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_683794b0","line":293,"updated":"2015-09-03 17:10:45.000000000","message":"We can refer to ipmi_address_fields, it will be more kind for users, I think. WDYT?","commit_id":"bc0c7ce20cfcc86e139d195f23740d8f64cac263"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17a6c11914c772b7c4e5dd2efd4343ad98105c34","unresolved":false,"context_lines":[{"line_number":290,"context_line":"  configuration file, restart **ironic-inspector**."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"* Enroll nodes in Ironic with setting their ``ipmi_address`` only (or"},{"line_number":293,"context_line":"  equivalent driver-specific property)."},{"line_number":294,"context_line":"  With Ironic Liberty use ironic API version ``1.11``, so that new node gets"},{"line_number":295,"context_line":"  into ``enroll`` provision state::"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_dbf07aff","line":293,"in_reply_to":"da20952f_683794b0","updated":"2015-09-07 17:12:00.000000000","message":"Done","commit_id":"bc0c7ce20cfcc86e139d195f23740d8f64cac263"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"299071dad97bd7db17cc9b88968ad10cd86e3c30","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    ironic --ironic-api-version 1.11 node-create -d \u003cDRIVER\u003e -i ipmi_address\u003d\u003cADDRESS\u003e"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"  Providing ``ipmi_address`` allows **ironic-inspector** to distinguish nodes."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"* With Ironic Kilo or older, set maintenance mode on nodes."},{"line_number":304,"context_line":"  That\u0027s an important step, otherwise Ironic might interfere with introspection"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_67bc1007","line":301,"updated":"2015-09-08 14:54:15.000000000","message":"If you happen to update this patch, it might worth expanding what do you mean by distinguishing nodes.","commit_id":"676a5814117e346afc52ce9df1a329920074543a"}],"ironic_inspector/utils.py":[{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"40cb630825026c8e9d98932f04cdc1b4522a77bf","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        raise Error(msg % {\u0027node\u0027: node.uuid, \u0027state\u0027: state,"},{"line_number":182,"context_line":"                           \u0027valid\u0027: list(SET_CREDENTIALS_VALID_STATES)})"},{"line_number":183,"context_line":"    elif not with_credentials and state not in VALID_STATES:"},{"line_number":184,"context_line":"        msg \u003d _(\u0027Invalid provision state \"%(state)s\" for node %(node)s, \u0027"},{"line_number":185,"context_line":"                \u0027valid states are \"%(valid)s\"\u0027)"},{"line_number":186,"context_line":"        raise Error(msg % {\u0027node\u0027: node.uuid, \u0027state\u0027: state,"},{"line_number":187,"context_line":"                           \u0027valid\u0027: list(VALID_STATES)})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_b86edefd","line":184,"updated":"2015-09-01 12:56:56.000000000","message":"should we match this msg to the new message?\ni.e. \u0027Invalid provision state \"%(state)s\" for inspecting node %(node)s, \u0027...\nor \u0027Invalid provision state \"%(state)s\" for introspection of node %(node)s, \u0027","commit_id":"6c710d30d638d9372b22c1f63b18aeffe3b2029c"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"2d0b1cf48a5e665a8335546f1650004d3ee6f054","unresolved":false,"context_lines":[{"line_number":171,"context_line":"def check_provision_state(node, with_credentials\u003dFalse):"},{"line_number":172,"context_line":"    if node.maintenance:"},{"line_number":173,"context_line":"        LOG.warn(_LW(\u0027Introspecting nodes in maintenance mode is deprecated, \u0027"},{"line_number":174,"context_line":"                     \u0027use MANAGEABLE, INSPECTING or ENROLL states.\u0027))"},{"line_number":175,"context_line":"        return"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    state \u003d node.provision_state.lower()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_88e0e8cd","line":174,"updated":"2015-09-03 17:10:45.000000000","message":"Is there any better way not writing fixed value?","commit_id":"bc0c7ce20cfcc86e139d195f23740d8f64cac263"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17a6c11914c772b7c4e5dd2efd4343ad98105c34","unresolved":false,"context_lines":[{"line_number":171,"context_line":"def check_provision_state(node, with_credentials\u003dFalse):"},{"line_number":172,"context_line":"    if node.maintenance:"},{"line_number":173,"context_line":"        LOG.warn(_LW(\u0027Introspecting nodes in maintenance mode is deprecated, \u0027"},{"line_number":174,"context_line":"                     \u0027use MANAGEABLE, INSPECTING or ENROLL states.\u0027))"},{"line_number":175,"context_line":"        return"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    state \u003d node.provision_state.lower()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_5be54a35","line":174,"in_reply_to":"da20952f_88e0e8cd","updated":"2015-09-07 17:12:00.000000000","message":"Done","commit_id":"bc0c7ce20cfcc86e139d195f23740d8f64cac263"}]}