)]}'
{"ironic_inspector/node_cache.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"d4a3140b737f675446bed7710a92cd961622f0f8","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    \"\"\"Get node from cache by it\u0027s UUID."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    :param uuid: node UUID."},{"line_number":325,"context_line":"    :param ironic: optional ironic client instance"},{"line_number":326,"context_line":"    :returns: structure NodeInfo."},{"line_number":327,"context_line":"    \"\"\""},{"line_number":328,"context_line":"    row \u003d db.model_query(db.Node).filter_by(uuid\u003duuid).first()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_9bf62b5c","line":325,"updated":"2015-09-10 09:58:55.000000000","message":"This parameter isn\u0027t used anywhere in this function is it required?","commit_id":"56baab266368cb742bb8deb813348b8637c192d9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a9fa199a97b47288b7377fd57b2a25d49958602","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    \"\"\"Get node from cache by it\u0027s UUID."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    :param uuid: node UUID."},{"line_number":325,"context_line":"    :param ironic: optional ironic client instance"},{"line_number":326,"context_line":"    :returns: structure NodeInfo."},{"line_number":327,"context_line":"    \"\"\""},{"line_number":328,"context_line":"    row \u003d db.model_query(db.Node).filter_by(uuid\u003duuid).first()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_f265ea1c","line":325,"in_reply_to":"da20952f_9bf62b5c","updated":"2015-09-10 10:57:28.000000000","message":"Should be, but I forgot about it","commit_id":"56baab266368cb742bb8deb813348b8637c192d9"}],"ironic_inspector/plugins/standard.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"d4a3140b737f675446bed7710a92cd961622f0f8","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            return"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        ports \u003d list(node_info.ports().values())"},{"line_number":146,"context_line":"        for port in ports:"},{"line_number":147,"context_line":"            if port.address not in expected_macs:"},{"line_number":148,"context_line":"                LOG.info(_LI(\"Deleting port %(port)s as its MAC %(mac)s is \""},{"line_number":149,"context_line":"                             \"not in expected MAC list %(expected)s for node \""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_5684ea5b","line":146,"updated":"2015-09-10 09:58:55.000000000","message":"Couldn\u0027t this simply be:\n\n    for port in node_info.ports():\n        ...\n\nor if you need to ensure its a new list:\n\n    for port in list(node_info.ports()):\n        ...","commit_id":"56baab266368cb742bb8deb813348b8637c192d9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a9fa199a97b47288b7377fd57b2a25d49958602","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            return"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        ports \u003d list(node_info.ports().values())"},{"line_number":146,"context_line":"        for port in ports:"},{"line_number":147,"context_line":"            if port.address not in expected_macs:"},{"line_number":148,"context_line":"                LOG.info(_LI(\"Deleting port %(port)s as its MAC %(mac)s is \""},{"line_number":149,"context_line":"                             \"not in expected MAC list %(expected)s for node \""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_d249c68f","line":146,"in_reply_to":"da20952f_5684ea5b","updated":"2015-09-10 10:57:28.000000000","message":"list of dict iterates over keys, not over values. And I need it to be a list, as I\u0027ll modify the underlying dict.","commit_id":"56baab266368cb742bb8deb813348b8637c192d9"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"73d16da8a2606ccd69f8e8d3c7a1c2b7736320e0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            return"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        ports \u003d list(node_info.ports().values())"},{"line_number":146,"context_line":"        for port in ports:"},{"line_number":147,"context_line":"            if port.address not in expected_macs:"},{"line_number":148,"context_line":"                LOG.info(_LI(\"Deleting port %(port)s as its MAC %(mac)s is \""},{"line_number":149,"context_line":"                             \"not in expected MAC list %(expected)s for node \""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_6657dbca","line":146,"in_reply_to":"da20952f_d249c68f","updated":"2015-09-10 11:10:20.000000000","message":"Ah I mis-read the node_info.ports() function I thought it returned a set not a dict, {} being used for both is :(, you could still compress this to one line though.","commit_id":"56baab266368cb742bb8deb813348b8637c192d9"}]}
