)]}'
{"ironic_inspector/plugins/raid_device.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b52f7be326e24a6e85b7a5643f4766c5f9596616","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def _get_serials(self, data):"},{"line_number":48,"context_line":"        if \u0027inventory\u0027 in data:"},{"line_number":49,"context_line":"            return [x[\u0027serial\u0027] for x in data[\u0027inventory\u0027].get(\u0027disks\u0027, ())"},{"line_number":50,"context_line":"                    if x[\u0027serial\u0027]]"},{"line_number":51,"context_line":"        elif \u0027block_devices\u0027 in data:"},{"line_number":52,"context_line":"            return data[\u0027block_devices\u0027][\u0027serials\u0027]"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_3147de4c","line":50,"updated":"2015-09-22 15:02:26.000000000","message":"\"if x[\u0027serial\u0027]\" will raise a key exception if \u0027serial\u0027 isn\u0027t in x, I suggest making this if x.get(\u0027serial\u0027).","commit_id":"fd05a48daaeccf6d2a5a27df7d0f74bb78fcd151"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b52f7be326e24a6e85b7a5643f4766c5f9596616","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            return [x[\u0027serial\u0027] for x in data[\u0027inventory\u0027].get(\u0027disks\u0027, ())"},{"line_number":50,"context_line":"                    if x[\u0027serial\u0027]]"},{"line_number":51,"context_line":"        elif \u0027block_devices\u0027 in data:"},{"line_number":52,"context_line":"            return data[\u0027block_devices\u0027][\u0027serials\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def before_processing(self, introspection_data, **kwargs):"},{"line_number":55,"context_line":"        \"\"\"Adds fake local_gb value if it\u0027s missing from introspection_data.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_917caa73","line":52,"updated":"2015-09-22 15:02:26.000000000","message":"same here, I would make this a .get(\u0027serials\u0027)","commit_id":"fd05a48daaeccf6d2a5a27df7d0f74bb78fcd151"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"ae34f28b1ab89c4473e996cefbfe33d6d3216d27","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            return [x[\u0027serial\u0027] for x in data[\u0027inventory\u0027].get(\u0027disks\u0027, ())"},{"line_number":50,"context_line":"                    if x.get(\u0027serial\u0027)]"},{"line_number":51,"context_line":"        elif \u0027block_devices\u0027 in data:"},{"line_number":52,"context_line":"            return data[\u0027block_devices\u0027].get(\u0027serials\u0027, ())"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def before_processing(self, introspection_data, **kwargs):"},{"line_number":55,"context_line":"        \"\"\"Adds fake local_gb value if it\u0027s missing from introspection_data.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_a0b10991","line":52,"updated":"2015-09-24 05:44:05.000000000","message":"Is there \u0027serials\u0027 in data[\u0027block_devices\u0027] really? Could you please show me codes? It exists https://review.openstack.org/#/c/205587/3/ironic_python_agent/inspector/standard.py but, ironic_python_agent/inspector/standard.py seems having disappeared in the latest patch set.","commit_id":"dc8d2fa326a540f2bac327e126ba387b3bfdda2e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2906c8a11d7aab4b1f65ad88ba21a9fd2280a31e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            return [x[\u0027serial\u0027] for x in data[\u0027inventory\u0027].get(\u0027disks\u0027, ())"},{"line_number":50,"context_line":"                    if x.get(\u0027serial\u0027)]"},{"line_number":51,"context_line":"        elif \u0027block_devices\u0027 in data:"},{"line_number":52,"context_line":"            return data[\u0027block_devices\u0027].get(\u0027serials\u0027, ())"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def before_processing(self, introspection_data, **kwargs):"},{"line_number":55,"context_line":"        \"\"\"Adds fake local_gb value if it\u0027s missing from introspection_data.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_27cd0b31","line":52,"in_reply_to":"ba15a1d1_a0b10991","updated":"2015-09-24 08:38:14.000000000","message":"It existed for some time during 2.0.0 cycle, when we had ramdisk code in-tree: https://github.com/openstack/ironic-inspector/blob/9654a066def93014775b3dc2d74470b03842dc6e/ironic_inspector_ramdisk/discover.py#L192-L200\n\nit was never released, but we actually rely on it downstream :(","commit_id":"dc8d2fa326a540f2bac327e126ba387b3bfdda2e"}]}