)]}'
{"ironic_inspector/introspect.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dea4ac61df5fc84800096bb2a0358e2dd72c1350","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    return new_username, new_password"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def introspect(uuid, use_virtual_media\u003dFalse, new_ipmi_credentials\u003dNone,"},{"line_number":69,"context_line":"               token\u003dNone):"},{"line_number":70,"context_line":"    \"\"\"Initiate hardware properties introspection for a given node."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_8c35ad47","line":68,"updated":"2015-10-28 15:15:27.000000000","message":"please add the new argument as a last argument","commit_id":"87c5635e1945b2e9cd70a65ee263e7277d1d7187"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4aba9df46179c3fc94a74406abe9f223348a08c5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    return new_username, new_password"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def introspect(uuid, use_virtual_media\u003dFalse, new_ipmi_credentials\u003dNone,"},{"line_number":69,"context_line":"               token\u003dNone):"},{"line_number":70,"context_line":"    \"\"\"Initiate hardware properties introspection for a given node."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_d8527b13","line":68,"in_reply_to":"1a26ad4f_8c35ad47","updated":"2015-10-29 03:54:37.000000000","message":"I added this in middle because of the other variables having default value as None. I would retry the inspection with ur suggestion, but i think it failed when i had done earlier. I would retest it with teh suggestion and if it works will address it.","commit_id":"87c5635e1945b2e9cd70a65ee263e7277d1d7187"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dea4ac61df5fc84800096bb2a0358e2dd72c1350","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    node_info \u003d node_cache.add_node(node.uuid,"},{"line_number":101,"context_line":"                                    bmc_address\u003dutils.get_ipmi_address(node),"},{"line_number":102,"context_line":"                                    ironic\u003dironic)"},{"line_number":103,"context_line":"    node_info.set_option(\u0027new_ipmi_credentials\u0027, new_ipmi_credentials)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _handle_exceptions():"},{"line_number":106,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_ac3ae934","line":103,"updated":"2015-10-28 15:15:27.000000000","message":"use set_option like here, so that it\u0027s saved in database","commit_id":"87c5635e1945b2e9cd70a65ee263e7277d1d7187"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4aba9df46179c3fc94a74406abe9f223348a08c5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    node_info \u003d node_cache.add_node(node.uuid,"},{"line_number":101,"context_line":"                                    bmc_address\u003dutils.get_ipmi_address(node),"},{"line_number":102,"context_line":"                                    ironic\u003dironic)"},{"line_number":103,"context_line":"    node_info.set_option(\u0027new_ipmi_credentials\u0027, new_ipmi_credentials)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _handle_exceptions():"},{"line_number":106,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_78a56702","line":103,"in_reply_to":"1a26ad4f_ac3ae934","updated":"2015-10-29 03:54:37.000000000","message":"I can do this, but do we want to save it to database?","commit_id":"87c5635e1945b2e9cd70a65ee263e7277d1d7187"}],"ironic_inspector/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dea4ac61df5fc84800096bb2a0358e2dd72c1350","unresolved":false,"context_lines":[{"line_number":45,"context_line":"LOG \u003d log.getLogger(\u0027ironic_inspector.main\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"MINIMUM_API_VERSION \u003d (1, 0)"},{"line_number":48,"context_line":"CURRENT_API_VERSION \u003d (1, 2)"},{"line_number":49,"context_line":"_MIN_VERSION_HEADER \u003d \u0027X-OpenStack-Ironic-Inspector-API-Minimum-Version\u0027"},{"line_number":50,"context_line":"_MAX_VERSION_HEADER \u003d \u0027X-OpenStack-Ironic-Inspector-API-Maximum-Version\u0027"},{"line_number":51,"context_line":"_VERSION_HEADER \u003d \u0027X-OpenStack-Ironic-Inspector-API-Version\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_4c40f5a5","line":48,"updated":"2015-10-28 15:15:27.000000000","message":"please bump this and update HTTP-API.rst","commit_id":"87c5635e1945b2e9cd70a65ee263e7277d1d7187"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4aba9df46179c3fc94a74406abe9f223348a08c5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"LOG \u003d log.getLogger(\u0027ironic_inspector.main\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"MINIMUM_API_VERSION \u003d (1, 0)"},{"line_number":48,"context_line":"CURRENT_API_VERSION \u003d (1, 2)"},{"line_number":49,"context_line":"_MIN_VERSION_HEADER \u003d \u0027X-OpenStack-Ironic-Inspector-API-Minimum-Version\u0027"},{"line_number":50,"context_line":"_MAX_VERSION_HEADER \u003d \u0027X-OpenStack-Ironic-Inspector-API-Maximum-Version\u0027"},{"line_number":51,"context_line":"_VERSION_HEADER \u003d \u0027X-OpenStack-Ironic-Inspector-API-Version\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_8119e67b","line":48,"in_reply_to":"1a26ad4f_4c40f5a5","updated":"2015-10-29 03:54:37.000000000","message":"ohk. Will do","commit_id":"87c5635e1945b2e9cd70a65ee263e7277d1d7187"}]}