)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e6c415b8d6cf91e5cd87c2b8ee2eba8a43932be1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        else"},{"line_number":117,"context_line":"            # download the agent image tarball"},{"line_number":118,"context_line":"            IRONIC_INSPECTOR_KERNEL_PATH\u003d\"$IRONIC_INSPECTOR_IMAGE_PATH.kernel\""},{"line_number":119,"context_line":"            if [ ! -e \"$IRONIC_INSPECTOR_KERNEL_PATH\" -o ! -e \"$IRONIC_INSPECTOR_INITRAMFS_PATH\" ]; then"},{"line_number":120,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_INSPECTOR_KERNEL_PATH"},{"line_number":121,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_INSPECTOR_INITRAMFS_PATH"},{"line_number":122,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6ed579_12590e8e","line":119,"updated":"2016-01-15 12:32:46.000000000","message":"+1 to Sam\u0027s idea, would be great for the gate performance","commit_id":"ab7a36bf3190966493708605bcf751d200f4107e"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"6ec6de57f2793732dbda1d269297248ddcd17c12","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        else"},{"line_number":117,"context_line":"            # download the agent image tarball"},{"line_number":118,"context_line":"            IRONIC_INSPECTOR_KERNEL_PATH\u003d\"$IRONIC_INSPECTOR_IMAGE_PATH.kernel\""},{"line_number":119,"context_line":"            if [ ! -e \"$IRONIC_INSPECTOR_KERNEL_PATH\" -o ! -e \"$IRONIC_INSPECTOR_INITRAMFS_PATH\" ]; then"},{"line_number":120,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_INSPECTOR_KERNEL_PATH"},{"line_number":121,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_INSPECTOR_INITRAMFS_PATH"},{"line_number":122,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6ed579_a29f2602","line":119,"range":{"start_line":119,"start_character":24,"end_line":119,"end_character":52},"updated":"2016-01-13 07:16:11.000000000","message":"looks like this condition is presented in all \u0027if\u0027 paths, I guess it could be moved up, before first \u0027if\u0027 to avoid code duplication.","commit_id":"ab7a36bf3190966493708605bcf751d200f4107e"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"73dabec4965e0abba409945fd2ab35ba458615a9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        else"},{"line_number":117,"context_line":"            # download the agent image tarball"},{"line_number":118,"context_line":"            IRONIC_INSPECTOR_KERNEL_PATH\u003d\"$IRONIC_INSPECTOR_IMAGE_PATH.kernel\""},{"line_number":119,"context_line":"            if [ ! -e \"$IRONIC_INSPECTOR_KERNEL_PATH\" -o ! -e \"$IRONIC_INSPECTOR_INITRAMFS_PATH\" ]; then"},{"line_number":120,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_INSPECTOR_KERNEL_PATH"},{"line_number":121,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_INSPECTOR_INITRAMFS_PATH"},{"line_number":122,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6ed579_1b8058f4","line":119,"range":{"start_line":119,"start_character":24,"end_line":119,"end_character":52},"in_reply_to":"da6ed579_28497a60","updated":"2016-01-18 05:19:05.000000000","message":"Are you a genius? I think we can do the same thing in Ironic also, WDYT?","commit_id":"ab7a36bf3190966493708605bcf751d200f4107e"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"caddaaeec90b88687f202256b86bb558011a3fcc","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        else"},{"line_number":117,"context_line":"            # download the agent image tarball"},{"line_number":118,"context_line":"            IRONIC_INSPECTOR_KERNEL_PATH\u003d\"$IRONIC_INSPECTOR_IMAGE_PATH.kernel\""},{"line_number":119,"context_line":"            if [ ! -e \"$IRONIC_INSPECTOR_KERNEL_PATH\" -o ! -e \"$IRONIC_INSPECTOR_INITRAMFS_PATH\" ]; then"},{"line_number":120,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_INSPECTOR_KERNEL_PATH"},{"line_number":121,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_INSPECTOR_INITRAMFS_PATH"},{"line_number":122,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6ed579_28497a60","line":119,"range":{"start_line":119,"start_character":24,"end_line":119,"end_character":52},"in_reply_to":"da6ed579_6613395c","updated":"2016-01-14 14:46:20.000000000","message":"Is is worth checking if Ironic has already downloaded the agent too? e.g. check $IRONIC_DEPLOY_KERNEL_PATH and $IRONIC_DEPLOY_RAMDISK_PATH, and if they exist cp the files from there instead of wget ing them again.","commit_id":"ab7a36bf3190966493708605bcf751d200f4107e"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"efa44fe60993a5bae92f584ac849ecb4613ad69f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        else"},{"line_number":117,"context_line":"            # download the agent image tarball"},{"line_number":118,"context_line":"            IRONIC_INSPECTOR_KERNEL_PATH\u003d\"$IRONIC_INSPECTOR_IMAGE_PATH.kernel\""},{"line_number":119,"context_line":"            if [ ! -e \"$IRONIC_INSPECTOR_KERNEL_PATH\" -o ! -e \"$IRONIC_INSPECTOR_INITRAMFS_PATH\" ]; then"},{"line_number":120,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_INSPECTOR_KERNEL_PATH"},{"line_number":121,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_INSPECTOR_INITRAMFS_PATH"},{"line_number":122,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6ed579_c189b476","line":119,"range":{"start_line":119,"start_character":24,"end_line":119,"end_character":52},"in_reply_to":"da6ed579_a29f2602","updated":"2016-01-14 07:58:11.000000000","message":"IRONIC_INSPECTOR_KERNEL_PATH is different for each ramdisk type. In case of IPA, .vmlinuz will be generated, but in case of simple ramdisk, .kernel will be generated. so that we have to check the existence of image file for each.","commit_id":"ab7a36bf3190966493708605bcf751d200f4107e"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"19ff3fad84083de93cc2b6f218093c0b154d00f1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        else"},{"line_number":117,"context_line":"            # download the agent image tarball"},{"line_number":118,"context_line":"            IRONIC_INSPECTOR_KERNEL_PATH\u003d\"$IRONIC_INSPECTOR_IMAGE_PATH.kernel\""},{"line_number":119,"context_line":"            if [ ! -e \"$IRONIC_INSPECTOR_KERNEL_PATH\" -o ! -e \"$IRONIC_INSPECTOR_INITRAMFS_PATH\" ]; then"},{"line_number":120,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_INSPECTOR_KERNEL_PATH"},{"line_number":121,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_INSPECTOR_INITRAMFS_PATH"},{"line_number":122,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6ed579_6613395c","line":119,"range":{"start_line":119,"start_character":24,"end_line":119,"end_character":52},"in_reply_to":"da6ed579_c189b476","updated":"2016-01-14 09:17:11.000000000","message":"yep, it would be more difficult so, my bad","commit_id":"ab7a36bf3190966493708605bcf751d200f4107e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8c2a15cc1728cc9c9095f70d47e7f728ef784d98","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            if [ ! -e \"$IRONIC_INSPECTOR_KERNEL_PATH\" -o ! -e \"$IRONIC_INSPECTOR_INITRAMFS_PATH\" ]; then"},{"line_number":120,"context_line":"                if [ -e \"$IRONIC_DEPLOY_KERNEL_PATH\" -a -e \"$IRONIC_DEPLOY_RAMDISK_PATH\" ]; then"},{"line_number":121,"context_line":"                    sudo cp $IRONIC_DEPLOY_KERNEL_PATH $IRONIC_INSPECTOR_KERNEL_PATH"},{"line_number":122,"context_line":"                    sudo cp $IRONIC_DEPLOY_RAMDISK_PATH $IRONIC_INSPECTOR_INITRAMFS_PATH"},{"line_number":123,"context_line":"                else"},{"line_number":124,"context_line":"                    wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_INSPECTOR_KERNEL_PATH"},{"line_number":125,"context_line":"                    wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_INSPECTOR_INITRAMFS_PATH"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba63e191_7c9fb303","line":122,"range":{"start_line":122,"start_character":20,"end_line":122,"end_character":24},"updated":"2016-01-19 13:00:41.000000000","message":"sudo will make these files owned by root, we need to chown it to the current user","commit_id":"08f164a6a6faaf0895e5d80099528bf771f5cf6e"}]}