)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f0447d0d6fe3ddf0dc4589ad12c7ef3d8d7268af","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"function start_inspector {"},{"line_number":75,"context_line":"    run_process ironic-inspector \\"},{"line_number":76,"context_line":"        \"cd $IRONIC_INSPECTOR_DIR \u0026\u0026 $IRONIC_INSPECTOR_CMD\""},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"function start_inspector_dhcp {"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3aaa91ec_d60bea22","line":76,"range":{"start_line":76,"start_character":9,"end_line":76,"end_character":37},"updated":"2016-06-28 15:36:23.000000000","message":"we should probably drop the \"cd\" bit","commit_id":"f44446aeef6ec53be27f05a444d7df4fc48ced89"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"aa34eb6bf5e6d2201d34a3ed05936dc034c2a28b","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"function start_inspector {"},{"line_number":75,"context_line":"    run_process ironic-inspector \\"},{"line_number":76,"context_line":"        \"cd $IRONIC_INSPECTOR_DIR \u0026\u0026 $IRONIC_INSPECTOR_CMD\""},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"function start_inspector_dhcp {"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3aaa91ec_0a07051e","line":76,"range":{"start_line":76,"start_character":9,"end_line":76,"end_character":37},"in_reply_to":"3aaa91ec_d60bea22","updated":"2016-06-28 16:53:08.000000000","message":"yeah I thought it might be an issue; well, if the process doesn\u0027t need cd, we can remove it (screen_it didn\u0027t mind)\n/me hacks, stay tuned","commit_id":"f44446aeef6ec53be27f05a444d7df4fc48ced89"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cb1225bdc663533f0a52f732c56abb36b15cb0fb","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"function start_inspector {"},{"line_number":75,"context_line":"    run_process ironic-inspector \\"},{"line_number":76,"context_line":"        \"$IRONIC_INSPECTOR_DIR/$IRONIC_INSPECTOR_CMD\""},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"function start_inspector_dhcp {"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3aaa91ec_3d91669b","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":31},"updated":"2016-06-28 17:51:04.000000000","message":"IRONIC_INSPECTOR_CMD already includes directory","commit_id":"7d6f444e37bd4b621f5947d06145184761ed5625"}],"devstack/upgrade/resources.sh":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"3591d18639ee405d2793d4bcf20fea3f1f3aab35","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"source $TOP_DIR/openrc admin admin"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Inspector relies on couple of Ironic variables"},{"line_number":28,"context_line":"source $TARGET_RELEASE_DIR/ironic/devstack/lib/ironic"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"INSPECTOR_DEVSTACK_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3aaa91ec_efe65de7","line":27,"updated":"2016-06-21 16:31:13.000000000","message":"Nit: \"a couple\"","commit_id":"358371e624a4ca0f144ec4a4f8d15bf366ac3d53"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"3591d18639ee405d2793d4bcf20fea3f1f3aab35","unresolved":false,"context_lines":[{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"function create {"},{"line_number":92,"context_line":"    :"},{"line_number":93,"context_line":"}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"function verify {"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3aaa91ec_2f54e552","line":92,"updated":"2016-06-21 16:31:13.000000000","message":"Are these going to be written, or are they meant to be empty?","commit_id":"358371e624a4ca0f144ec4a4f8d15bf366ac3d53"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"9d5b0e0455c88590f40c9465b6b6e0adbf15454a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"function create {"},{"line_number":92,"context_line":"    :"},{"line_number":93,"context_line":"}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"function verify {"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3aaa91ec_bb73f3b3","line":92,"in_reply_to":"3aaa91ec_2f54e552","updated":"2016-06-21 18:02:38.000000000","message":"TL;DR empty for starters\n\nThis is where e.g. Nova creates an instance (here, it\u0027s operated through Ironic so it\u0027s a VM--BM) that should survive the upgrade procedure.\nI can imagine we move an instance into manageable state and start introspection on it, then upgrade inspector, then make sure we can continue the introspection from there.\nBut that would be complicated to implement as a testcase, for instance IPA would have to keep \"continuing\" until Inspector boots up-to-date version.\nAFAIK this isn\u0027t supported in Inspector.\nPlease note also Ironic doesn\u0027t (yet) test an upgrade while cleaning a node either.","commit_id":"358371e624a4ca0f144ec4a4f8d15bf366ac3d53"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"7a25f718a7bae0f20dd4efbd6e00369175573b6d","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"source $TOP_DIR/openrc admin admin"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Inspector relies on couple of Ironic variables"},{"line_number":28,"context_line":"source $TARGET_RELEASE_DIR/ironic/devstack/lib/ironic"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"INSPECTOR_DEVSTACK_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3aaa91ec_a2469878","line":27,"updated":"2016-06-29 17:40:42.000000000","message":"Nit: \"a couple\"","commit_id":"befffe94de89cefaeb53d04b9934d680d5a519d3"}],"devstack/upgrade/shutdown.sh":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4bb0a35b39000090823c0e0f28648651b64cf763","unresolved":false,"context_lines":[{"line_number":17,"context_line":"source $TARGET_RELEASE_DIR/ironic/devstack/lib/ironic"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Keep track of the DevStack directory"},{"line_number":20,"context_line":"INSPECTOR_DEVSTACK_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":21,"context_line":"source $INSPECTOR_DEVSTACK_DIR/plugin.sh"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_9b4d579c","line":20,"updated":"2016-06-27 13:44:55.000000000","message":"Possible alternative: $(realpath $(dirname \"$0\")/..)","commit_id":"baca9c208f56a9043e7d870fe77c34fdd420ed13"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"7a25f718a7bae0f20dd4efbd6e00369175573b6d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"source $BASE_DEVSTACK_DIR/lib/tls"},{"line_number":14,"context_line":"source $BASE_DEVSTACK_DIR/lib/apache"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Inspector relies on couple of Ironic variables"},{"line_number":17,"context_line":"source $TARGET_RELEASE_DIR/ironic/devstack/lib/ironic"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Keep track of the DevStack directory"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3aaa91ec_c23804f1","line":16,"updated":"2016-06-29 17:40:42.000000000","message":"Nit: \"a couple\"","commit_id":"befffe94de89cefaeb53d04b9934d680d5a519d3"}],"devstack/upgrade/upgrade.sh":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4bb0a35b39000090823c0e0f28648651b64cf763","unresolved":false,"context_lines":[{"line_number":22,"context_line":"trap cleanup SIGHUP SIGINT SIGTERM"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Keep track of the grenade directory"},{"line_number":25,"context_line":"RUN_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Source params"},{"line_number":28,"context_line":"source $GRENADE_DIR/grenaderc"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_a608fada","line":25,"updated":"2016-06-27 13:44:55.000000000","message":"Can this just be `dirname \"$0\"`?\n\nAlso, the name\u0027s confusing - I\u0027d expect $RUN_DIR to contain the working directory from which the script was invoked.","commit_id":"baca9c208f56a9043e7d870fe77c34fdd420ed13"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4bb0a35b39000090823c0e0f28648651b64cf763","unresolved":false,"context_lines":[{"line_number":50,"context_line":"source $TARGET_RELEASE_DIR/ironic/devstack/lib/ironic"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Keep track of the DevStack directory"},{"line_number":53,"context_line":"INSPECTOR_DEVSTACK_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":54,"context_line":"INSPECTOR_PLUGIN\u003d$INSPECTOR_DEVSTACK_DIR/plugin.sh"},{"line_number":55,"context_line":"source $INSPECTOR_PLUGIN"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_06fd8e6e","line":53,"updated":"2016-06-27 13:44:55.000000000","message":"You can save a subshell - $(realpath $RUN_DIR/..). Or just \"$RUN_DIR/..\".","commit_id":"baca9c208f56a9043e7d870fe77c34fdd420ed13"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4bb0a35b39000090823c0e0f28648651b64cf763","unresolved":false,"context_lines":[{"line_number":55,"context_line":"source $INSPECTOR_PLUGIN"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Print the commands being run so that we can see the command that triggers"},{"line_number":58,"context_line":"# an error.  It is also useful for following allowing as the install occurs."},{"line_number":59,"context_line":"set -o xtrace"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"initialize_database_backends"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_86f17e98","line":58,"updated":"2016-06-27 13:44:55.000000000","message":"s/allowing/along","commit_id":"baca9c208f56a9043e7d870fe77c34fdd420ed13"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4bb0a35b39000090823c0e0f28648651b64cf763","unresolved":false,"context_lines":[{"line_number":61,"context_line":"initialize_database_backends"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"function is_nova_migration {"},{"line_number":64,"context_line":"    # Deterine whether we\u0027re \"upgrading\" from another compute driver"},{"line_number":65,"context_line":"    _ironic_old_driver\u003d$(source $BASE_DEVSTACK_DIR/functions; source $BASE_DEVSTACK_DIR/localrc; echo $VIRT_DRIVER)"},{"line_number":66,"context_line":"    [ \"$_ironic_old_driver\" !\u003d \"ironic\" ]"},{"line_number":67,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_86921ef5","line":64,"updated":"2016-06-27 13:44:55.000000000","message":"Typo: \"Determine\"","commit_id":"baca9c208f56a9043e7d870fe77c34fdd420ed13"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4bb0a35b39000090823c0e0f28648651b64cf763","unresolved":false,"context_lines":[{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Duplicate all required devstack setup that is needed before starting"},{"line_number":70,"context_line":"# Inspector during a sideways upgrade, where we are migrating from an"},{"line_number":71,"context_line":"# devstack environment without Inspector."},{"line_number":72,"context_line":"function init_inspector {"},{"line_number":73,"context_line":"    # We need to source credentials here but doing so in the gate will unset"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_066c6e07","line":70,"updated":"2016-06-27 13:44:55.000000000","message":"Nit: s/an/a","commit_id":"baca9c208f56a9043e7d870fe77c34fdd420ed13"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4bb0a35b39000090823c0e0f28648651b64cf763","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# Inspector during a sideways upgrade, where we are migrating from an"},{"line_number":71,"context_line":"# devstack environment without Inspector."},{"line_number":72,"context_line":"function init_inspector {"},{"line_number":73,"context_line":"    # We need to source credentials here but doing so in the gate will unset"},{"line_number":74,"context_line":"    # HOST_IP."},{"line_number":75,"context_line":"    local tmp_host_ip\u003d$HOST_IP"},{"line_number":76,"context_line":"    source $TARGET_DEVSTACK_DIR/openrc admin admin"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_26736ae9","line":73,"updated":"2016-06-27 13:44:55.000000000","message":"I hate bash so much.","commit_id":"baca9c208f56a9043e7d870fe77c34fdd420ed13"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4bb0a35b39000090823c0e0f28648651b64cf763","unresolved":false,"context_lines":[{"line_number":104,"context_line":"# FIXME(milan): using Ironic\u0027s detection; not sure whether it\u0027s needed"},{"line_number":105,"context_line":"# If we are sideways upgrading and migrating from a base deployed /w"},{"line_number":106,"context_line":"# VIRT_DRIVER\u003dfake, we need to run Inspector install, config and init"},{"line_number":107,"context_line":"# code from devstac."},{"line_number":108,"context_line":"if is_nova_migration ; then"},{"line_number":109,"context_line":"    init_inspector"},{"line_number":110,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3aaa91ec_66545221","line":107,"updated":"2016-06-27 13:44:55.000000000","message":"Nit: \"devstack\"","commit_id":"baca9c208f56a9043e7d870fe77c34fdd420ed13"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"7a25f718a7bae0f20dd4efbd6e00369175573b6d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"initialize_database_backends"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"function is_nova_migration {"},{"line_number":64,"context_line":"    # Deterine whether we\u0027re \"upgrading\" from another compute driver"},{"line_number":65,"context_line":"    _ironic_old_driver\u003d$(source $BASE_DEVSTACK_DIR/functions; source $BASE_DEVSTACK_DIR/localrc; echo $VIRT_DRIVER)"},{"line_number":66,"context_line":"    [ \"$_ironic_old_driver\" !\u003d \"ironic\" ]"},{"line_number":67,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3aaa91ec_fd6961bf","line":64,"updated":"2016-06-29 17:40:42.000000000","message":"Typo: \"Determine\"","commit_id":"befffe94de89cefaeb53d04b9934d680d5a519d3"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"7a25f718a7bae0f20dd4efbd6e00369175573b6d","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# FIXME(milan): using Ironic\u0027s detection; not sure whether it\u0027s needed"},{"line_number":105,"context_line":"# If we are sideways upgrading and migrating from a base deployed /w"},{"line_number":106,"context_line":"# VIRT_DRIVER\u003dfake, we need to run Inspector install, config and init"},{"line_number":107,"context_line":"# code from devstac."},{"line_number":108,"context_line":"if is_nova_migration ; then"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3aaa91ec_fd97a18d","line":105,"updated":"2016-06-29 17:40:42.000000000","message":"/w -\u003e w/","commit_id":"befffe94de89cefaeb53d04b9934d680d5a519d3"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"7a25f718a7bae0f20dd4efbd6e00369175573b6d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"# FIXME(milan): using Ironic\u0027s detection; not sure whether it\u0027s needed"},{"line_number":105,"context_line":"# If we are sideways upgrading and migrating from a base deployed /w"},{"line_number":106,"context_line":"# VIRT_DRIVER\u003dfake, we need to run Inspector install, config and init"},{"line_number":107,"context_line":"# code from devstac."},{"line_number":108,"context_line":"if is_nova_migration ; then"},{"line_number":109,"context_line":"    init_inspector"},{"line_number":110,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3aaa91ec_bdf079fe","line":107,"updated":"2016-06-29 17:40:42.000000000","message":"\"devstack\"","commit_id":"befffe94de89cefaeb53d04b9934d680d5a519d3"}]}
