)]}'
{"ironic_inspector/test/inspector_tempest_plugin/tests/manager.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"3c797f861cfd319361c45fe99e493e9d669e797e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic_inspector.test.inspector_tempest_plugin import exceptions"},{"line_number":22,"context_line":"from ironic_inspector.test.inspector_tempest_plugin.services import \\"},{"line_number":23,"context_line":"    introspection_client"},{"line_number":24,"context_line":"from ironic_tempest_plugin.tests.api.admin.api_microversion_fixture import \\"},{"line_number":25,"context_line":"    APIMicroversionFixture as IronicMicroversionFixture"},{"line_number":26,"context_line":"from ironic_tempest_plugin.tests.scenario.baremetal_manager import \\"},{"line_number":27,"context_line":"    BaremetalProvisionStates"},{"line_number":28,"context_line":"from ironic_tempest_plugin.tests.scenario.baremetal_manager import \\"},{"line_number":29,"context_line":"    BaremetalScenarioTest"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_143767b1","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":28},"updated":"2016-07-18 12:53:00.000000000","message":"nit: we shouldn\u0027t import objects, only modules","commit_id":"0d03803a3a408645c92d110beb8db369e0ffb6e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3f82b0080b053eb00eda62b3366d2efdc32e7c3","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic_inspector.test.inspector_tempest_plugin import exceptions"},{"line_number":22,"context_line":"from ironic_inspector.test.inspector_tempest_plugin.services import \\"},{"line_number":23,"context_line":"    introspection_client"},{"line_number":24,"context_line":"from ironic_tempest_plugin.tests.api.admin.api_microversion_fixture import \\"},{"line_number":25,"context_line":"    APIMicroversionFixture as IronicMicroversionFixture"},{"line_number":26,"context_line":"from ironic_tempest_plugin.tests.scenario.baremetal_manager import \\"},{"line_number":27,"context_line":"    BaremetalProvisionStates"},{"line_number":28,"context_line":"from ironic_tempest_plugin.tests.scenario.baremetal_manager import \\"},{"line_number":29,"context_line":"    BaremetalScenarioTest"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_05ff2f02","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":28},"in_reply_to":"dada55a8_143767b1","updated":"2016-07-18 13:22:37.000000000","message":"Fully agree, but this is a copy-paste","commit_id":"0d03803a3a408645c92d110beb8db369e0ffb6e3"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"3c797f861cfd319361c45fe99e493e9d669e797e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class InspectorScenarioTest(BaremetalScenarioTest):"},{"line_number":36,"context_line":"    \"\"\"Provide harness to do Inspector scenario tests.\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    wait_provisioning_state_interval \u003d 15"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_54839fcc","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":41},"updated":"2016-07-18 12:53:00.000000000","message":"nit: we should do this configurable","commit_id":"0d03803a3a408645c92d110beb8db369e0ffb6e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3f82b0080b053eb00eda62b3366d2efdc32e7c3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class InspectorScenarioTest(BaremetalScenarioTest):"},{"line_number":36,"context_line":"    \"\"\"Provide harness to do Inspector scenario tests.\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    wait_provisioning_state_interval \u003d 15"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_e503fb0b","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":41},"in_reply_to":"dada55a8_54839fcc","updated":"2016-07-18 13:22:37.000000000","message":"ditto","commit_id":"0d03803a3a408645c92d110beb8db369e0ffb6e3"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"3c797f861cfd319361c45fe99e493e9d669e797e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                     \u0027timeout\u0027: timeout})"},{"line_number":158,"context_line":"                raise exceptions.HypervisorUpdateTimeout(message)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def node_cleanup(self, node_id):"},{"line_number":161,"context_line":"        if (self.node_show(node_id)[\u0027provision_state\u0027] \u003d\u003d"},{"line_number":162,"context_line":"           BaremetalProvisionStates.AVAILABLE):"},{"line_number":163,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_cf909698","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":20},"updated":"2016-07-18 12:53:00.000000000","message":"nit: better name would be nice, it will clean up only if automated cleaning configured","commit_id":"0d03803a3a408645c92d110beb8db369e0ffb6e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3f82b0080b053eb00eda62b3366d2efdc32e7c3","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                     \u0027timeout\u0027: timeout})"},{"line_number":158,"context_line":"                raise exceptions.HypervisorUpdateTimeout(message)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def node_cleanup(self, node_id):"},{"line_number":161,"context_line":"        if (self.node_show(node_id)[\u0027provision_state\u0027] \u003d\u003d"},{"line_number":162,"context_line":"           BaremetalProvisionStates.AVAILABLE):"},{"line_number":163,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_6510ab4f","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":20},"in_reply_to":"dada55a8_cf909698","updated":"2016-07-18 13:22:37.000000000","message":"I think clean up is fine too, but suggestions are welcome. Anyway, this is also a copy-paste","commit_id":"0d03803a3a408645c92d110beb8db369e0ffb6e3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"1133692f24ad7419c885d9b41c079adeababe7d1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic_inspector.test.inspector_tempest_plugin import exceptions"},{"line_number":22,"context_line":"from ironic_inspector.test.inspector_tempest_plugin.services import \\"},{"line_number":23,"context_line":"    introspection_client"},{"line_number":24,"context_line":"from ironic_tempest_plugin.tests.api.admin.api_microversion_fixture import \\"},{"line_number":25,"context_line":"    APIMicroversionFixture as IronicMicroversionFixture"},{"line_number":26,"context_line":"from ironic_tempest_plugin.tests.scenario.baremetal_manager import \\"},{"line_number":27,"context_line":"    BaremetalProvisionStates"},{"line_number":28,"context_line":"from ironic_tempest_plugin.tests.scenario.baremetal_manager import \\"},{"line_number":29,"context_line":"    BaremetalScenarioTest"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_e055fff9","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":28},"updated":"2016-07-27 08:36:23.000000000","message":"I know it\u0027s a copy-paste, but would be nice to import only the modules if you happen to update it once more","commit_id":"823f6d26a20a1d00b8b0ca788a2d45279189ab59"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b231bc92ad5565d1f585fc563c936decbe2dceac","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def node_cleanup(self, node_id):"},{"line_number":167,"context_line":"        if (self.node_show(node_id)[\u0027provision_state\u0027] \u003d\u003d"},{"line_number":168,"context_line":"           BaremetalProvisionStates.AVAILABLE):"},{"line_number":169,"context_line":"            return"},{"line_number":170,"context_line":"        try:"},{"line_number":171,"context_line":"            self.baremetal_client.set_node_provision_state(node_id, \u0027provide\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_d9def63c","line":168,"updated":"2016-07-27 09:56:22.000000000","message":"Nit: Indentation","commit_id":"823f6d26a20a1d00b8b0ca788a2d45279189ab59"}]}