)]}'
{"ironic_inspector/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"72373610adc2e90d105445728b193d6186fb900e","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        except KeyError as exc:"},{"line_number":414,"context_line":"            # callback function raises MissingHookError derived from KeyError"},{"line_number":415,"context_line":"            # on missing hook"},{"line_number":416,"context_line":"            LOG.critical(_LC(\u0027Hook %s failed to load or was not found\u0027),"},{"line_number":417,"context_line":"                         str(exc))"},{"line_number":418,"context_line":"            sys.exit(1)"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_15947de6","line":416,"updated":"2016-07-08 11:09:15.000000000","message":"Hook -\u003e Hook(s) as we now handle several hooks at once","commit_id":"cde0b6cab6a1585dfa2de0b3668d7d171f25e278"}],"ironic_inspector/plugins/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"72373610adc2e90d105445728b193d6186fb900e","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    :param args: arguments to pass to the hooks constructor."},{"line_number":156,"context_line":"    \"\"\""},{"line_number":157,"context_line":"    def missing_entrypoints_callback(names):"},{"line_number":158,"context_line":"        \"\"\"names is a set, i convert it into a comma separated list\"\"\""},{"line_number":159,"context_line":"        missing_names \u003d \u0027,\u0027.join(names)"},{"line_number":160,"context_line":"        raise MissingHookError(missing_names)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_d5fb1546","line":157,"updated":"2016-07-08 11:09:15.000000000","message":"lets move it outside of the parent function","commit_id":"cde0b6cab6a1585dfa2de0b3668d7d171f25e278"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"72373610adc2e90d105445728b193d6186fb900e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    \"\"\""},{"line_number":157,"context_line":"    def missing_entrypoints_callback(names):"},{"line_number":158,"context_line":"        \"\"\"names is a set, i convert it into a comma separated list\"\"\""},{"line_number":159,"context_line":"        missing_names \u003d \u0027,\u0027.join(names)"},{"line_number":160,"context_line":"        raise MissingHookError(missing_names)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    global _HOOKS_MGR"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_b5f8094b","line":159,"updated":"2016-07-08 11:09:15.000000000","message":"\u0027,\u0027 -\u003e \u0027, \u0027","commit_id":"cde0b6cab6a1585dfa2de0b3668d7d171f25e278"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8e834d9f3ce4782c72d1182c05e5d2bf62c27ee2","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def missing_entrypoints_callback(names):"},{"line_number":153,"context_line":"    \"\"\"names is a set, i convert it into a comma separated list\"\"\""},{"line_number":154,"context_line":"    missing_names \u003d \u0027, \u0027.join(names)"},{"line_number":155,"context_line":"    raise MissingHookError(missing_names)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_16ddaf14","line":153,"range":{"start_line":153,"start_character":7,"end_line":153,"end_character":63},"updated":"2016-07-18 11:48:42.000000000","message":"nit: maybe rephrase like \"Raise MissingHookError with comma-separated list of missing hooks\".","commit_id":"f1b08e2491c90fa4789b8d2ecd39d63a0e462dc8"}]}
