)]}'
{"ironic_inspector/introspect.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"327392f96080d10b4be8e4ac0dbf0c6358f793a6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                              node_info\u003dnode)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    bmc_address \u003d ir_utils.get_ipmi_address(node)"},{"line_number":92,"context_line":"    if netaddr.IPAddress(bmc_address).is_loopback():"},{"line_number":93,"context_line":"        LOG.warning(_LW(\u0027Loopback address %s won\\\u0027t be used for lookup\u0027),"},{"line_number":94,"context_line":"                    bmc_address, node_info\u003dnode)"},{"line_number":95,"context_line":"        bmc_address \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_5403a4b8","line":92,"updated":"2017-01-12 21:38:22.000000000","message":"get_ipmi_address may return None, and netaddr... will raise exception.\nPlease ensure that bmc_address is not None, or is valid IP address first.","commit_id":"fc6b01ceb60923f3973396d2649a8ac1b4f3ba25"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"82fb432224650614365127fb932fdfa8abaedeb2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                              node_info\u003dnode)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    bmc_address \u003d ir_utils.get_ipmi_address(node)"},{"line_number":92,"context_line":"    if netaddr.IPAddress(bmc_address).is_loopback():"},{"line_number":93,"context_line":"        LOG.warning(_LW(\u0027Loopback address %s won\\\u0027t be used for lookup\u0027),"},{"line_number":94,"context_line":"                    bmc_address, node_info\u003dnode)"},{"line_number":95,"context_line":"        bmc_address \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_f4e1f0ff","line":92,"in_reply_to":"7a3c09a3_14203c49","updated":"2017-01-12 21:39:40.000000000","message":"Also wondered why not add this check inside get_ipmi_address function.","commit_id":"fc6b01ceb60923f3973396d2649a8ac1b4f3ba25"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"70317f328b46325696717d712e6297492c8986bd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                              node_info\u003dnode)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    bmc_address \u003d ir_utils.get_ipmi_address(node)"},{"line_number":92,"context_line":"    if netaddr.IPAddress(bmc_address).is_loopback():"},{"line_number":93,"context_line":"        LOG.warning(_LW(\u0027Loopback address %s won\\\u0027t be used for lookup\u0027),"},{"line_number":94,"context_line":"                    bmc_address, node_info\u003dnode)"},{"line_number":95,"context_line":"        bmc_address \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_14203c49","line":92,"in_reply_to":"7a3c09a3_5403a4b8","updated":"2017-01-12 21:38:43.000000000","message":"https://github.com/openstack/ironic-inspector/blob/de04f7c5a0d768f54d2b20e78005638d7dba5781/ironic_inspector/common/ironic.py#L143","commit_id":"fc6b01ceb60923f3973396d2649a8ac1b4f3ba25"}]}