)]}'
{"ironic_inspector/rules.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"3cf2cce16056a9fd04b8411509a84291be6cfcec","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                                            \u0027provided: %s\u0027) % e,"},{"line_number":227,"context_line":"                                          node_info\u003dnode_info, data\u003ddata)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"            if not skip:"},{"line_number":230,"context_line":"                LOG.debug(\u0027Running %(what)s action `%(action)s %(params)s`\u0027,"},{"line_number":231,"context_line":"                          {\u0027action\u0027: act.action, \u0027params\u0027: act.params,"},{"line_number":232,"context_line":"                           \u0027what\u0027: method},"},{"line_number":233,"context_line":"                          node_info\u003dnode_info, data\u003ddata)"},{"line_number":234,"context_line":"                getattr(ext, method)(node_info, act.params)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        LOG.debug(\u0027Successfully applied %s\u0027,"},{"line_number":237,"context_line":"                  \u0027rollback actions\u0027 if rollback else \u0027actions\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_8e1bf019","line":234,"range":{"start_line":229,"start_character":12,"end_line":234,"end_character":59},"updated":"2017-05-16 13:30:55.000000000","message":"I guess more obvious would be a for--else statement:\n\n  for formatted_param in ext.FORMATTED_PARAMS:\n       ...\n       try:\n           act.params[formatted_param] \u003d value.format(data\u003ddata)\n       except KeyError as e:\n           if rollback:\n               LOG.warning(...)\n               break\n           else:\n               raise utils.Error(...)\n       ...\n  else:\n      LOG.debug(...)\n      getattr(ext, method)(node_info, act.params)","commit_id":"938c8c47274e7fdc12f91eb6f4ca9b49f12582ce"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"74c60767d4d7c85f0b2b79669f10ebba9b600315","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        ext_mgr \u003d plugins_base.rule_actions_manager()"},{"line_number":202,"context_line":"        for act in self._actions:"},{"line_number":203,"context_line":"            ext \u003d ext_mgr[act.action].obj"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            for formatted_param in ext.FORMATTED_PARAMS:"},{"line_number":206,"context_line":"                value \u003d act.params.get(formatted_param)"},{"line_number":207,"context_line":"                if not value or not isinstance(value, six.string_types):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_2d90594e","line":204,"updated":"2017-05-16 15:22:30.000000000","message":"nit: unrelated?","commit_id":"ce4fb101152db7c78ef5b1324192e069ba245cd1"}]}