)]}'
{"devstack/example.local.conf":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6d3077f9b0a1cda79a6cf317561e64efeac7d6f5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"disable_service cinder c-sch c-api c-vol"},{"line_number":27,"context_line":"disable_service tempest"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Swift temp URL\u0027s are required for the direct deploy drivers."},{"line_number":30,"context_line":"SWIFT_ENABLE_TEMPURLS\u003dTrue"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Create 2 virtual machines to pose as Ironic\u0027s baremetal nodes."}],"source_content_type":"text/plain","patch_set":2,"id":"3fa0c359_b95b3d85","line":29,"range":{"start_line":29,"start_character":54,"end_line":29,"end_character":61},"updated":"2018-02-20 09:30:21.000000000","message":"s/ drivers / interface /","commit_id":"0acae19e55faaae5f4699344c08b39e2b29a3af2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a875db7901d5b1565d742cd06bb1692e093b5c13","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# Swift temp URL\u0027s are required for the direct deploy drivers."},{"line_number":30,"context_line":"SWIFT_ENABLE_TEMPURLS\u003dTrue"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Create 2 virtual machines to pose as Ironic\u0027s baremetal nodes."},{"line_number":33,"context_line":"IRONIC_VM_COUNT\u003d3"},{"line_number":34,"context_line":"IRONIC_BAREMETAL_BASIC_OPS\u003dTrue"},{"line_number":35,"context_line":"DEFAULT_INSTANCE_TYPE\u003dbaremetal"}],"source_content_type":"text/plain","patch_set":2,"id":"3fa0c359_0592ff4b","line":32,"range":{"start_line":32,"start_character":9,"end_line":32,"end_character":10},"updated":"2018-02-20 14:31:55.000000000","message":"This number does not match the number on line 33.","commit_id":"0acae19e55faaae5f4699344c08b39e2b29a3af2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a875db7901d5b1565d742cd06bb1692e093b5c13","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# Don\u0027t forget that many hardware types require enabling of additional"},{"line_number":40,"context_line":"# interfaces, most often power and management:"},{"line_number":41,"context_line":"#IRONIC_ENABLED_MANAGEMENT_INTERFACES\u003dipmitool,fake"},{"line_number":42,"context_line":"#IRONIC_ENABLED_POWER_INTERFACES\u003dipmitool,fake"},{"line_number":43,"context_line":"# The \u0027ipmi\u0027 hardware type\u0027s default deploy interface is \u0027iscsi\u0027."},{"line_number":44,"context_line":"# This would change the default to \u0027direct\u0027:"},{"line_number":45,"context_line":"#IRONIC_DEFAULT_DEPLOY_INTERFACE\u003ddirect"}],"source_content_type":"text/plain","patch_set":2,"id":"3fa0c359_05bbdfc3","line":42,"updated":"2018-02-20 14:31:55.000000000","message":"Would it be possible ut an empty line between 42 and 43. Scanning it looks like one big block, but it has distinct settings.","commit_id":"0acae19e55faaae5f4699344c08b39e2b29a3af2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ecefe733778bc8b9616d2715d794ba39be6ca5bc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# Enable inspection via ironic-inspector"},{"line_number":49,"context_line":"IRONIC_ENABLED_INSPECT_INTERFACES\u003dinspector,no-inspect"},{"line_number":50,"context_line":"# Optionally make it the default for all hardware types:"},{"line_number":51,"context_line":"#IRONIC_DEFAULT_INSPECT_INTERFACE\u003dinspector"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# This driver should be in the enabled list above."},{"line_number":54,"context_line":"IRONIC_DEPLOY_DRIVER\u003dipmi"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa0c359_f9375efd","line":51,"updated":"2018-02-21 16:42:40.000000000","message":"given that this is the inspector project, I\u0027d think you\u0027d want to set this as the default, but I don\u0027t use inspector so ... :)","commit_id":"2e9a5f83e489de0d9a020f5d9c9297dee4524dc5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ae8ca4df4114c42fbd8912ab31704a9517f642f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# Enable inspection via ironic-inspector"},{"line_number":49,"context_line":"IRONIC_ENABLED_INSPECT_INTERFACES\u003dinspector,no-inspect"},{"line_number":50,"context_line":"# Optionally make it the default for all hardware types:"},{"line_number":51,"context_line":"#IRONIC_DEFAULT_INSPECT_INTERFACE\u003dinspector"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# This driver should be in the enabled list above."},{"line_number":54,"context_line":"IRONIC_DEPLOY_DRIVER\u003dipmi"}],"source_content_type":"text/plain","patch_set":3,"id":"df7087c5_ec188676","line":51,"in_reply_to":"3fa0c359_f9375efd","updated":"2018-03-07 12:15:20.000000000","message":"Done","commit_id":"2e9a5f83e489de0d9a020f5d9c9297dee4524dc5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ecefe733778bc8b9616d2715d794ba39be6ca5bc","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"VIRT_DRIVER\u003dironic"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"TEMPEST_ALLOW_TENANT_ISOLATION\u003dFalse"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# By default, DevStack creates a 10.0.0.0/24 network for instances."},{"line_number":64,"context_line":"# If this overlaps with the hosts network, you may adjust with the"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa0c359_391b8681","line":61,"updated":"2018-02-21 16:42:40.000000000","message":"i\u0027m surprised you need this, if tempest is disabled. (this is just a comment, outside the scope of this patch).","commit_id":"2e9a5f83e489de0d9a020f5d9c9297dee4524dc5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ae8ca4df4114c42fbd8912ab31704a9517f642f","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"VIRT_DRIVER\u003dironic"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"TEMPEST_ALLOW_TENANT_ISOLATION\u003dFalse"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# By default, DevStack creates a 10.0.0.0/24 network for instances."},{"line_number":64,"context_line":"# If this overlaps with the hosts network, you may adjust with the"}],"source_content_type":"text/plain","patch_set":3,"id":"df7087c5_6c74769a","line":61,"in_reply_to":"3fa0c359_391b8681","updated":"2018-03-07 12:15:20.000000000","message":"Actually, we should probably stop disabling tempest now that we have a working tempest plugin. However, ironic does not set this option, so I guess we shouldn\u0027t either.","commit_id":"2e9a5f83e489de0d9a020f5d9c9297dee4524dc5"}],"doc/source/user/usage.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ecefe733778bc8b9616d2715d794ba39be6ca5bc","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"For discovery, the configuration file option ``node_not_found_hook`` should be"},{"line_number":221,"context_line":"set to load the hook called ``enroll``. This hook will enroll the unidentified"},{"line_number":222,"context_line":"node into Ironic using the ``fake`` driver (this driver is a configurable"},{"line_number":223,"context_line":"option, set ``enroll_node_driver`` in the **ironic-inspector** configuration"},{"line_number":224,"context_line":"file, to the Ironic driver you want)."},{"line_number":225,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_349cebbe","line":222,"updated":"2018-02-21 16:42:40.000000000","message":"do we want to change this to s/fake/fake-hardware/ ?\n\nand maybe (not sure) s/driver/hardware type/ ?","commit_id":"2e9a5f83e489de0d9a020f5d9c9297dee4524dc5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ae8ca4df4114c42fbd8912ab31704a9517f642f","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"For discovery, the configuration file option ``node_not_found_hook`` should be"},{"line_number":221,"context_line":"set to load the hook called ``enroll``. This hook will enroll the unidentified"},{"line_number":222,"context_line":"node into Ironic using the ``fake`` driver (this driver is a configurable"},{"line_number":223,"context_line":"option, set ``enroll_node_driver`` in the **ironic-inspector** configuration"},{"line_number":224,"context_line":"file, to the Ironic driver you want)."},{"line_number":225,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_0c693abd","line":222,"in_reply_to":"3fa0c359_349cebbe","updated":"2018-03-07 12:15:20.000000000","message":"Mmm, we want to, but this is a configuration change. I\u0027d prefer to do it separately with a proper release note.","commit_id":"2e9a5f83e489de0d9a020f5d9c9297dee4524dc5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ecefe733778bc8b9616d2715d794ba39be6ca5bc","unresolved":false,"context_lines":[{"line_number":269,"context_line":"nodes in the introspection rules using the rule condition ``eq``::"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    {"},{"line_number":272,"context_line":"        \"description\": \"Enroll auto-discovered nodes with fake driver\","},{"line_number":273,"context_line":"        \"actions\": ["},{"line_number":274,"context_line":"            {\"action\": \"set-attribute\", \"path\": \"driver\", \"value\": \"fake\"}"},{"line_number":275,"context_line":"        ],"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_f43d238e","line":272,"updated":"2018-02-21 16:42:40.000000000","message":"if you change \u0027fake\u0027 above, probably want to change it here too","commit_id":"2e9a5f83e489de0d9a020f5d9c9297dee4524dc5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ae8ca4df4114c42fbd8912ab31704a9517f642f","unresolved":false,"context_lines":[{"line_number":269,"context_line":"nodes in the introspection rules using the rule condition ``eq``::"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    {"},{"line_number":272,"context_line":"        \"description\": \"Enroll auto-discovered nodes with fake driver\","},{"line_number":273,"context_line":"        \"actions\": ["},{"line_number":274,"context_line":"            {\"action\": \"set-attribute\", \"path\": \"driver\", \"value\": \"fake\"}"},{"line_number":275,"context_line":"        ],"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_4c7df26c","line":272,"in_reply_to":"3fa0c359_f43d238e","updated":"2018-03-07 12:15:20.000000000","message":"This can be changed even without changing above","commit_id":"2e9a5f83e489de0d9a020f5d9c9297dee4524dc5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ecefe733778bc8b9616d2715d794ba39be6ca5bc","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    {"},{"line_number":272,"context_line":"        \"description\": \"Enroll auto-discovered nodes with fake driver\","},{"line_number":273,"context_line":"        \"actions\": ["},{"line_number":274,"context_line":"            {\"action\": \"set-attribute\", \"path\": \"driver\", \"value\": \"fake\"}"},{"line_number":275,"context_line":"        ],"},{"line_number":276,"context_line":"        \"conditions\": ["},{"line_number":277,"context_line":"            {\"op\": \"eq\", \"field\": \"data://auto_discovered\", \"value\": true}"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_b44b1b29","line":274,"updated":"2018-02-21 16:42:40.000000000","message":"and here","commit_id":"2e9a5f83e489de0d9a020f5d9c9297dee4524dc5"}]}