)]}'
{"ironic_inspector/conductor/manager.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1c9d380ec4d21769241cb70e1c8323e0335353d5","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        if utils.executor().alive:"},{"line_number":115,"context_line":"            utils.executor().shutdown(wait\u003dTrue)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if self._zeroconf is not None:"},{"line_number":118,"context_line":"            self._zeroconf.close()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self._shutting_down.release()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffb9cba7_76d14efb","line":117,"updated":"2019-04-26 12:47:33.000000000","message":"I would stop advertising as one of the first actions during shutdown, so maybe move this up","commit_id":"b0871a13f7b6c16d648182699db14df57f6067dd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"d02311829e6df37522e3b0e173cadc9f93aa9f53","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        if utils.executor().alive:"},{"line_number":115,"context_line":"            utils.executor().shutdown(wait\u003dTrue)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if self._zeroconf is not None:"},{"line_number":118,"context_line":"            self._zeroconf.close()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self._shutting_down.release()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_ca288687","line":117,"in_reply_to":"ffb9cba7_76d14efb","updated":"2019-05-24 03:20:41.000000000","message":"++","commit_id":"b0871a13f7b6c16d648182699db14df57f6067dd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b1abd5770277880b00fc87dc60f7998fe7c598e2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            self._zeroconf \u003d mdns.Zeroconf()"},{"line_number":95,"context_line":"            self._zeroconf.register_service(\u0027baremetal-introspection\u0027,"},{"line_number":96,"context_line":"                                            endpoint)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def del_host(self):"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if not self._shutting_down.acquire(blocking\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_3e4ac1ab","line":97,"updated":"2019-05-24 08:52:43.000000000","message":"I feel it\u0027s better to have a common mdns module to hold the init/del stuff, so the conductor won\u0027t see the zeroconf here and there. Also probably in the future we want to make this option mutable. We may have a flexible control on the service broadcasting by doing so.\nAnyway, as the initial support, I am good with it.","commit_id":"258d7388a4493493d3dacd7dd459970c0bd08d61"}],"ironic_inspector/test/unit/test_manager.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b1abd5770277880b00fc87dc60f7998fe7c598e2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    @mock.patch.object(mdns, \u0027Zeroconf\u0027, autospec\u003dTrue)"},{"line_number":105,"context_line":"    def test_init_host(self, mock_zc):"},{"line_number":106,"context_line":"        self.manager.init_host()"},{"line_number":107,"context_line":"        self.mock_db_init.assert_called_once_with()"},{"line_number":108,"context_line":"        self.mock_validate_processing_hooks.assert_called_once_with()"},{"line_number":109,"context_line":"        self.mock_filter.init_filter.assert_called_once_with()"},{"line_number":110,"context_line":"        self.assert_periodics()"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_5eb3f598","line":107,"updated":"2019-05-24 08:52:43.000000000","message":"Your eyes must be shining :)","commit_id":"258d7388a4493493d3dacd7dd459970c0bd08d61"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1e30f85ff3ccaa707901f877be04a49c6a0576d7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    @mock.patch.object(mdns, \u0027Zeroconf\u0027, autospec\u003dTrue)"},{"line_number":105,"context_line":"    def test_init_host(self, mock_zc):"},{"line_number":106,"context_line":"        self.manager.init_host()"},{"line_number":107,"context_line":"        self.mock_db_init.assert_called_once_with()"},{"line_number":108,"context_line":"        self.mock_validate_processing_hooks.assert_called_once_with()"},{"line_number":109,"context_line":"        self.mock_filter.init_filter.assert_called_once_with()"},{"line_number":110,"context_line":"        self.assert_periodics()"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_b7053913","line":107,"in_reply_to":"bfb3d3c7_5eb3f598","updated":"2019-05-29 07:32:26.000000000","message":"oh gosh :/","commit_id":"258d7388a4493493d3dacd7dd459970c0bd08d61"}]}