)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e6221303efb2d9723f30436c4157ba13c90cb4b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add storing introspection data in database option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ironic-inspector database is a default config for"},{"line_number":10,"context_line":"our devstack deploy. Sometimes we won\u0027t to use Swift,"},{"line_number":11,"context_line":"and directly use database for store data."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch adds a variable for introspection"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dfbec78f_d01db60f","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":39},"updated":"2019-05-09 08:00:34.000000000","message":"nit: s/won\u0027t/don\u0027t want","commit_id":"d83524c8c7d801c6efca1f7bb38416f2cf0d0c43"}],"devstack/example.local.conf":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"50f1db9b5b3f477c100b1e14dc2408bab8939b3d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"disable_service n-net n-novnc"},{"line_number":14,"context_line":"enable_service neutron q-svc q-agt q-dhcp q-l3 q-meta"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Default storing introspection data in Swift, if we won\u0027t use Swift,"},{"line_number":17,"context_line":"# We can modify this value to \"database\" which stores in ironic-inspector"},{"line_number":18,"context_line":"# database and disable Swift service."},{"line_number":19,"context_line":"IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\u003dswift"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Enable Swift for storing introspection data, if we using \"database\" stores"},{"line_number":22,"context_line":"# introspection data, we can disable these services."}],"source_content_type":"text/plain","patch_set":2,"id":"dfbec78f_cdaafdd0","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":47},"updated":"2019-05-09 06:19:36.000000000","message":"maybe change to this:\n\n# Use database as the introspection data backend, if needed.\n#IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\u003ddatabase","commit_id":"e2411598479b008b2591d2cd7541ed8cbb168c7f"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4ecbe116c6421e6fb7e84b04a44daf030113dfec","unresolved":false,"context_lines":[{"line_number":13,"context_line":"disable_service n-net n-novnc"},{"line_number":14,"context_line":"enable_service neutron q-svc q-agt q-dhcp q-l3 q-meta"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Default storing introspection data in Swift, if we won\u0027t use Swift,"},{"line_number":17,"context_line":"# We can modify this value to \"database\" which stores in ironic-inspector"},{"line_number":18,"context_line":"# database and disable Swift service."},{"line_number":19,"context_line":"IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\u003dswift"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Enable Swift for storing introspection data, if we using \"database\" stores"},{"line_number":22,"context_line":"# introspection data, we can disable these services."}],"source_content_type":"text/plain","patch_set":2,"id":"dfbec78f_cdad1d32","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":47},"in_reply_to":"dfbec78f_cdaafdd0","updated":"2019-05-09 07:13:10.000000000","message":"ok, this seems more clear.","commit_id":"e2411598479b008b2591d2cd7541ed8cbb168c7f"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"50f1db9b5b3f477c100b1e14dc2408bab8939b3d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# database and disable Swift service."},{"line_number":19,"context_line":"IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\u003dswift"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Enable Swift for storing introspection data, if we using \"database\" stores"},{"line_number":22,"context_line":"# introspection data, we can disable these services."},{"line_number":23,"context_line":"enable_service s-proxy s-object s-container s-account"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Enable Ironic, Ironic Inspector plugins"}],"source_content_type":"text/plain","patch_set":2,"id":"dfbec78f_6db9912c","line":22,"range":{"start_line":21,"start_character":47,"end_line":22,"end_character":52},"updated":"2019-05-09 06:19:36.000000000","message":"maybe change to this:\n\nthese services can be disabled if introspection data store is set to database.","commit_id":"e2411598479b008b2591d2cd7541ed8cbb168c7f"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4ecbe116c6421e6fb7e84b04a44daf030113dfec","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# database and disable Swift service."},{"line_number":19,"context_line":"IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\u003dswift"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Enable Swift for storing introspection data, if we using \"database\" stores"},{"line_number":22,"context_line":"# introspection data, we can disable these services."},{"line_number":23,"context_line":"enable_service s-proxy s-object s-container s-account"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Enable Ironic, Ironic Inspector plugins"}],"source_content_type":"text/plain","patch_set":2,"id":"dfbec78f_6dac3134","line":22,"range":{"start_line":21,"start_character":47,"end_line":22,"end_character":52},"in_reply_to":"dfbec78f_6db9912c","updated":"2019-05-09 07:13:10.000000000","message":"Done","commit_id":"e2411598479b008b2591d2cd7541ed8cbb168c7f"}],"devstack/plugin.sh":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"50f1db9b5b3f477c100b1e14dc2408bab8939b3d","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    iniset_rpc_backend ironic-inspector $IRONIC_INSPECTOR_CONF_FILE"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    if [[ \"$IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\" \u003d\u003d \"database\" ]]; then"},{"line_number":278,"context_line":"        inspector_iniset processing store_data database"},{"line_number":279,"context_line":"    fi"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    if is_service_enabled swift \u0026\u0026 [[ \"$IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\" \u003d\u003d \"swift\" ]]; then"},{"line_number":282,"context_line":"        configure_inspector_swift"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dfbec78f_6d6431e5","line":279,"range":{"start_line":277,"start_character":0,"end_line":279,"end_character":6},"updated":"2019-05-09 06:19:36.000000000","message":"inspector_iniset processing store_data $IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\n\nwould be fine","commit_id":"e2411598479b008b2591d2cd7541ed8cbb168c7f"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4ecbe116c6421e6fb7e84b04a44daf030113dfec","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    iniset_rpc_backend ironic-inspector $IRONIC_INSPECTOR_CONF_FILE"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    if [[ \"$IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\" \u003d\u003d \"database\" ]]; then"},{"line_number":278,"context_line":"        inspector_iniset processing store_data database"},{"line_number":279,"context_line":"    fi"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    if is_service_enabled swift \u0026\u0026 [[ \"$IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\" \u003d\u003d \"swift\" ]]; then"},{"line_number":282,"context_line":"        configure_inspector_swift"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dfbec78f_ad7789d4","line":279,"range":{"start_line":277,"start_character":0,"end_line":279,"end_character":6},"in_reply_to":"dfbec78f_6d6431e5","updated":"2019-05-09 07:13:10.000000000","message":"Done","commit_id":"e2411598479b008b2591d2cd7541ed8cbb168c7f"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"50f1db9b5b3f477c100b1e14dc2408bab8939b3d","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    fi"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    if is_service_enabled swift \u0026\u0026 [[ \"$IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\" \u003d\u003d \"swift\" ]]; then"},{"line_number":282,"context_line":"        configure_inspector_swift"},{"line_number":283,"context_line":"    fi"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    iniset \"$IRONIC_CONF_FILE\" inspector enabled True"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dfbec78f_2d9cf9be","line":282,"updated":"2019-05-09 06:19:36.000000000","message":"I\u0027d prefer to leave it untouched","commit_id":"e2411598479b008b2591d2cd7541ed8cbb168c7f"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4ecbe116c6421e6fb7e84b04a44daf030113dfec","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    fi"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    if is_service_enabled swift \u0026\u0026 [[ \"$IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE\" \u003d\u003d \"swift\" ]]; then"},{"line_number":282,"context_line":"        configure_inspector_swift"},{"line_number":283,"context_line":"    fi"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    iniset \"$IRONIC_CONF_FILE\" inspector enabled True"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dfbec78f_cd72fde3","line":282,"in_reply_to":"dfbec78f_2d9cf9be","updated":"2019-05-09 07:13:10.000000000","message":"Done","commit_id":"e2411598479b008b2591d2cd7541ed8cbb168c7f"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ac8a43066d6addfaa5e50ed5d59e53c480766bfb","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            iniset $TEMPEST_CONFIG baremetal_introspection auto_discovery_feature True"},{"line_number":451,"context_line":"            iniset $TEMPEST_CONFIG baremetal_introspection auto_discovery_default_driver fake-hardware"},{"line_number":452,"context_line":"            iniset $TEMPEST_CONFIG baremetal_introspection auto_discovery_target_driver ipmi"},{"line_number":453,"context_line":"            iniset $TEMPEST_CONFIG baremetal_introspection data_store $IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE"},{"line_number":454,"context_line":"        fi"},{"line_number":455,"context_line":"    fi"},{"line_number":456,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfbec78f_aa41990d","line":453,"updated":"2019-05-10 02:26:52.000000000","message":"this line should be out side of the not-found-hook, unless you exactly want to change the auto discovery job.","commit_id":"1ef08a2ce0089942b6654bde5766996e92c8f78d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"2a5d70d1eff48d28ebbaddaa045a831b73f702ca","unresolved":false,"context_lines":[{"line_number":450,"context_line":"            iniset $TEMPEST_CONFIG baremetal_introspection auto_discovery_feature True"},{"line_number":451,"context_line":"            iniset $TEMPEST_CONFIG baremetal_introspection auto_discovery_default_driver fake-hardware"},{"line_number":452,"context_line":"            iniset $TEMPEST_CONFIG baremetal_introspection auto_discovery_target_driver ipmi"},{"line_number":453,"context_line":"            iniset $TEMPEST_CONFIG baremetal_introspection data_store $IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE"},{"line_number":454,"context_line":"        fi"},{"line_number":455,"context_line":"    fi"},{"line_number":456,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfbec78f_cab5edce","line":453,"in_reply_to":"dfbec78f_aa41990d","updated":"2019-05-10 02:46:08.000000000","message":"Done","commit_id":"1ef08a2ce0089942b6654bde5766996e92c8f78d"}],"zuul.d/ironic-inspector-jobs.yaml":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ac8a43066d6addfaa5e50ed5d59e53c480766bfb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        IRONIC_INSPECTOR_NODE_NOT_FOUND_HOOK: enroll"},{"line_number":27,"context_line":"        IRONIC_INSPECTOR_CLEAN_UP_PERIOD: 5"},{"line_number":28,"context_line":"        IRONIC_INSPECTOR_DHCP_FILTER: iptables"},{"line_number":29,"context_line":"        IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE: database"},{"line_number":30,"context_line":"        SWIFT_ENABLE_TEMPURLS: True"},{"line_number":31,"context_line":"        SWIFT_TEMPURL_KEY: secretkey"},{"line_number":32,"context_line":"        USE_PYTHON3: False"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dfbec78f_cacf2dae","line":29,"updated":"2019-05-10 02:26:52.000000000","message":"you should not change the base job, this change makes swift backend untested, you can pick one of two jobs below.","commit_id":"1ef08a2ce0089942b6654bde5766996e92c8f78d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"2a5d70d1eff48d28ebbaddaa045a831b73f702ca","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        IRONIC_INSPECTOR_NODE_NOT_FOUND_HOOK: enroll"},{"line_number":27,"context_line":"        IRONIC_INSPECTOR_CLEAN_UP_PERIOD: 5"},{"line_number":28,"context_line":"        IRONIC_INSPECTOR_DHCP_FILTER: iptables"},{"line_number":29,"context_line":"        IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE: database"},{"line_number":30,"context_line":"        SWIFT_ENABLE_TEMPURLS: True"},{"line_number":31,"context_line":"        SWIFT_TEMPURL_KEY: secretkey"},{"line_number":32,"context_line":"        USE_PYTHON3: False"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dfbec78f_6acc016a","line":29,"in_reply_to":"dfbec78f_cacf2dae","updated":"2019-05-10 02:46:08.000000000","message":"Done","commit_id":"1ef08a2ce0089942b6654bde5766996e92c8f78d"}]}