)]}'
{"id":"openstack%2Fironic-inspector~660310","triplet_id":"openstack%2Fironic-inspector~stable%2Focata~I2b0ffa307ec1aa57538733f2e454d2d7e994d656","project":"openstack/ironic-inspector","branch":"stable/ocata","hashtags":[],"change_id":"I2b0ffa307ec1aa57538733f2e454d2d7e994d656","subject":"Eliminate SQL injection vulnerability in node_cache","status":"MERGED","created":"2019-05-21 09:06:02.000000000","updated":"2019-05-21 14:35:42.000000000","submitted":"2019-05-21 14:35:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"660310-1558449342948-5d02b967","meta_rev_id":"9334dc615b36d7611df729343a340bb4a9599a3b","_number":660310,"virtual_id_number":660310,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":2,"date":"2019-05-21 14:35:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":2,"date":"2019-05-21 11:52:55.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"date":"2019-05-21 09:06:02.000000000","_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":1,"date":"2019-05-21 11:52:55.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-21 09:06:02.000000000","updated_by":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"reviewer":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"state":"REVIEWER"},{"updated":"2019-05-21 11:52:55.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2019-05-21 14:35:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"99e4a5f1c4a295e752607c896ff6ee7785c31e46","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-05-21 09:06:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b5e944b75aa71513a44aa6d6fb246984792974f7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 10:21:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/10/660310/1/check/openstack-tox-pep8/6e026c2/ : SUCCESS in 8m 06s\n- openstack-tox-py27 http://logs.openstack.org/10/660310/1/check/openstack-tox-py27/97dadc6/ : SUCCESS in 5m 08s\n- openstack-tox-py35 http://logs.openstack.org/10/660310/1/check/openstack-tox-py35/5359ec2/ : SUCCESS in 8m 16s\n- build-openstack-sphinx-docs http://logs.openstack.org/10/660310/1/check/build-openstack-sphinx-docs/ce9b7d3/html/ : SUCCESS in 6m 17s\n- build-openstack-releasenotes http://logs.openstack.org/10/660310/1/check/build-openstack-releasenotes/896df5d/html/ : SUCCESS in 4m 51s\n- ironic-inspector-tempest-dsvm-discovery http://logs.openstack.org/10/660310/1/check/ironic-inspector-tempest-dsvm-discovery/60ea7de/ : SUCCESS in 39m 46s\n- openstack-tox-functional http://logs.openstack.org/10/660310/1/check/openstack-tox-functional/ac75173/ : SUCCESS in 5m 52s\n- openstack-tox-functional-py35 http://logs.openstack.org/10/660310/1/check/openstack-tox-functional-py35/77d53d8/ : SUCCESS in 6m 04s\n- ironic-tempest-dsvm-ironic-inspector http://logs.openstack.org/10/660310/1/check/ironic-tempest-dsvm-ironic-inspector/78147ac/ : SUCCESS in 53m 38s\n- openstack-tox-cover http://logs.openstack.org/10/660310/1/check/openstack-tox-cover/05ab0f9/cover/ : SUCCESS in 5m 19s","accounts_in_message":[],"_revision_number":1},{"id":"7350cbc9f9b2c7baf8889cae5ec685d8bf79b704","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2019-05-21 11:52:55.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b3fab4127aade7d7229c90996e959885fa5a7d5f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 11:53:07.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"eb7442f37c7dfa61bc3d9d17346abb091ecfdcf4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 14:35:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/10/660310/1/gate/openstack-tox-pep8/63cb249/ : SUCCESS in 4m 06s\n- openstack-tox-py27 http://logs.openstack.org/10/660310/1/gate/openstack-tox-py27/74ef962/ : SUCCESS in 6m 19s\n- openstack-tox-py35 http://logs.openstack.org/10/660310/1/gate/openstack-tox-py35/a9b5b6e/ : SUCCESS in 6m 34s\n- build-openstack-sphinx-docs http://logs.openstack.org/10/660310/1/gate/build-openstack-sphinx-docs/b28bb04/html/ : SUCCESS in 4m 03s\n- build-openstack-releasenotes http://logs.openstack.org/10/660310/1/gate/build-openstack-releasenotes/21ddadb/html/ : SUCCESS in 4m 35s\n- ironic-inspector-tempest-dsvm-discovery http://logs.openstack.org/10/660310/1/gate/ironic-inspector-tempest-dsvm-discovery/3507a73/ : SUCCESS in 38m 36s\n- openstack-tox-functional http://logs.openstack.org/10/660310/1/gate/openstack-tox-functional/f8ceec4/ : SUCCESS in 5m 58s\n- openstack-tox-functional-py35 http://logs.openstack.org/10/660310/1/gate/openstack-tox-functional-py35/d2a6572/ : SUCCESS in 6m 00s\n- ironic-tempest-dsvm-ironic-inspector http://logs.openstack.org/10/660310/1/gate/ironic-tempest-dsvm-ironic-inspector/13d7269/ : SUCCESS in 53m 50s\n- openstack-tox-cover http://logs.openstack.org/10/660310/1/gate/openstack-tox-cover/76b96e6/cover/ : SUCCESS in 5m 20s","accounts_in_message":[],"_revision_number":1},{"id":"9334dc615b36d7611df729343a340bb4a9599a3b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 14:35:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"315fbc94fa095ebb8f4ad471d2b560b64796ee33","revisions":{"315fbc94fa095ebb8f4ad471d2b560b64796ee33":{"kind":"REWORK","_number":1,"created":"2019-05-21 09:06:02.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/10/660310/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-inspector","ref":"refs/changes/10/660310/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-inspector refs/changes/10/660310/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-inspector refs/changes/10/660310/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-inspector refs/changes/10/660310/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-inspector refs/changes/10/660310/1"}}},"commit":{"parents":[{"commit":"725913a3d7a4811307d80085feb4fd8a710b1ee2","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-inspector/commit/725913a3d7a4811307d80085feb4fd8a710b1ee2"}]}],"author":{"name":"Zane Bitter","email":"zbitter@redhat.com","date":"2019-05-14 19:39:19.000000000","tz":-240},"committer":{"name":"Dmitry Tantsur","email":"divius.inside@gmail.com","date":"2019-05-21 09:05:40.000000000","tz":120},"subject":"Eliminate SQL injection vulnerability in node_cache","message":"Eliminate SQL injection vulnerability in node_cache\n\nIn node_cache.find_node() we were constructing a raw SQL query using\nunescaped data that came in on the wire. This presented an SQL injection\nvulnerability. To avoid this, use the query builder from SQLAlchemy to\nensure that any input strings are correctly escaped.\n\nConflicts:\n\tironic_inspector/node_cache.py\n\nChange-Id: I2b0ffa307ec1aa57538733f2e454d2d7e994d656\nStory: #2005678\nTask: 30992\n(cherry picked from commit 9d107900b2e0b599397b84409580d46e0ed16291)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-inspector/commit/315fbc94fa095ebb8f4ad471d2b560b64796ee33"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-inspector/commit/315fbc94fa095ebb8f4ad471d2b560b64796ee33"}]},"branch":"refs/heads/stable/ocata"}},"requirements":[],"submit_records":[],"submit_requirements":[]}